Re: [jdk23] RFR: 8324841: PKCS11 tests still skip execution

2024-07-15 Thread Jaikiran Pai
On Mon, 24 Jun 2024 12:31:20 GMT, Matthew Donovan wrote: > 8324841: PKCS11 tests still skip execution This is a clean backport of a test-only fix. Looks good to me for JDK 23. - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19857#pullrequestrev

Re: [jdk23] RFR: 8324841: PKCS11 tests still skip execution

2024-07-15 Thread Matthew Donovan
On Mon, 24 Jun 2024 12:31:20 GMT, Matthew Donovan wrote: > 8324841: PKCS11 tests still skip execution Hello, I still need a reviewer for this small backport. Thanks! - PR Comment: https://git.openjdk.org/jdk/pull/19857#issuecomment-2228282469

[jdk23] RFR: 8324841: PKCS11 tests still skip execution

2024-06-24 Thread Matthew Donovan
8324841: PKCS11 tests still skip execution - Commit messages: - Backport 9d4a4bd2c2a4bd16bbc80b602b15b448c52220f6 Changes: https://git.openjdk.org/jdk/pull/19857/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19857&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324

Re: RFR: 8324841: PKCS11 tests still skip execution

2024-06-21 Thread Valerie Peng
On Tue, 18 Jun 2024 12:13:13 GMT, Matthew Donovan wrote: > In this PR, I updated PKCS11Test to throw a RuntimeException if the NSS > binaries are not found in a directory specified with the property > jdk.test.lib.artifacts.nsslib-. If the property is not specified, > the tests will throw a S

RFR: 8324841: PKCS11 tests still skip execution

2024-06-18 Thread Matthew Donovan
In this PR, I updated PKCS11Test to throw a RuntimeException if the NSS binaries are not found in a directory specified with the property jdk.test.lib.artifacts.nsslib-. If the property is not specified, the tests will throw a SkippedException. - Commit messages: - 8324841: PKCS1