On Fri, 10 May 2024 21:13:22 GMT, Kevin Driver wrote:
>> src/java.base/share/classes/javax/crypto/KDFSpi.java line 45:
>>
>>> 43: * provides access to the KDF alg params for implementers of the Spi
>>> 44: */
>>> 45: protected final AlgorithmParameterSpec algorithmParameterSpec;
>>
On Mon, 13 May 2024 14:01:46 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> re-enable preview annotations
>
> src/java.base/share/classes/javax/crypto/KDFSpi.java line 59:
>
>> 57: *
>> 58:
On Mon, 13 May 2024 16:30:54 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Mon, 13 May 2024 09:02:42 GMT, Alan Bateman wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> re-enable preview annotations
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 121:
>
>>
On Thu, 9 May 2024 15:18:43 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove (now) extraneous null-check
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 352:
>
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Fri, 10 May 2024 15:51:56 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line
>> 201:
>>
>>> 199: * the PRK (may be null)
>>> 200: * @param info
>>> 201: * the info (may be null)
>>
>> I know you use a null `prk` in `Ex
On Thu, 9 May 2024 15:17:17 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - method reuse
>> - null/boundary/modifiability checks
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSp
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with two additional
commits since th
On Thu, 9 May 2024 15:13:25 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> disallow null or empty values for ikm/salt rather than silent ignore
>
> src/java.base/share/classes/javax/crypto/spec/HK
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Fri, 10 May 2024 14:58:38 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line
>> 108:
>>
>>> 106: *
>>> 107: * @param ikm
>>> 108: * the ikm value (null values will not be added)
>>
>> Are you sure about allowin
On Thu, 9 May 2024 13:01:16 GMT, Sibabrata Sahoo wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code review comment re:returning null from derives
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDer
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Mon, 13 May 2024 15:23:59 GMT, Kevin Driver wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
>> line 148:
>>
>>> 146: }
>>> 147:
>>> 148: return null;
>>
>> Should it throw exception instead of null? Also it will never reach here.
>
> An
On Mon, 13 May 2024 13:55:48 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 50:
>>
>>> 48: * {@code KDF} objects are instantiated through the {@code getInstance}
>>> family
>>> 49: * of methods. Key derivation algorithm names follow a naming
>>> convention
On Mon, 13 May 2024 15:04:20 GMT, Sean Mullan wrote:
>> Do we need to mention "at the same time" because it's thread-safe?
>
> Yes, how about: "The `deriveKey` and `deriveData` methods of `KDF` objects
> must be thread-safe. That is, multiple threads may concurrently invoke these
> methods on a
On Mon, 13 May 2024 13:57:10 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 395:
>>
>>> 393: *
>>> 394: * The {@code deriveKey} method may be called multiple times once a
>>> 395: * {@code KDF} object is initialized.
>>
>> I think this sentence
On Fri, 10 May 2024 20:55:47 GMT, Kevin Driver wrote:
>> I agree. Also, if we do want to validate arguments (and I don't know if we
>> need to), then I think the `Extract` constructor should be responsible for
>> doing that, not the `Builder`. Doing it in `Extract` is safer since it is
>> done
On Sun, 12 May 2024 14:43:04 GMT, Sean Mullan wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> commenting out until better understood -- causing failures
>
> src/java.base/share/classes/javax/crypto/KDF.java line 39
On Mon, 13 May 2024 09:18:55 GMT, Alan Bateman wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> re-enable preview annotations
>
> src/java.base/share/classes/javax/crypto/KDF.java line 50:
>
>> 48: * {@code KDF} o
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Sun, 12 May 2024 18:13:37 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 398:
>>
>>> 396: *
>>> 397: * Delayed provider selection is also supported such that the
>>> provider
>>> 398: * performing the derive is not selected until the method
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Sun, 12 May 2024 14:39:40 GMT, Sean Mullan wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> commenting out until better understood -- causing failures
>
> src/java.base/share/classes/javax/crypto/KDF.java line 39
On Sat, 11 May 2024 02:06:09 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Sat, 11 May 2024 02:06:09 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Sat, 11 May 2024 02:06:09 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Fri, 10 May 2024 22:11:04 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with three additional
commits since
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Fri, 10 May 2024 14:54:18 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 70:
>>
>>> 68: */
>>> 69: public Extract extractOnly() {
>>> 70: if (this.ikms.isEmpty() && this.salts.isEmpty()) {
>>
>> I don't think
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 17:29:15 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/javax/crypto/KDFSpi.java line 107:
>>
>>> 105: * if the key derivation implementation cannot support
>>> additional calls to
>>> 106: * {@code deriveData } or if all {@code
>>> DerivationParame
On Thu, 9 May 2024 16:42:09 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> commits si
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 15:14:48 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> replace in-place SecretKeySpec alg for IKM/salt with "Generic"
>
> src/java.base/share/classes/javax/crypto/spec/HKDFPara
On Thu, 9 May 2024 15:01:24 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> a start on the preview wire on/off
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 47:
>
>
On Thu, 9 May 2024 14:43:55 GMT, Weijun Wang wrote:
> Two comments on HKDF:
>
> 1. Expand length cannot exceed 255 * HashLen. See
> https://datatracker.ietf.org/doc/html/rfc5869#section-2.3.
> 2. Why disallow empty ikms and salts? For the salt side, RFC5869 allows [no
> salt](https://datatrack
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 21:21:55 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> some code review comments
>
> src/java.base/share/classes/javax/crypto/KDF.java line 1:
>
>> 1: /*
>
> Delayed provider
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 20:33:57 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> some code review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 365:
>
On Wed, 8 May 2024 20:53:54 GMT, Kevin Driver wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
>> line 370:
>>
>>> 368: }
>>> 369: int rounds = (outLen + hmacLen - 1) / hmacLen;
>>> 370: kdfOutput = new byte[rounds * hmacLen];
>>
>> A
On Thu, 9 May 2024 12:31:24 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 54:
>>
>>> 52: * the algorithm specifier may be omitted if the KDF algorithm has a
>>> fixed or default PRF.
>>> 53: *
>>> 54: * TODO: finish this javadoc
>>
>> You should state th
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 15:30:22 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> continued code review comments
>
> src/java.base/share/classes/javax/crypto/KDF.java line 58:
>
>> 56:
>> 57: public fi
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Wed, 8 May 2024 20:25:36 GMT, Sean Mullan wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code review comment
>
> src/java.base/share/classes/java/security/Provider.java line 1607:
>
>> 1605: addEngine(
On Thu, 9 May 2024 14:10:37 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code review comment
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 36:
>
>> 34: * Parame
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 13:14:45 GMT, Sean Mullan wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> additional delayed provider selection work
>
> src/java.base/share/classes/javax/crypto/KDF.java line 147:
>
>> 145:
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 13:16:05 GMT, Sean Mullan wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code review comment
>
> src/java.base/share/classes/javax/crypto/KDF.java line 150:
>
>> 148: KDF instance = nul
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 13:07:41 GMT, Sean Mullan wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code review comment
>
> src/java.base/share/classes/javax/crypto/KDF.java line 132:
>
>> 130:
>> 131: private Strin
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Fri, 10 May 2024 14:56:55 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Thu, 9 May 2024 15:11:39 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change algorithm standard name for HKDFs in SunJCE provider
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParamet
On Fri, 10 May 2024 14:56:55 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Fri, 10 May 2024 00:15:32 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
On Thu, 9 May 2024 15:04:53 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change algorithm standard name for HKDFs in SunJCE provider
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParamet
On Wed, 8 May 2024 20:29:01 GMT, Sean Mullan wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change algorithm standard name for HKDFs in SunJCE provider
>
> src/java.base/share/classes/com/sun/crypto/provider/SunJC
On Fri, 10 May 2024 14:50:51 GMT, Kevin Driver wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java line 463:
>>
>>> 461: * Key Derivation engines
>>> 462: */
>>> 463: ps("KDF", "HKDF/HmacSHA256",
>>
>> In the JEP, the example uses "HkdfSHA256". Th
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 20:20:00 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
>> line 53:
>>
>>> 51: * and Expand-only variants.
>>> 52: */
>>> 53: abstract class HkdfKeyDerivation extends KDFSpi {
>>
>> How about just name it `HKDF`?
>
> M
On Fri, 10 May 2024 12:12:06 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java line 467:
>>
>>> 465: ps("KDF", "HkdfSHA384",
>>> 466:
>>> "com.sun.crypto.provider.HkdfKeyDerivation$HkdfSHA384");
>>> 467: ps("KDF", "HkdfSHA
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 20:18:10 GMT, Kevin Driver wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 115:
>>
>>> 113: * {@code getInstance} calls that created this {@code
>>> KeyDerivation} object.
>>> 114: *
>>> 115: * @return the algorithm name of this {@code KeyDeriv
On Fri, 10 May 2024 02:27:31 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adding in delayed provider selection
>
> src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java line 467:
>
>>
On Fri, 10 May 2024 00:15:32 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pu
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 19:46:39 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pul
On Thu, 9 May 2024 19:46:39 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pul
On Thu, 9 May 2024 20:31:30 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> some code review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 223:
>
On Thu, 9 May 2024 20:19:41 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> some code review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 53:
>
>
On Thu, 9 May 2024 19:46:39 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pul
On Thu, 9 May 2024 14:11:44 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> some code review comments
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 40:
>
>> 38: *
On Thu, 9 May 2024 12:22:14 GMT, Sean Mullan wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> some code review comments
>
> src/java.base/share/classes/javax/crypto/KDF.java line 43:
>
>> 41:
>> 42: /**
>> 43: *
On Thu, 9 May 2024 17:33:30 GMT, Sean Mullan wrote:
>> Kevin Driver has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> commits si
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 May 2024 16:19:36 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>
> Kevin Driver has updated the pul
1 - 100 of 124 matches
Mail list logo
