Re: RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication [v2]

2022-11-09 Thread Sean Mullan
On Wed, 9 Nov 2022 08:12:33 GMT, Matthias Baesken wrote: > Mark and Sean, thanks for the reviews ! Do I need another review ? Best > regards, Matthias No, you can integrate now. - PR: https://git.openjdk.org/jdk/pull/11016

Re: RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication [v2]

2022-11-09 Thread Matthias Baesken
On Tue, 8 Nov 2022 16:16:53 GMT, Matthias Baesken wrote: >> The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite >> a lot of code duplication. The test code can be simplified e.g. by using >> generics. Additionally the test failure output was improved and a test for >>

Re: RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication [v2]

2022-11-08 Thread Sean Mullan
On Tue, 8 Nov 2022 16:16:53 GMT, Matthias Baesken wrote: >> The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite >> a lot of code duplication. The test code can be simplified e.g. by using >> generics. Additionally the test failure output was improved and a test for >>

Re: RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication

2022-11-08 Thread Matthias Baesken
On Mon, 7 Nov 2022 12:49:21 GMT, Matthias Baesken wrote: > The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite > a lot of code duplication. The test code can be simplified e.g. by using > generics. Additionally the test failure output was improved and a test for > the

Re: RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication [v2]

2022-11-08 Thread Matthias Baesken
> The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite > a lot of code duplication. The test code can be simplified e.g. by using > generics. Additionally the test failure output was improved and a test for > the constructors of CertPathBuilderException was added. Matthi

Re: RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication

2022-11-08 Thread Sean Mullan
On Tue, 8 Nov 2022 15:15:38 GMT, Matthias Baesken wrote: >> test/jdk/java/security/Exceptions/ChainingConstructors.java line 208: >> >>> 206: throw new SecurityException("Test 17 failed"); >>> 207: } >>> 208: */ >> >> I don't know why this is commented out, but when I uncomm

Re: RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication

2022-11-08 Thread Matthias Baesken
On Tue, 8 Nov 2022 14:01:29 GMT, Sean Mullan wrote: >> The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite >> a lot of code duplication. The test code can be simplified e.g. by using >> generics. Additionally the test failure output was improved and a test for >> the c

Re: RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication

2022-11-08 Thread Sean Mullan
On Mon, 7 Nov 2022 12:49:21 GMT, Matthias Baesken wrote: > The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite > a lot of code duplication. The test code can be simplified e.g. by using > generics. Additionally the test failure output was improved and a test for > the

Re: RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication

2022-11-08 Thread Matthias Baesken
On Tue, 8 Nov 2022 13:37:30 GMT, Sean Mullan wrote: > Add a `noreg-self` label to the JBS issue since this is a fix to the test > itself. Also, I would classify this as an Enhancement, and not a Bug. Thanks, this all makes sense ! I adjusted the JBS issue. - PR: https://git.openjd

Re: RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication

2022-11-08 Thread Sean Mullan
On Mon, 7 Nov 2022 12:49:21 GMT, Matthias Baesken wrote: > The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite > a lot of code duplication. The test code can be simplified e.g. by using > generics. Additionally the test failure output was improved and a test for > the

Re: RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication

2022-11-07 Thread Mark Powers
On Mon, 7 Nov 2022 12:49:21 GMT, Matthias Baesken wrote: > The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite > a lot of code duplication. The test code can be simplified e.g. by using > generics. Additionally the test failure output was improved and a test for > the

RFR: JDK-8296406: ChainingConstructors jtreg test reduce code duplication

2022-11-07 Thread Matthias Baesken
The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite a lot of code duplication. The test code can be simplified e.g. by using generics. Additionally the test failure output was improved and a test for the constructors of CertPathBuilderException was added. -