RE: Bug in XSCryptCryptoBase64.cpp

2005-03-09 Thread David Landwehr
should right side be executed before left side of | operator. This line should be broken into: t = ((m_inputBuffer[i++] << 4) & 0x30); t |= (m_inputBuffer[i] >> 4); Best regards, Milan > -Original Message- > From: David Landwehr [mailto:[EMAIL PROTECTED] > Sent

Bug in XSCryptCryptoBase64.cpp

2005-03-08 Thread David Landwehr
Hi, The XSCryptCryptoBase64 has a bug in the base 64 encoding routine (encode). The problem is the following type of logic: t = ((m_inputBuffer[i++] << 4) & 0x30) | (m_inputBuffer[i] >> 4); Normally i will only be increment after the entire expression, so it is identical to: t = ((m_inputBuff