Re: Status of == vs equals() RESULTS

2010-08-25 Thread eric fu
I agree with your decision based on test. It will be risky and will have littele gain to use == for string comparison. Eric On Tue, Aug 24, 2010 at 2:11 PM, Chad La Joie wrote: > Okay, I'll prepare a patch for you by the end of the week. > > > On 8/24/10 2:23 PM, Colm O hEigeartaigh wrote: > >>

Re: Status of == vs equals() RESULTS

2010-08-13 Thread eric fu
Xerces C DOM parser wrapped as Java DOM. What I mean conventional equals() should be preferred though == might have small performance gain. Eric On Fri, Aug 13, 2010 at 10:50 AM, Chad La Joie wrote: > Which parser/DOM impl were you using? > > > On 8/13/10 1:33 PM, eric fu w

Re: Status of == vs equals() RESULTS

2010-08-13 Thread eric fu
I encountered a problem before(version 1.4) caused by apache java code which uses == for namespace comparison. In my own code, when adding DOM node to a document, I have to create namespace using string from Apache classes. That is, I cannot directly use "http://www.w3.org/2000/09/xmldsig#"; as nam

Re: Santuario infra changes

2010-08-10 Thread eric fu
Is there any history why xml security project is called Santuario. Did some search, closest one showing up is a Catholic Church. Most of time, when talking with each others, we use Apache XML security, nobody ever used "Santuario" as I know. Personally, I think the name does not contribute to any p

Re: JUnit test failures in a fresh checkout

2010-04-20 Thread eric fu
If I were to create a patch to fix this, what is the process, and is that worthwhile? On Wed, Mar 31, 2010 at 11:59 PM, eric fu wrote: > Hi, > > I checked out a latest copy for xml security Java from svn trunk(1.4.3). > But ant test showed a few failures and it took me quite some ti

JUnit test failures in a fresh checkout

2010-04-01 Thread eric fu
Hi, I checked out a latest copy for xml security Java from svn trunk(1.4.3). But ant test showed a few failures and it took me quite some time to figure them out. Here are a summary of issues I identified: 1. dependency on Sun JVM. javax.xml.crypto.test.KeySelectors use two internal classes: sun