[networking-discuss] Partial Code Review for TCP Signature Support (RFC 2385)

2008-07-28 Thread Dan McDonald
On Mon, Jul 28, 2008 at 06:43:49PM -0400, Girish Moodalbail wrote: > Since you are the author of RFC 2367, wanted to cross check the assignment > of value "1" > to *MD5* algorithm. > > #define SADB_AALG_MD5 1 > > The openbsd header file for instance has it defined to be > > #define SADB_AALG_MD5 2

[networking-discuss] Partial Code Review for TCP Signature Support (RFC 2385)

2008-07-28 Thread Girish Moodalbail
Thanks Dan for the review. Please see in-line. > usr/src/uts/common/net/pfkeyv2.h > Since you are the author of RFC 2367, wanted to cross check the assignment of value "1" to *MD5* algorithm. #define SADB_AALG_MD5 1 The openbsd header file for instance has it defined to be #define SADB_AALG_

Partial Code Review for TCP Signature Support (RFC 2385)

2008-07-28 Thread Dan McDonald
NOTE that two critical files (tcp.c, and the new tcp_sig.c) were not reviewed. I was mostly looking to see how the changes interact with the SPD and SADB paths of IPsec and its utilities. Sorry for not giving more time, Dan = (Cut up to and including here.) ==