[PATCH] mcstrans: fix typo in mcstransd.8 man page

2017-03-24 Thread Nikola Forró
Signed-off-by: Nikola Forró --- mcstrans/man/man8/mcstransd.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mcstrans/man/man8/mcstransd.8 b/mcstrans/man/man8/mcstransd.8 index c1dc483..64774a5 100644 --- a/mcstrans/man/man8/mcstransd.8 +++

Re: selinux: Delete an error message for a failed memory allocation in policydb_read()

2017-03-24 Thread SF Markus Elfring
>> Omit an extra message for a memory allocation failure in this function. >> >> Link: >> http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf >> Signed-off-by: Markus Elfring >> --- >> security/selinux/ss/policydb.c | 5

[PATCH] selinux: fix double free in selinux_parse_opts_str()

2017-03-24 Thread Tetsuo Handa
Combination of memory allocation failure injection and syzkaller fuzzer found a double free bug. -- BUG: Double free or freeing an invalid pointer Unexpected shadow byte: 0xFB CPU: 2 PID: 15269 Comm: syz-executor1 Not tainted 4.11.0-rc3+ #364 Hardware name: QEMU Standard PC (i440FX +

Re: [PATCH 00/46] SELinux: Fine-tuning for several function implementations

2017-03-24 Thread Paul Moore
On Sun, Jan 15, 2017 at 9:55 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 15:15:14 +0100 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring

Re: selinux: Move some assignments for the variable "rc" in policydb_read()

2017-03-24 Thread SF Markus Elfring
>> One local variable was set to an error code in some cases before >> a concrete error situation was detected. Thus move the corresponding >> assignments into if branches to indicate a software failure there. >> >> Signed-off-by: Markus Elfring >> --- >>

Re: [PATCH 22/46] selinux: Delete an unnecessary variable initialisation in range_read()

2017-03-24 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:22 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 20:40:12 +0100 > > The local variable "rt" will be set to an appropriate pointer a bit later. > Thus omit the explicit

Re: [PATCH 19/46] selinux: Return directly after a failed next_entry() in range_read()

2017-03-24 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:19 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 19:35:59 +0100 > > Return directly after a call of the function "next_entry" failed > at the beginning. > > Signed-off-by:

Re: [PATCH 20/46] selinux: Move four assignments for the variable "rc" in range_read()

2017-03-24 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:20 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 19:55:00 +0100 > > One local variable was set to an error code in four cases before > a concrete error situation was detected.

Re: [PATCH 15/46] selinux: One check and function call less in genfs_read() after error detection

2017-03-24 Thread Paul Moore
On Tue, Jan 17, 2017 at 12:53 PM, Casey Schaufler wrote: > On 1/17/2017 8:37 AM, SF Markus Elfring wrote: @@ -2015,7 +2015,7 @@ static int genfs_read(struct policydb *p, void *fp) newgenfs = kzalloc(sizeof(*newgenfs), GFP_KERNEL); if

Re: [PATCH 17/46] selinux: Delete an unnecessary variable assignment in filename_trans_read()

2017-03-24 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:17 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 19:02:42 +0100 > > The local variable "ft" was set to a null pointer despite of an > immediate reassignment. > Thus remove this

Re: [PATCH 14/46] selinux: One function call less in genfs_read() after null pointer detection

2017-03-24 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:14 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 17:43:47 +0100 > > Call the function "kfree" at the end only after it was determined > that the local variable "newgenfs"

Re: [PATCH 07/46] selinux: Delete unnecessary variable assignments in policydb_index()

2017-03-24 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:04 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 13:40:25 +0100 > > The local variable "rc" was reset with an error code up to five times > before a memory allocation failure

Re: [PATCH 06/46] selinux: Use kcalloc() in policydb_index()

2017-03-24 Thread Paul Moore
On Sun, Jan 15, 2017 at 10:03 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 13:08:59 +0100 > > Multiplications for the size determination of memory allocations > indicated that array data structures