Re: [PATCH] procattr.c: Use __BIONIC__ instead of __ANDROID__

2017-05-12 Thread William Roberts
On Fri, May 12, 2017 at 11:01 AM, Tom Cherry wrote: > On Fri, May 12, 2017 at 6:22 AM, Stephen Smalley > wrote: > > On Thu, 2017-05-11 at 16:50 -0700, Tom Cherry via Selinux wrote: > >> This check is not specific to Android devices. If libselinux were > >> used > >> with Bionic on a normal Linux

Re: [PATCH] procattr.c: Use __BIONIC__ instead of __ANDROID__

2017-05-12 Thread Tom Cherry via Selinux
On Fri, May 12, 2017 at 6:22 AM, Stephen Smalley wrote: > On Thu, 2017-05-11 at 16:50 -0700, Tom Cherry via Selinux wrote: >> This check is not specific to Android devices. If libselinux were >> used >> with Bionic on a normal Linux system this check would still be >> needed. >> >> Signed-off-by:

Re: [PATCH] procattr.c: Use __BIONIC__ instead of __ANDROID__

2017-05-12 Thread Stephen Smalley
On Thu, 2017-05-11 at 16:50 -0700, Tom Cherry via Selinux wrote: > This check is not specific to Android devices. If libselinux were > used > with Bionic on a normal Linux system this check would still be > needed. > > Signed-off-by: Tom Cherry Thanks, applied. This was actually switched from A

Re: [PATCH] procattr.c: Use __BIONIC__ instead of __ANDROID__

2017-05-12 Thread enh via Selinux
don't feel bad: the Android tree has the same problem --- even bionic itself didn't always get this right :-) we're spotting these now because we're actually trying to use bionic on non-Android Linux too. On Thu, May 11, 2017 at 5:18 PM, William Roberts wrote: > On Thursday, May 11, 2017, Tom Ch

Re: [PATCH] procattr.c: Use __BIONIC__ instead of __ANDROID__

2017-05-11 Thread William Roberts
On Thursday, May 11, 2017, Tom Cherry via Selinux wrote: > This check is not specific to Android devices. If libselinux were used > with Bionic on a normal Linux system this check would still be needed. > > Signed-off-by: Tom Cherry > > --- > libselinux/src/procattr.c | 4 ++-- > 1 file changed,

[PATCH] procattr.c: Use __BIONIC__ instead of __ANDROID__

2017-05-11 Thread Tom Cherry via Selinux
This check is not specific to Android devices. If libselinux were used with Bionic on a normal Linux system this check would still be needed. Signed-off-by: Tom Cherry --- libselinux/src/procattr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libselinux/src/procattr.c