Re: [PATCH] selinux: return -ENOMEM if kzalloc() fails

2017-07-05 Thread Paul Moore
On Fri, Jun 30, 2017 at 9:10 AM, Tetsuo Handa wrote: > Stephen Smalley wrote: >> On Fri, 2017-06-30 at 10:56 +0300, Dan Carpenter wrote: >> > We accidentally return success instead of -ENOMEM on this failure >> > path. >> > >> > Fixes: 409dcf31538a ("selinux:

Re: [PATCH] selinux: return -ENOMEM if kzalloc() fails

2017-06-30 Thread Tetsuo Handa
Stephen Smalley wrote: > On Fri, 2017-06-30 at 10:56 +0300, Dan Carpenter wrote: > > We accidentally return success instead of -ENOMEM on this failure > > path. > > > > Fixes: 409dcf31538a ("selinux: Add a cache for quicker retreival of > > PKey SIDs") > > Signed-off-by: Dan Carpenter

Re: [PATCH] selinux: return -ENOMEM if kzalloc() fails

2017-06-30 Thread Stephen Smalley
On Fri, 2017-06-30 at 10:56 +0300, Dan Carpenter wrote: > We accidentally return success instead of -ENOMEM on this failure > path. > > Fixes: 409dcf31538a ("selinux: Add a cache for quicker retreival of > PKey SIDs") > Signed-off-by: Dan Carpenter NAK, that's

[PATCH] selinux: return -ENOMEM if kzalloc() fails

2017-06-30 Thread Dan Carpenter
We accidentally return success instead of -ENOMEM on this failure path. Fixes: 409dcf31538a ("selinux: Add a cache for quicker retreival of PKey SIDs") Signed-off-by: Dan Carpenter diff --git a/security/selinux/ibpkey.c b/security/selinux/ibpkey.c index