Re: [RFC PATCH 1/3] selinux: refactor sidtab conversion

2018-11-21 Thread Ondrej Mosnacek
On Tue, Nov 20, 2018 at 10:47 PM Paul Moore wrote: > On Tue, Nov 13, 2018 at 8:53 AM Ondrej Mosnacek wrote: > > This is a purely cosmetic change that encapsulates the three-step sidtab > > conversion logic (shutdown -> clone -> map) into a single function > > defined in sidtab.c (as opposed to se

Re: [RFC PATCH 1/3] selinux: refactor sidtab conversion

2018-11-20 Thread Paul Moore
On Tue, Nov 13, 2018 at 8:53 AM Ondrej Mosnacek wrote: > This is a purely cosmetic change that encapsulates the three-step sidtab > conversion logic (shutdown -> clone -> map) into a single function > defined in sidtab.c (as opposed to services.c). > > Signed-off-by: Ondrej Mosnacek > --- > secu

Re: [RFC PATCH 1/3] selinux: refactor sidtab conversion

2018-11-13 Thread Stephen Smalley
On 11/13/18 8:52 AM, Ondrej Mosnacek wrote: This is a purely cosmetic change that encapsulates the three-step sidtab conversion logic (shutdown -> clone -> map) into a single function defined in sidtab.c (as opposed to services.c). Signed-off-by: Ondrej Mosnacek Acked-by: Stephen Smalley -

[RFC PATCH 1/3] selinux: refactor sidtab conversion

2018-11-13 Thread Ondrej Mosnacek
This is a purely cosmetic change that encapsulates the three-step sidtab conversion logic (shutdown -> clone -> map) into a single function defined in sidtab.c (as opposed to services.c). Signed-off-by: Ondrej Mosnacek --- security/selinux/ss/services.c | 22 +-- security/selinux/ss/