Re: Possible Bug for Oracle

2008-11-25 Thread Jeremy Evans
On Nov 25, 2:55 pm, "Wesley Moore" <[EMAIL PROTECTED]> wrote: > On Wed, Nov 26, 2008 at 4:55 AM, Jeremy Evans <[EMAIL PROTECTED]> wrote: > > Thanks, > > applied:http://github.com/jeremyevans/sequel/commit/0c7c893c5093337008f59de68... > > > Do the Oracle adapter specs run correctly?  Did you try r

Re: Possible Bug for Oracle

2008-11-25 Thread Wesley Moore
On Wed, Nov 26, 2008 at 4:55 AM, Jeremy Evans <[EMAIL PROTECTED]> wrote: > Thanks, applied: > http://github.com/jeremyevans/sequel/commit/0c7c893c5093337008f59de6885bd682cf8d327b > > Do the Oracle adapter specs run correctly? Did you try running the > integration tests with the Oracle adapter? >

Re: Possible Bug for Oracle

2008-11-25 Thread Jeremy Evans
On Nov 24, 3:08 pm, "Wesley Moore" <[EMAIL PROTECTED]> wrote: > Based on the documentation > here:http://download.oracle.com/docs/cd/B19306_01/server.102/b14200/statem... > > It would appear that the 'AS' keyword is optional in the places where > the patch would have an affect. > > I tested the p

Re: Possible Bug for Oracle

2008-11-24 Thread Wesley Moore
Based on the documentation here: http://download.oracle.com/docs/cd/B19306_01/server.102/b14200/statements_10002.htm#i2065646 It would appear that the 'AS' keyword is optional in the places where the patch would have an affect. I tested the patch against commit 8b395139f67ddcf7f24443cb6c1d7460e40

Re: Possible Bug for Oracle

2008-11-24 Thread Jeremy Evans
On Nov 23, 10:38 pm, "Wesley Moore" <[EMAIL PROTECTED]> wrote: > The code in question from dataset/sql.rb is shown below. > to_table_reference calls as_sql if an alias is supplied. The alias is > supplied by source_list when selecting from a Dataset. This generates > something like: ...FROM (sql)

Possible Bug for Oracle

2008-11-23 Thread Wesley Moore
Hi, I think I've encountered a bug when generating SQL for nested queries in Oracle. The problem is a combination of the as_sql method and the source_list method. I encountered the problem in 2.6.0, upgraded to 2.7.1 and found it still present, then checked Github and think its still present there