cvs commit: james-server/src/java/org/apache/james/pop3server POP3Handler.java

2003-07-15 Thread noel
noel2003/07/15 21:03:23 Modified:src/java/org/apache/james/pop3server POP3Handler.java Log: Change to use CRLFTerminatedReader. Follows same pattern that SMTPHandler has been using. Revision ChangesPath 1.31 +24 -4 james-server/src/java/org/apache/james/po

cvs commit: james-server/src/java/org/apache/james/pop3server POP3Handler.java

2003-07-15 Thread noel
noel2003/07/15 20:58:44 Modified:src/java/org/apache/james/pop3server Tag: branch_2_1_fcs POP3Handler.java Log: Change to use CRLFTerminatedReader. Follows same pattern that SMTPHandler has been using. Also some minor text changes to make spotting diffe

RE: new InputStream class for mail data

2003-07-15 Thread Noel J. Bergman
> Based upon my present understanding, I would not throw an exception > (and would not throw an exception in CRLFTerminatedReader either). I > would leave the lone CR in the stream, to be dealt with by whatever > code handles it next. Do as you will, but RFC 2821 4.3.2. says that you should rejec

Re: new InputStream class for mail data

2003-07-15 Thread Richard O. Hammer
Noel J. Bergman wrote: I disagree. An empty data set can be a valid message. I find support in RFC 2821 Section 4.1.1.4. Not RFC 2821. RFC 2822, section 3.6: The only required header fields are the origination date field and the originator address field(s). All other header fields are

RE: would matcher AttachmentFilenameIsRegex be of use

2003-07-15 Thread Virender Dogra
The attachment got removed so here is my cut and paste Hello Noel, Please find the attached regular expression matcher for attachments. I have named the file "AttachmentFileNameIsRegex.java" with "FileName" having "N" as caps like in "AttachmentFileNameIs.java" Location: src\java\org\apache\jam

Re: new InputStream class for mail data

2003-07-15 Thread Richard O. Hammer
Noel J. Bergman wrote: I agree with you that [RFC 2821, 2.3.7] seems to clearly prohibit SMTP clients from sending a lone CR character in message body data. Since I am working on server-side SMTP code, I suppose I should allow the possibility that a lone CR might come in. And what would you do wi

RE: Mailet API changes

2003-07-15 Thread Noel J. Bergman
> > I'm fine with reving the version to Mailet API v2.something or some other > > procedural change. That's similar to why we've proposed calling the next > > version 2.2.0, instead of 2.1.4. > I think this is the first revision to the mailet API (aside from v3 > changes) since its release many y

RE: new InputStream class for mail data

2003-07-15 Thread Noel J. Bergman
> I disagree. An empty data set can be a valid message. I find support > in RFC 2821 Section 4.1.1.4. Not RFC 2821. RFC 2822, section 3.6: The only required header fields are the origination date field and the originator address field(s). All other header fields are syntactically opt

Re: new InputStream class for mail data

2003-07-15 Thread Richard O. Hammer
Noel J. Bergman wrote: ... as both Valdis and Keith pointed out, [ in the thread starting at http://www.imc.org/ietf-smtp/mail-archive/msg00703.html ] an empty data set isn't a valid message. I disagree. An empty data set can be a valid message. I find support in RFC 2821 Section 4.1.1.4. The

RE: James Console Contribution

2003-07-15 Thread Noel J. Bergman
It looks interesting. Would you mind releasing it under the ASF License? Releasing it under the GPL makes it impossible for the Apache James project to ever make use of your code. --- Noel -Original Message- From: Rodríguez Miguélez, Adolfo [mailto:[EMAIL PROTECTED] Sent: Tuesday

RE: new InputStream class for mail data

2003-07-15 Thread Noel J. Bergman
Richard, The statement that "the character sequence . IS NOT a line containing only a period" is wrong. As you know from your own finite state machine, the required sequence in the stream is precisely CR-LF-.-CR-LF, which would be interpreted as CR need-lf LF newline .

RE: new InputStream class for mail data

2003-07-15 Thread Noel J. Bergman
> I agree with you that [RFC 2821, 2.3.7] seems to clearly prohibit > SMTP clients from sending a lone CR character in message body data. > Since I am working on server-side SMTP code, I suppose I should allow > the possibility that a lone CR might come in. And what would you do with it then? Th

RE: would matcher AttachmentFilenameIsRegex be of use

2003-07-15 Thread Virender Dogra
Hello Noel, Please find the attached regular expression matcher for attachments. I have named the file "AttachmentFileNameIsRegex.java" with "FileName" having "N" as caps like in "AttachmentFileNameIs.java" Location: src\java\org\apache\james\transport\matchers Please let me know if my submissi

Re: Mailet API changes

2003-07-15 Thread Serge Knystautas
Danny Angus wrote: Maybe the better solution is to put the mailet API on a separate release schedule, so it's clear that James 2.1.x implements mailet API 1.0 and James 2.2 implements mailet API 1.1. Absolutely, the sooner we get round to miving it into its own cvs module the happier I'll be. Thoug

RE: Mailet API changes

2003-07-15 Thread Danny Angus
> Maybe the better solution is to put the mailet API on a separate release > schedule, so it's clear that James 2.1.x implements mailet API 1.0 and > James 2.2 implements mailet API 1.1. Absolutely, the sooner we get round to miving it into its own cvs module the happier I'll be. Though as a guy w

RE: Mailet API changes

2003-07-15 Thread Danny Angus
> Amusingly, you replied to his commit message for the main branch, but that > doesn't change the thrust of your argument, since he also committed to the > v2 branch. :-) Doh! :-) > Is there is change that you would want to make to the proposed API, or are > you raising a procedural issue? I w

Re: Mailet API changes

2003-07-15 Thread Serge Knystautas
Noel J. Bergman wrote: Is there is change that you would want to make to the proposed API, or are you raising a procedural issue? I would like to see the functionality integrated. My notes below on the actual changes, but I think we need to discuss changes before committing them to the mailet API

Mailet API changes

2003-07-15 Thread Noel J. Bergman
Danny, Amusingly, you replied to his commit message for the main branch, but that doesn't change the thrust of your argument, since he also committed to the v2 branch. :-) Is there is change that you would want to make to the proposed API, or are you raising a procedural issue? I would like to

RE: cvs commit: james-server/src/java/org/apache/mailet Mail.java

2003-07-15 Thread Danny Angus
Vincenzo, I think you should remove this, it changes the Mailet API, the API should not change between versions in this way. It is important for published API's to remain static and for changes to be well publicised and stable before any release is made. Making a change in this way may not be dire

Mail Attributes support added

2003-07-15 Thread Vincenzo Gianferrari Pini
I just committed to james-head and james-branch_2_1_fcs Soeren Hilmer's great contribution that gives James "mail attribute" (or "message attribute") support. Such support is immediately available just by restarting the server if James uses file based repositories for inbox and spools, *even if

cvs commit: james-server/src/java/org/apache/james/transport/matchers HasMailAttribute.java

2003-07-15 Thread vincenzo
vincenzo2003/07/15 03:50:24 Added: src/java/org/apache/james/transport/mailets Tag: branch_2_1_fcs RemoveAllMailAttributes.java RemoveMailAttribute.java SetMailAttribute.java src/java/org/apache/james/transport/matchers Tag

cvs commit: james-server/src/java/org/apache/james/transport/matchers HasMailAttribute.java

2003-07-15 Thread vincenzo
vincenzo2003/07/15 03:44:49 Added: src/java/org/apache/james/transport/mailets RemoveAllMailAttributes.java RemoveMailAttribute.java SetMailAttribute.java src/java/org/apache/james/transport/matchers

cvs commit: james-server/src/java/org/apache/mailet Mail.java

2003-07-15 Thread vincenzo
vincenzo2003/07/15 03:12:45 Modified:src/conf Tag: branch_2_1_fcs sqlResources.xml src/java/org/apache/james/core Tag: branch_2_1_fcs MailImpl.java src/java/org/apache/james/mailrepository Tag: branch_2_1_fcs J

cvs commit: james-server/src/java/org/apache/mailet Mail.java

2003-07-15 Thread vincenzo
vincenzo2003/07/15 03:11:59 Modified:src/conf sqlResources.xml src/java/org/apache/james/core MailImpl.java src/java/org/apache/james/mailrepository JDBCMailRepository.java src/java/org/apache/mailet Mail.java Log:

James Console Contribution

2003-07-15 Thread "Rodríguez Miguélez, Adolfo"
Hi All, here is a basic Console for managing James Mail Server from my own. It is developed as GPL licence so you can feel free to use it any time. It is developed as an standalone Java app written in SWT. Current release is for a windows environments. Linux version will be shortly added. http