RE: Blocking defect for JAMES v2.3

2006-07-08 Thread Noel J. Bergman
Working on it ... looks like we corrupt the message body in AvalonMailRepository when we call sr.put(key). Side-effect of not loading the message into memory, I suspect. --- Noel - To unsubscribe, e-mail: [EMAIL PROTECT

RE: Blocking defect for JAMES v2.3

2006-07-08 Thread Noel J. Bergman
OK, here is a scenario to reproduce. In the root processor, add: LogMessage ToRepository (pre-header) SetMimeHeader LogMessage ToRepository (post-header) ToProcessor (test) Needless to say, all of the ToRepository mailets should have passThrough set. And in the "test" processor, add

svn commit: r420188 - /james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/LogMessage.java

2006-07-08 Thread noel
Author: noel Date: Sat Jul 8 13:41:31 2006 New Revision: 420188 URL: http://svn.apache.org/viewvc?rev=420188&view=rev Log: Copy a useful debugging mailet from trunk Added: james/server/branches/v2.3/src/java/org/apache/james/transport/mailets/LogMessage.java - copied unchanged from r4

Blocking defect for JAMES v2.3

2006-07-08 Thread Noel J. Bergman
Vincenzo has found what appears to be a blocker. He posted e-mail to Stefano and myself, the gist of which is: "A mailet [like ClamAVScan or SetMimeHeader] sets a header and issues a saveChanges(). Before and after such mailet the message is ok. But as soon it goes to *another processor* the mess

RE: svn commit: r420161 -/james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java

2006-07-08 Thread Noel J. Bergman
Norman Maurer wrote: > schrieb Noel J. Bergman: > > I rushed through this right now because Vincenzo is having problems > > with JAMES v2.3 > Whats the exact problem ? Any Logs config.xml etc ? See my e-mail regarding a blocking defect. --- Noel -

RE: svn commit: r420161 - /james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java

2006-07-08 Thread Norman Maurer
Am Samstag, den 08.07.2006, 12:31 -0400 schrieb Noel J. Bergman: > This is not really tested. I modified an existing test mailet of mine to do > more logging, and committed it as we had discussed at ApacheCon. I rushed > through this right now because Vincenzo is having problems with JAMES v2.3

RE: svn commit: r420100 - /james/server/trunk/src/java/org/apache/james/smtpserver/SpamAssassinHandler.java

2006-07-08 Thread Norman Maurer
Am Samstag, den 08.07.2006, 16:52 +0200 schrieb Norman Maurer: > Am Samstag, den 08.07.2006, 10:37 -0400 schrieb Noel J. Bergman: > > Several comments inline: > > > > > + // Not scan the message if relaying allowed > > > > Should that be configurable? > Yes it should like in other filters i wrote

svn commit: r420178 - /james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java

2006-07-08 Thread noel
Author: noel Date: Sat Jul 8 11:48:18 2006 New Revision: 420178 URL: http://svn.apache.org/viewvc?rev=420178&view=rev Log: Fix indentation again. Modified: james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java Modified: james/server/trunk/src/java/org/apache/james

svn commit: r420177 - /james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java

2006-07-08 Thread noel
Author: noel Date: Sat Jul 8 11:43:41 2006 New Revision: 420177 URL: http://svn.apache.org/viewvc?rev=420177&view=rev Log: Add an optional comment for the log. Modified: james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java Modified: james/server/trunk/src/java/or

Re: svn commit: r420100 - /james/server/trunk/src/java/org/apache/james/smtpserver/SpamAssassinHandler.java

2006-07-08 Thread Norman Maurer
Am Samstag, den 08.07.2006, 16:51 +0200 schrieb Stefano Bagnara: > Noel J. Bergman wrote: > >> + Iterator headers = sa.getHeaders().keySet().iterator(); > >> + // Add the headers > >> + while (headers.hasNext()) { > >> + String key = headers.next().toString(); > >> + message.setHeader(key, (Str

Re: Custom Mailets and JAMES v2.3

2006-07-08 Thread Stefano Bagnara
Noel J. Bergman wrote: Stefano Bagnara wrote: I can try to give some hints to some of the problems that could be caused by MimeMessageWrapper and the CopyOnWriteProxy. Is there something that we need to document generically for all of the users who do have custom mailets? --- Noel

Custom Mailets and JAMES v2.3

2006-07-08 Thread Noel J. Bergman
Stefano Bagnara wrote: > I can try to give some hints to some of the problems that could be > caused by MimeMessageWrapper and the CopyOnWriteProxy. Is there something that we need to document generically for all of the users who do have custom mailets? --- Noel -

Re: svn commit: r420161 - /james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java

2006-07-08 Thread Stefano Bagnara
Noel J. Bergman wrote: I rushed through this right now [...] Just committed a version that at least compiles. IM'ing Vincenzo as he works through debugging the server issues (again, he has no e-mail access). --- Noel Ask him informations on his configuration. If I know something mo

svn commit: r420167 - in /james/server/trunk/src/java/org/apache/james: mailrepository/ management/ nntpserver/ pop3server/ remotemanager/

2006-07-08 Thread berndf
Author: berndf Date: Sat Jul 8 09:56:27 2006 New Revision: 420167 URL: http://svn.apache.org/viewvc?rev=420167&view=rev Log: - add setters for service components (JAMES-494) (ongoing) - fix javadoc Modified: james/server/trunk/src/java/org/apache/james/mailrepository/AvalonMailRepository.ja

svn commit: r420166 - /james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java

2006-07-08 Thread noel
Author: noel Date: Sat Jul 8 09:50:47 2006 New Revision: 420166 URL: http://svn.apache.org/viewvc?rev=420166&view=rev Log: Just fix formatting. Modified: james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java Modified: james/server/trunk/src/java/org/apache/james/t

RE: svn commit: r420161 - /james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java

2006-07-08 Thread Noel J. Bergman
> I rushed through this right now [...] Just committed a version that at least compiles. IM'ing Vincenzo as he works through debugging the server issues (again, he has no e-mail access). --- Noel - To unsubscribe, e-m

svn commit: r420164 - /james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java

2006-07-08 Thread noel
Author: noel Date: Sat Jul 8 09:46:38 2006 New Revision: 420164 URL: http://svn.apache.org/viewvc?rev=420164&view=rev Log: Fix compile errors. Modified: james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java Modified: james/server/trunk/src/java/org/apache/james/tr

RE: svn commit: r420161 - /james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java

2006-07-08 Thread Noel J. Bergman
This is not really tested. I modified an existing test mailet of mine to do more logging, and committed it as we had discussed at ApacheCon. I rushed through this right now because Vincenzo is having problems with JAMES v2.3 on his production server, can't send mail at the moment, and should b

svn commit: r420162 - /james/server/trunk/src/java/org/apache/james/smtpserver/SpamAssassinHandler.java

2006-07-08 Thread norman
Author: norman Date: Sat Jul 8 09:27:48 2006 New Revision: 420162 URL: http://svn.apache.org/viewvc?rev=420162&view=rev Log: Fix a typo Modified: james/server/trunk/src/java/org/apache/james/smtpserver/SpamAssassinHandler.java Modified: james/server/trunk/src/java/org/apache/james/smtpser

svn commit: r420161 - /james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.java

2006-07-08 Thread noel
Author: noel Date: Sat Jul 8 09:26:24 2006 New Revision: 420161 URL: http://svn.apache.org/viewvc?rev=420161&view=rev Log: Initial version of a Mailet to log headers and/or messages for debugging purposes. Added: james/server/trunk/src/java/org/apache/james/transport/mailets/LogMessage.jav

svn commit: r420160 - in /james/server/trunk/src/java/org/apache/james: smtpserver/SpamAssassinHandler.java transport/mailets/SpamAssassin.java util/SpamAssassinInvoker.java

2006-07-08 Thread norman
Author: norman Date: Sat Jul 8 09:24:33 2006 New Revision: 420160 URL: http://svn.apache.org/viewvc?rev=420160&view=rev Log: Add more comments Add the headers as Attribute. So we can create a mailet which map attributes to headers Modified: james/server/trunk/src/java/org/apache/james/smtp

svn commit: r420125 - in /james/server/trunk/src/java/org/apache/james/transport: mailets/SpamAssassin.java matchers/SenderHostIsLocal.java

2006-07-08 Thread norman
Author: norman Date: Sat Jul 8 08:31:54 2006 New Revision: 420125 URL: http://svn.apache.org/viewvc?rev=420125&view=rev Log: Add matcher for which mach if senders domain is local Added: james/server/trunk/src/java/org/apache/james/transport/matchers/SenderHostIsLocal.java Modified: jam

Re: [jira] Created: (JAMES-558) MailImpl expose internal representation on getRecipients. This is a bad practice.

2006-07-08 Thread Norman Maurer
Am Samstag, den 08.07.2006, 14:07 + schrieb Stefano Bagnara (JIRA): > MailImpl expose internal representation on getRecipients. This is a bad > practice. > - > > Key: JAMES-558 > URL: http://issu

RE: [jira] Created: (JAMES-556) Allow to invert a matcher by using notmatch= in config.xml

2006-07-08 Thread Norman Maurer
Am Samstag, den 08.07.2006, 10:37 -0400 schrieb Noel J. Bergman: > Stefano Bagnara wrote: > > > It would also be good to default to 'match="All"' when either match > > and notmatch are missing. > > I'm mulling that over, but at the moment I am +1. > > --- Noel Allready done this in my com

RE: svn commit: r420100 - /james/server/trunk/src/java/org/apache/james/smtpserver/SpamAssassinHandler.java

2006-07-08 Thread Norman Maurer
Am Samstag, den 08.07.2006, 10:37 -0400 schrieb Noel J. Bergman: > Several comments inline: > > > + // Not scan the message if relaying allowed > > Should that be configurable? Yes it should like in other filters i wrote ;-) Just forgot this .. > > > + Iterator headers = sa.getHeaders().keySet(

Re: svn commit: r420100 - /james/server/trunk/src/java/org/apache/james/smtpserver/SpamAssassinHandler.java

2006-07-08 Thread Stefano Bagnara
Noel J. Bergman wrote: + Iterator headers = sa.getHeaders().keySet().iterator(); + // Add the headers + while (headers.hasNext()) { + String key = headers.next().toString(); + message.setHeader(key, (String) sa.getHeaders().get(key)); + } Do we want to add the header's now, or set attribute

RE: [jira] Created: (JAMES-556) Allow to invert a matcher by using notmatch= in config.xml

2006-07-08 Thread Noel J. Bergman
Stefano Bagnara wrote: > It would also be good to default to 'match="All"' when either match > and notmatch are missing. I'm mulling that over, but at the moment I am +1. --- Noel - To unsubscribe, e-mail: [EMAIL PROTE

RE: svn commit: r420100 - /james/server/trunk/src/java/org/apache/james/smtpserver/SpamAssassinHandler.java

2006-07-08 Thread Noel J. Bergman
Several comments inline: > + // Not scan the message if relaying allowed Should that be configurable? > + Iterator headers = sa.getHeaders().keySet().iterator(); > + // Add the headers > + while (headers.hasNext()) { > + String key = headers.next().toString(); > + message.setHeader(key, (Str

[jira] Updated: (JAMES-558) MailImpl expose internal representation on getRecipients. This is a bad practice.

2006-07-08 Thread Stefano Bagnara (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-558?page=all ] Stefano Bagnara updated JAMES-558: -- Component: Mailet API > MailImpl expose internal representation on getRecipients. This is a bad > practice. > --

[jira] Created: (JAMES-558) MailImpl expose internal representation on getRecipients. This is a bad practice.

2006-07-08 Thread Stefano Bagnara (JIRA)
MailImpl expose internal representation on getRecipients. This is a bad practice. - Key: JAMES-558 URL: http://issues.apache.org/jira/browse/JAMES-558 Project: James Type: Bug Compone

[jira] Resolved: (JAMES-556) Allow to invert a matcher by using notmatch= in config.xml

2006-07-08 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-556?page=all ] Norman Maurer resolved JAMES-556: - Resolution: Fixed > Allow to invert a matcher by using notmatch= in config.xml > -- > > K

Re: [jira] Created: (JAMES-556) Allow to invert a matcher by using notmatch= in config.xml

2006-07-08 Thread Stefano Bagnara
I always thought this was a simple and effecive thing to do. Never found the right moment to do that! It would also be good to default to 'match="All"' when either match and notmatch are missing. Stefano Norman Maurer (JIRA) wrote: Allow to invert a matcher by using notmatch= in config.xml

svn commit: r420110 - in /james/server/trunk/src/java/org/apache/james: transport/LinearProcessor.java util/MatcherInverter.java

2006-07-08 Thread norman
Author: norman Date: Sat Jul 8 06:59:52 2006 New Revision: 420110 URL: http://svn.apache.org/viewvc?rev=420110&view=rev Log: Allow to "invert" a matcher by config it with notmatch=matcher. See JAMES-556 Added: james/server/trunk/src/java/org/apache/james/util/MatcherInverter.java Modified:

svn commit: r420103 - /james/server/trunk/src/java/org/apache/james/smtpserver/SpamAssassinHandler.java

2006-07-08 Thread norman
Author: norman Date: Sat Jul 8 05:53:34 2006 New Revision: 420103 URL: http://svn.apache.org/viewvc?rev=420103&view=rev Log: Add more comments Modified: james/server/trunk/src/java/org/apache/james/smtpserver/SpamAssassinHandler.java Modified: james/server/trunk/src/java/org/apache/james/

[jira] Resolved: (JAMES-557) Add spamassassin MessageHandler to reject message on smtp level

2006-07-08 Thread Norman Maurer (JIRA)
[ http://issues.apache.org/jira/browse/JAMES-557?page=all ] Norman Maurer resolved JAMES-557: - Fix Version: 3.0 Resolution: Fixed > Add spamassassin MessageHandler to reject message on smtp level > --

svn commit: r420100 - /james/server/trunk/src/java/org/apache/james/smtpserver/SpamAssassinHandler.java

2006-07-08 Thread norman
Author: norman Date: Sat Jul 8 05:11:29 2006 New Revision: 420100 URL: http://svn.apache.org/viewvc?rev=420100&view=rev Log: Add spamassassin message handler. See JAMES-557 Added: james/server/trunk/src/java/org/apache/james/smtpserver/SpamAssassinHandler.java Added: james/server/trunk/sr

Re: IMAP Draft: Quota

2006-07-08 Thread Bernd Fondermann
Joachim Draeger wrote: Hi Bernd, Am Mittwoch, den 05.07.2006, 16:23 +0200 schrieb Bernd Fondermann: are you really making that good progress you are already discussing advanced features, or are quotas required by IMAP? Well, the progress is near to alpha for basic commands. What really is

Re: IMAP Draft: Cluster

2006-07-08 Thread Bernd Fondermann
Joachim Draeger wrote: Hi Ahmed, Am Donnerstag, den 06.07.2006, 10:47 +0200 schrieb Ahmed Mohombe: In a worst case, when nobody is ill or on holidays, you have at least one open connection per user all the time. How would one handle in the JVM and code these very long lasting connections?

Re: IMAP Draft: Cluster

2006-07-08 Thread Bernd Fondermann
Joachim Draeger wrote: Hi Bernd, Imap is quite resource intensive. Is it? Why? How does IMAP resource consumption compare to already existing James parts like POP3 and UserRepositories? The normal SMTP/POP life-cycle is 1. delivering a message 2. retrieve by pop3, store on users hard-dis

[jira] Created: (JAMES-557) Add spamassassin MessageHandler to reject message on smtp level

2006-07-08 Thread Norman Maurer (JIRA)
Add spamassassin MessageHandler to reject message on smtp level --- Key: JAMES-557 URL: http://issues.apache.org/jira/browse/JAMES-557 Project: James Type: New Feature Components: SMTPServer Reporte

svn commit: r420088 - in /james/server/trunk/src/java/org/apache/james: transport/mailets/SpamAssassin.java util/SpamAssassinInvoker.java

2006-07-08 Thread norman
Author: norman Date: Sat Jul 8 01:30:04 2006 New Revision: 420088 URL: http://svn.apache.org/viewvc?rev=420088&view=rev Log: Move headergeneration to util class Modified: james/server/trunk/src/java/org/apache/james/transport/mailets/SpamAssassin.java james/server/trunk/src/java/org/apa