[jira] Updated: (IMAP-217) Remove methods findMailboxById and deleteAll from MailboxMapper

2010-09-21 Thread Norman Maurer (JIRA)
[ https://issues.apache.org/jira/browse/IMAP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer updated IMAP-217: --- Issue Type: Improvement (was: Bug) > Remove methods findMailboxById and deleteAll from MailboxMapper

svn commit: r999551 - in /james/imap/trunk: jcr/src/main/java/org/apache/james/mailbox/jcr/mail/ jpa/src/main/java/org/apache/james/mailbox/jpa/ jpa/src/main/java/org/apache/james/mailbox/jpa/mail/ ma

2010-09-21 Thread norman
Author: norman Date: Tue Sep 21 19:14:53 2010 New Revision: 999551 URL: http://svn.apache.org/viewvc?rev=999551&view=rev Log: Remove methods findMailboxById and deleteAll from MailboxMapper as they methods are never used (IMAP-217). Thx to François-Denis Gonthier for spot it! Modified: jame

[jira] Resolved: (IMAP-217) Remove methods findMailboxById and deleteAll from MailboxMapper

2010-09-21 Thread Norman Maurer (JIRA)
[ https://issues.apache.org/jira/browse/IMAP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved IMAP-217. Assignee: Norman Maurer Fix Version/s: 0.2 Resolution: Fixed Removed.. Thx > Remove

Re: svn commit: r999491 - in /james: imap/trunk/file/ imap/trunk/jdbc/ imap/trunk/parent/ server/trunk/ server/trunk/core-function/ server/trunk/pop3server/ server/trunk/remotemanager/ server/trunk/sp

2010-09-21 Thread Norman Maurer
Hi, I think it would be hard to move them because you would need to duplicate the lifecycle stuff too. I would be more in favor to just move the classes / packages back to james-server. Bye, Norman 2010/9/21 Eric Charles : >  Hi Stephano, > > Yes, I saw it like a temporary situation evolving wi

[jira] Created: (IMAP-217) Remove methods findMailboxById and deleteAll from MailboxMapper

2010-09-21 Thread JIRA
Remove methods findMailboxById and deleteAll from MailboxMapper Key: IMAP-217 URL: https://issues.apache.org/jira/browse/IMAP-217 Project: JAMES Imap Issue Type: Bug

Re: svn commit: r999491 - in /james: imap/trunk/file/ imap/trunk/jdbc/ imap/trunk/parent/ server/trunk/ server/trunk/core-function/ server/trunk/pop3server/ server/trunk/remotemanager/ server/trunk/sp

2010-09-21 Thread Eric Charles
Hi Stephano, Yes, I saw it like a temporary situation evolving with 'mailrepository' (2.3) and 'mailbox' (3.0) grouped into a 'mailstore' umbrella, just like there are other umbrellas' ('server', 'imap',...). In any case, it was planned to create this umbrella for all 3.0 mailbox projects.

Re: svn commit: r999491 - in /james: imap/trunk/file/ imap/trunk/jdbc/ imap/trunk/parent/ server/trunk/ server/trunk/core-function/ server/trunk/pop3server/ server/trunk/remotemanager/ server/trunk/sp

2010-09-21 Thread Stefano Bagnara
I mostly agree with Norman. My main issue is with cross project dependency: if we split imap into "imap" and "mailstore" where imap uses mailstore but mailstore doesn't know anything about imap then I'm fine with james-server depending on the new "mailstore" product That said I saw in past you al

[jira] Commented: (IMAP-210) MailboxQuery ignore namespace

2010-09-21 Thread Norman Maurer (JIRA)
[ https://issues.apache.org/jira/browse/IMAP-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913113#action_12913113 ] Norman Maurer commented on IMAP-210: Hi, I had a look at the issue. Its really a pita to

svn commit: r999516 - in /james/imap/trunk: jdbc/pom.xml parent/pom.xml

2010-09-21 Thread eric
Author: eric Date: Tue Sep 21 17:40:52 2010 New Revision: 999516 URL: http://svn.apache.org/viewvc?rev=999516&view=rev Log: Add missing dependency and upgrade dbcp to align on server projects. Modified: james/imap/trunk/jdbc/pom.xml james/imap/trunk/parent/pom.xml Modified: james/imap/tr

Re: On the presence of deleteAll & findMailboxById in MailboxMapper

2010-09-21 Thread Norman Maurer
Hi there, I just reviewed the code and you are right.. We should remove both methods form the interface (KISS). Could you open a jira issue to track the task ? Thx, Norman 2010/9/21 Francois-Denis Gonthier : > Hello all, > > I just implemented the deleteAll method in my store, but, just after, c

Re: svn commit: r999491 - in /james: imap/trunk/file/ imap/trunk/jdbc/ imap/trunk/parent/ server/trunk/ server/trunk/core-function/ server/trunk/pop3server/ server/trunk/remotemanager/ server/trunk/sp

2010-09-21 Thread Norman Maurer
Hi Eric, I don't agree with you here.. IMHO the whole mailrepository stuff should not be in imap tree. It should be in JAMES Server (were it was before). I just think its plain wrong to have it in imap tree and it give us nothing more then cross-project dependencies (imap-trunk depends on james-se

Re: svn commit: r999491 - in /james: imap/trunk/file/ imap/trunk/jdbc/ imap/trunk/parent/ server/trunk/ server/trunk/core-function/ server/trunk/pop3server/ server/trunk/remotemanager/ server/trunk/sp

2010-09-21 Thread Eric Charles
Hi Norman, I introduced dependency to core-function if mailbox-file and mailbox-jdbc by error. It is now removed. However, mailbox (now in imap tree) dependency to core-api is there, and sounds logic. Tks, Eric On 21/09/2010 18:45, Norman Maurer wrote: Why does this touch the imap tree? B

svn commit: r999501 - /james/server/trunk/user-function/pom.xml

2010-09-21 Thread eric
Author: eric Date: Tue Sep 21 17:09:15 2010 New Revision: 999501 URL: http://svn.apache.org/viewvc?rev=999501&view=rev Log: mailbox-api needed for UsersFileRepository (IMAP-1048) Modified: james/server/trunk/user-function/pom.xml Modified: james/server/trunk/user-function/pom.xml URL: http:

On the presence of deleteAll & findMailboxById in MailboxMapper

2010-09-21 Thread Francois-Denis Gonthier
Hello all, I just implemented the deleteAll method in my store, but, just after, checked how it is called from James. Outside the Memory store type, only the JPA store really calls the deleteAll method but it is doing it through a method that inside the JPAMailboxManager, which means it is spec

Re: svn commit: r999491 - in /james: imap/trunk/file/ imap/trunk/jdbc/ imap/trunk/parent/ server/trunk/ server/trunk/core-function/ server/trunk/pop3server/ server/trunk/remotemanager/ server/trunk/sp

2010-09-21 Thread Norman Maurer
Why does this touch the imap tree? Bye Norman 2010/9/21, e...@apache.org : > Author: eric > Date: Tue Sep 21 16:37:09 2010 > New Revision: 999491 > > URL: http://svn.apache.org/viewvc?rev=999491&view=rev > Log: > Remove core-function project and its only remaining unused class > MailStoreSpoolRep

svn commit: r999491 - in /james: imap/trunk/file/ imap/trunk/jdbc/ imap/trunk/parent/ server/trunk/ server/trunk/core-function/ server/trunk/pop3server/ server/trunk/remotemanager/ server/trunk/spring

2010-09-21 Thread eric
Author: eric Date: Tue Sep 21 16:37:09 2010 New Revision: 999491 URL: http://svn.apache.org/viewvc?rev=999491&view=rev Log: Remove core-function project and its only remaining unused class MailStoreSpoolRepository. we spool via queue interface, and core could be limited to api and library btw (I

svn commit: r999486 - in /james: imap/trunk/mailbox/src/main/java/org/apache/james/services/ server/trunk/core-function/src/main/java/org/apache/james/mailrepository/ server/trunk/core-library/src/tes

2010-09-21 Thread eric
Author: eric Date: Tue Sep 21 16:25:35 2010 New Revision: 999486 URL: http://svn.apache.org/viewvc?rev=999486&view=rev Log: Normalize 2.3 mail store classes to mailrepository package, could be renamed or merge to mailbox package after (IMAP-1048) Removed: james/imap/trunk/mailbox/src/main/ja

svn commit: r999484 - in /james/imap/trunk: file/src/main/java/org/apache/james/mailrepository/ file/src/test/java/org/apache/james/mailrepository/ jcr/src/main/java/org/apache/james/mailrepository/ j

2010-09-21 Thread eric
Author: eric Date: Tue Sep 21 16:22:03 2010 New Revision: 999484 URL: http://svn.apache.org/viewvc?rev=999484&view=rev Log: Normalize 2.3 mail store classes to mailrepository package, could be renamed or merge to mailbox package after (IMAP-1048) Added: james/imap/trunk/mailbox/src/main/java

svn commit: r999481 - in /james: imap/trunk/file/src/main/java/org/apache/james/mailrepository/ imap/trunk/mailbox/src/main/java/org/apache/james/services/store/ imap/trunk/store/src/main/java/org/apa

2010-09-21 Thread eric
Author: eric Date: Tue Sep 21 16:09:09 2010 New Revision: 999481 URL: http://svn.apache.org/viewvc?rev=999481&view=rev Log: Rename Store to MailStore because it goes on Mail after all, except the UsersFileRepository, to be resolved (IMAP-1048) Added: james/imap/trunk/mailbox/src/main/java/o

svn commit: r999478 - in /james: imap/trunk/file/src/main/java/org/apache/james/mailrepository/ imap/trunk/jdbc/src/main/java/org/apache/james/mailrepository/ imap/trunk/mailbox/src/main/java/org/apac

2010-09-21 Thread eric
Author: eric Date: Tue Sep 21 16:04:23 2010 New Revision: 999478 URL: http://svn.apache.org/viewvc?rev=999478&view=rev Log: Finally move Store interface to mailbox-api and Repository interfaces to repository package (JAMES-1048) Added: james/imap/trunk/mailbox/src/main/java/org/apache/james/

svn commit: r999465 - in /james/imap/trunk: ./ api/ file/ file/src/ file/src/main/ file/src/main/java/ file/src/main/java/org/ file/src/main/java/org/apache/ file/src/main/java/org/apache/james/ file/

2010-09-21 Thread eric
Author: eric Date: Tue Sep 21 15:31:11 2010 New Revision: 999465 URL: http://svn.apache.org/viewvc?rev=999465&view=rev Log: Move 2.3 mail persistence classes to mail/spool projects (JAMES-1048) Added: james/imap/trunk/file/ (with props) james/imap/trunk/file/pom.xml james/imap/trunk

svn commit: r999322 - /james/server/trunk/spoolmanager/src/main/java/org/apache/james/transport/camel/CamelMailProcessorList.java

2010-09-21 Thread norman
Author: norman Date: Tue Sep 21 11:34:02 2010 New Revision: 999322 URL: http://svn.apache.org/viewvc?rev=999322&view=rev Log: ChildMailProcessor is now full implemented Modified: james/server/trunk/spoolmanager/src/main/java/org/apache/james/transport/camel/CamelMailProcessorList.java Modif

[jira] Commented: (JAMES-1048) Move 2.3 mail persistence classes to mail/spool projects

2010-09-21 Thread Eric Charles (JIRA)
[ https://issues.apache.org/jira/browse/JAMES-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912908#action_12912908 ] Eric Charles commented on JAMES-1048: - Move is done and compiles. However, it introduc

svn commit: r999290 - /james/protocols/trunk/

2010-09-21 Thread eric
Author: eric Date: Tue Sep 21 09:41:41 2010 New Revision: 999290 URL: http://svn.apache.org/viewvc?rev=999290&view=rev Log: Add svn:ignore. Modified: james/protocols/trunk/ (props changed) Propchange: james/protocols/trunk/ --