Re: Happy New Year !!!

2012-01-01 Thread Eric Charles
Health, Happiness and good code to all for 2012 :) Eric On 31/12/11 20:36, Wojciech Strzałka wrote: Wojciech Strzałka - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server

[jira] [Created] (PROTOCOLS-79) Remove DNSService interface

2012-01-01 Thread Norman Maurer (Created) (JIRA)
Remove DNSService interface --- Key: PROTOCOLS-79 URL: https://issues.apache.org/jira/browse/PROTOCOLS-79 Project: JAMES Protocols Issue Type: Task Components: smtp Affects Versions: 1.6.0-RC1

svn commit: r1226220 - in /james/protocols/trunk/smtp/src: main/java/org/apache/james/protocols/smtp/ main/java/org/apache/james/protocols/smtp/core/fastfail/ test/java/org/apache/james/protocols/smtp

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 09:16:19 2012 New Revision: 1226220 URL: http://svn.apache.org/viewvc?rev=1226220&view=rev Log: Remove DNSService interface. See PROTOCOLS-79 Removed: james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/DNSService.java james/protocols

[jira] [Resolved] (PROTOCOLS-79) Remove DNSService interface

2012-01-01 Thread Norman Maurer (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/PROTOCOLS-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved PROTOCOLS-79. Resolution: Fixed > Remove DNSService interface > --- > >

Re: Logging library in our projects

2012-01-01 Thread Eric Charles
On 31/12/11 17:47, Stefano Bagnara wrote: 2011/12/31 Eric Charles: A Logger is a logger. I agree, but then I would say that most times we abuse "loggers" :-) sometimes we abuse, and often we are quite happy to have them. How many times don't we ask our users to raise the debug level from i

Re: Logging library in our projects

2012-01-01 Thread Eric Charles
Hi Stefano, I agree with your arguments as with mine :) I think there is not only one valid answer to this. If there was one, everybody would do that way. Eric On 31/12/11 16:32, Stefano Bagnara wrote: 2011/12/31 Eric Charles: Hi, As said, I am more in favor of uniformisation across projec

[jira] [Created] (PROTOCOLS-80) Remove HandlersPackage interface

2012-01-01 Thread Norman Maurer (Created) (JIRA)
Remove HandlersPackage interface Key: PROTOCOLS-80 URL: https://issues.apache.org/jira/browse/PROTOCOLS-80 Project: JAMES Protocols Issue Type: Task Components: api Affects Versions: 1.6.0-RC1

svn commit: r1226233 - /james/protocols/trunk/smtp/src/test/java/org/apache/james/protocols/smtp/MockLogger.java

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 11:14:00 2012 New Revision: 1226233 URL: http://svn.apache.org/viewvc?rev=1226233&view=rev Log: Just some cleanup Modified: james/protocols/trunk/smtp/src/test/java/org/apache/james/protocols/smtp/MockLogger.java Modified: james/protocols/trunk/smtp/src/test

svn commit: r1226238 - in /james/protocols/trunk: api/src/main/java/org/apache/james/protocols/api/handler/ pop3/src/main/java/org/apache/james/protocols/pop3/ pop3/src/main/java/org/apache/james/prot

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 11:55:49 2012 New Revision: 1226238 URL: http://svn.apache.org/viewvc?rev=1226238&view=rev Log: Remove HandlersPackage. See PROTOCOLS-80 Added: james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java (with prop

[jira] [Resolved] (PROTOCOLS-80) Remove HandlersPackage interface

2012-01-01 Thread Norman Maurer (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/PROTOCOLS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved PROTOCOLS-80. Resolution: Fixed done > Remove HandlersPackage interface >

[jira] [Created] (PROTOCOLS-81) Add Logger adapter for Slf4j

2012-01-01 Thread Norman Maurer (Created) (JIRA)
Add Logger adapter for Slf4j - Key: PROTOCOLS-81 URL: https://issues.apache.org/jira/browse/PROTOCOLS-81 Project: JAMES Protocols Issue Type: Task Components: api Affects Versions: 1.6.0-RC1

svn commit: r1226241 - in /james/protocols/trunk: ./ api/ api/src/main/java/org/apache/james/protocols/api/ api/src/main/java/org/apache/james/protocols/api/logger/ pop3/src/main/java/org/apache/james

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 12:10:26 2012 New Revision: 1226241 URL: http://svn.apache.org/viewvc?rev=1226241&view=rev Log: Add Logger adapter for slf4j. See PROTOCOLS-81 Added: james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/logger/ james/protocols/trunk/api/

[jira] [Resolved] (PROTOCOLS-81) Add Logger adapter for Slf4j

2012-01-01 Thread Norman Maurer (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/PROTOCOLS-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved PROTOCOLS-81. Resolution: Fixed done > Add Logger adapter for Slf4j > ---

svn commit: r1226242 - in /james/protocols/trunk: api/src/main/java/org/apache/james/protocols/api/ api/src/main/java/org/apache/james/protocols/api/future/ api/src/main/java/org/apache/james/protocol

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 12:12:30 2012 New Revision: 1226242 URL: http://svn.apache.org/viewvc?rev=1226242&view=rev Log: Move future classes to extra package Added: james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/future/ james/protocols/trunk/api/src/main/j

[jira] [Created] (PROTOCOLS-82) Remove ProtocolHandlerLoader and ProtocolHandlerConfiguration

2012-01-01 Thread Norman Maurer (Created) (JIRA)
Remove ProtocolHandlerLoader and ProtocolHandlerConfiguration - Key: PROTOCOLS-82 URL: https://issues.apache.org/jira/browse/PROTOCOLS-82 Project: JAMES Protocols Issue Type: Task

[jira] [Created] (PROTOCOLS-83) Remove ProtocolHandlerLoader and ProtocolHandlerConfiguration

2012-01-01 Thread Norman Maurer (Created) (JIRA)
Remove ProtocolHandlerLoader and ProtocolHandlerConfiguration - Key: PROTOCOLS-83 URL: https://issues.apache.org/jira/browse/PROTOCOLS-83 Project: JAMES Protocols Issue Type: Task

svn commit: r1226243 - in /james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/handler: LifecycleAwareProtocolHandler.java ProtocolHandlerConfiguration.java ProtocolHandlerConfigura

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 12:15:55 2012 New Revision: 1226243 URL: http://svn.apache.org/viewvc?rev=1226243&view=rev Log: Remove ProtocolHandlerLoader and ProtocolHandlerConfiguration. See PROTOCOLS-83 Removed: james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/hand

[jira] [Resolved] (PROTOCOLS-83) Remove ProtocolHandlerLoader and ProtocolHandlerConfiguration

2012-01-01 Thread Norman Maurer (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/PROTOCOLS-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved PROTOCOLS-83. Resolution: Fixed done > Remove ProtocolHandlerLoader and ProtocolHandle

svn commit: r1226244 - in /james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api: ProtocolSession.java ProtocolSessionImpl.java handler/CommandDispatcher.java

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 12:21:48 2012 New Revision: 1226244 URL: http://svn.apache.org/viewvc?rev=1226244&view=rev Log: Add getCharset() and getLineDelimiters() to ProtocolSession. See PROTOCOLS-78 Modified: james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/Proto

Re: Happy New Year !!!

2012-01-01 Thread Saibabu Vallurupalli
Thank you Eric. Wish you the same. On Jan 1, 2012 3:41 AM, "Eric Charles" wrote: > Health, Happiness and good code to all for 2012 :) > Eric > > On 31/12/11 20:36, Wojciech Strzałka wrote: > >> >> Wojciech Strzałka >> >> >> --**--**---

svn commit: r1226256 - in /james/protocols/trunk/smtp/src: main/java/org/apache/james/protocols/smtp/core/ main/java/org/apache/james/protocols/smtp/core/esmtp/ test/java/org/apache/james/protocols/sm

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 15:28:26 2012 New Revision: 1226256 URL: http://svn.apache.org/viewvc?rev=1226256&view=rev Log: Add getCharset() and getLineDelimiters() to ProtocolSession. See PROTOCOLS-78 Modified: james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/cor

[jira] [Resolved] (PROTOCOLS-78) Add getCharset() and getLineDelimiters() to ProtocolSession

2012-01-01 Thread Norman Maurer (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/PROTOCOLS-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved PROTOCOLS-78. Resolution: Fixed done > Add getCharset() and getLineDelimiters() to Pro

svn commit: r1226258 - /james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/handler/LineHandler.java

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 15:31:31 2012 New Revision: 1226258 URL: http://svn.apache.org/viewvc?rev=1226258&view=rev Log: Add getCharset() and getLineDelimiters() to ProtocolSession. See PROTOCOLS-78 Modified: james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/handl

svn commit: r1226259 - in /james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3: POP3ProtocolHandlerChain.java core/PassCmdHandler.java

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 15:38:43 2012 New Revision: 1226259 URL: http://svn.apache.org/viewvc?rev=1226259&view=rev Log: Use constructor argument to give MailboxFactory to PassCmdHandler Modified: james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHan

svn commit: r1226260 - in /james/protocols/trunk/pop3: pom.xml src/test/java/org/apache/james/protocols/pop3/POP3ServerTest.java src/test/java/org/apache/james/protocols/pop3/TestUtils.java

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 16:13:29 2012 New Revision: 1226260 URL: http://svn.apache.org/viewvc?rev=1226260&view=rev Log: Start to add unit tests for pop3. See PROTOCOLS-65 Added: james/protocols/trunk/pop3/src/test/java/org/apache/james/protocols/pop3/POP3ServerTest.java (with prop

svn commit: r1226261 - in /james/protocols/trunk/pop3/src: main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java test/java/org/apache/james/protocols/pop3/MockLogger.java test/java/o

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 16:16:56 2012 New Revision: 1226261 URL: http://svn.apache.org/viewvc?rev=1226261&view=rev Log: Correctly wire handlers in pop3 and also some minor work on tests. Added: james/protocols/trunk/pop3/src/test/java/org/apache/james/protocols/pop3/MockLogger.java

svn commit: r1226298 - /james/protocols/trunk/pop3/src/test/java/org/apache/james/protocols/pop3/POP3ServerTest.java

2012-01-01 Thread norman
Author: norman Date: Sun Jan 1 20:44:13 2012 New Revision: 1226298 URL: http://svn.apache.org/viewvc?rev=1226298&view=rev Log: Start to add unit tests for pop3. See PROTOCOLS-65 Modified: james/protocols/trunk/pop3/src/test/java/org/apache/james/protocols/pop3/POP3ServerTest.java Modified:

Re: Logging library in our projects

2012-01-01 Thread Stefano Bagnara
2012/1/1 Eric Charles : > "Better Java Development with AspectJ" (I think the ppt is no more online) > from PARC clearly points the logging as a perfect candidate to aspect > programming. I saw logging always as a case in AOP books, but I never really saw a real project using AOP for logging, so I

Re: Logging library in our projects

2012-01-01 Thread Stefano Bagnara
2012/1/1 Eric Charles : > Hi Stefano, > > I agree with your arguments as with mine :) > I think there is not only one valid answer to this. So True! > If there was one, everybody would do that way. Not so sure about this ;-) Stefano -

Re: Logging library in our projects

2012-01-01 Thread Eric Charles
Thx for the discussion Stefano. (see my comments in line). As Norman, I will look to the Monitor usage in mime4j and we could try to go that way with a Slf4jLoggerAdapter provided in protocols-api (btw, this will have as consequence to re-add the dependency to slf4j in protocols-api's pom).