Health, Happiness and good code to all for 2012 :)
Eric
On 31/12/11 20:36, Wojciech Strzałka wrote:
Wojciech Strzałka
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server
Remove DNSService interface
---
Key: PROTOCOLS-79
URL: https://issues.apache.org/jira/browse/PROTOCOLS-79
Project: JAMES Protocols
Issue Type: Task
Components: smtp
Affects Versions: 1.6.0-RC1
Author: norman
Date: Sun Jan 1 09:16:19 2012
New Revision: 1226220
URL: http://svn.apache.org/viewvc?rev=1226220&view=rev
Log:
Remove DNSService interface. See PROTOCOLS-79
Removed:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/DNSService.java
james/protocols
[
https://issues.apache.org/jira/browse/PROTOCOLS-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norman Maurer resolved PROTOCOLS-79.
Resolution: Fixed
> Remove DNSService interface
> ---
>
>
On 31/12/11 17:47, Stefano Bagnara wrote:
2011/12/31 Eric Charles:
A Logger is a logger.
I agree, but then I would say that most times we abuse "loggers" :-)
sometimes we abuse, and often we are quite happy to have them.
How many times don't we ask our users to raise the debug level from i
Hi Stefano,
I agree with your arguments as with mine :)
I think there is not only one valid answer to this. If there was one,
everybody would do that way.
Eric
On 31/12/11 16:32, Stefano Bagnara wrote:
2011/12/31 Eric Charles:
Hi,
As said, I am more in favor of uniformisation across projec
Remove HandlersPackage interface
Key: PROTOCOLS-80
URL: https://issues.apache.org/jira/browse/PROTOCOLS-80
Project: JAMES Protocols
Issue Type: Task
Components: api
Affects Versions: 1.6.0-RC1
Author: norman
Date: Sun Jan 1 11:14:00 2012
New Revision: 1226233
URL: http://svn.apache.org/viewvc?rev=1226233&view=rev
Log:
Just some cleanup
Modified:
james/protocols/trunk/smtp/src/test/java/org/apache/james/protocols/smtp/MockLogger.java
Modified:
james/protocols/trunk/smtp/src/test
Author: norman
Date: Sun Jan 1 11:55:49 2012
New Revision: 1226238
URL: http://svn.apache.org/viewvc?rev=1226238&view=rev
Log:
Remove HandlersPackage. See PROTOCOLS-80
Added:
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java
(with prop
[
https://issues.apache.org/jira/browse/PROTOCOLS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norman Maurer resolved PROTOCOLS-80.
Resolution: Fixed
done
> Remove HandlersPackage interface
>
Add Logger adapter for Slf4j
-
Key: PROTOCOLS-81
URL: https://issues.apache.org/jira/browse/PROTOCOLS-81
Project: JAMES Protocols
Issue Type: Task
Components: api
Affects Versions: 1.6.0-RC1
Author: norman
Date: Sun Jan 1 12:10:26 2012
New Revision: 1226241
URL: http://svn.apache.org/viewvc?rev=1226241&view=rev
Log:
Add Logger adapter for slf4j. See PROTOCOLS-81
Added:
james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/logger/
james/protocols/trunk/api/
[
https://issues.apache.org/jira/browse/PROTOCOLS-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norman Maurer resolved PROTOCOLS-81.
Resolution: Fixed
done
> Add Logger adapter for Slf4j
> ---
Author: norman
Date: Sun Jan 1 12:12:30 2012
New Revision: 1226242
URL: http://svn.apache.org/viewvc?rev=1226242&view=rev
Log:
Move future classes to extra package
Added:
james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/future/
james/protocols/trunk/api/src/main/j
Remove ProtocolHandlerLoader and ProtocolHandlerConfiguration
-
Key: PROTOCOLS-82
URL: https://issues.apache.org/jira/browse/PROTOCOLS-82
Project: JAMES Protocols
Issue Type: Task
Remove ProtocolHandlerLoader and ProtocolHandlerConfiguration
-
Key: PROTOCOLS-83
URL: https://issues.apache.org/jira/browse/PROTOCOLS-83
Project: JAMES Protocols
Issue Type: Task
Author: norman
Date: Sun Jan 1 12:15:55 2012
New Revision: 1226243
URL: http://svn.apache.org/viewvc?rev=1226243&view=rev
Log:
Remove ProtocolHandlerLoader and ProtocolHandlerConfiguration. See PROTOCOLS-83
Removed:
james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/hand
[
https://issues.apache.org/jira/browse/PROTOCOLS-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norman Maurer resolved PROTOCOLS-83.
Resolution: Fixed
done
> Remove ProtocolHandlerLoader and ProtocolHandle
Author: norman
Date: Sun Jan 1 12:21:48 2012
New Revision: 1226244
URL: http://svn.apache.org/viewvc?rev=1226244&view=rev
Log:
Add getCharset() and getLineDelimiters() to ProtocolSession. See PROTOCOLS-78
Modified:
james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/Proto
Thank you Eric. Wish you the same.
On Jan 1, 2012 3:41 AM, "Eric Charles" wrote:
> Health, Happiness and good code to all for 2012 :)
> Eric
>
> On 31/12/11 20:36, Wojciech Strzałka wrote:
>
>>
>> Wojciech Strzałka
>>
>>
>> --**--**---
Author: norman
Date: Sun Jan 1 15:28:26 2012
New Revision: 1226256
URL: http://svn.apache.org/viewvc?rev=1226256&view=rev
Log:
Add getCharset() and getLineDelimiters() to ProtocolSession. See PROTOCOLS-78
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/cor
[
https://issues.apache.org/jira/browse/PROTOCOLS-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norman Maurer resolved PROTOCOLS-78.
Resolution: Fixed
done
> Add getCharset() and getLineDelimiters() to Pro
Author: norman
Date: Sun Jan 1 15:31:31 2012
New Revision: 1226258
URL: http://svn.apache.org/viewvc?rev=1226258&view=rev
Log:
Add getCharset() and getLineDelimiters() to ProtocolSession. See PROTOCOLS-78
Modified:
james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/handl
Author: norman
Date: Sun Jan 1 15:38:43 2012
New Revision: 1226259
URL: http://svn.apache.org/viewvc?rev=1226259&view=rev
Log:
Use constructor argument to give MailboxFactory to PassCmdHandler
Modified:
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHan
Author: norman
Date: Sun Jan 1 16:13:29 2012
New Revision: 1226260
URL: http://svn.apache.org/viewvc?rev=1226260&view=rev
Log:
Start to add unit tests for pop3. See PROTOCOLS-65
Added:
james/protocols/trunk/pop3/src/test/java/org/apache/james/protocols/pop3/POP3ServerTest.java
(with prop
Author: norman
Date: Sun Jan 1 16:16:56 2012
New Revision: 1226261
URL: http://svn.apache.org/viewvc?rev=1226261&view=rev
Log:
Correctly wire handlers in pop3 and also some minor work on tests.
Added:
james/protocols/trunk/pop3/src/test/java/org/apache/james/protocols/pop3/MockLogger.java
Author: norman
Date: Sun Jan 1 20:44:13 2012
New Revision: 1226298
URL: http://svn.apache.org/viewvc?rev=1226298&view=rev
Log:
Start to add unit tests for pop3. See PROTOCOLS-65
Modified:
james/protocols/trunk/pop3/src/test/java/org/apache/james/protocols/pop3/POP3ServerTest.java
Modified:
2012/1/1 Eric Charles :
> "Better Java Development with AspectJ" (I think the ppt is no more online)
> from PARC clearly points the logging as a perfect candidate to aspect
> programming.
I saw logging always as a case in AOP books, but I never really saw a
real project using AOP for logging, so I
2012/1/1 Eric Charles :
> Hi Stefano,
>
> I agree with your arguments as with mine :)
> I think there is not only one valid answer to this.
So True!
> If there was one, everybody would do that way.
Not so sure about this ;-)
Stefano
-
Thx for the discussion Stefano.
(see my comments in line).
As Norman, I will look to the Monitor usage in mime4j and we could try
to go that way with a Slf4jLoggerAdapter provided in protocols-api (btw,
this will have as consequence to re-add the dependency to slf4j in
protocols-api's pom).
30 matches
Mail list logo