This is an automated email from the ASF dual-hosted git repository. btellier pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git.
from 2877c47 Merge remote-tracking branch 'mine/one-fix-per-day-4' new e48fb81 [Refactoring] Strong type for IMAP Tag new bb31c76 [Refactoring] StatusProcessor: Avoid variable reallocation new 141faa5 [Refactoring] StatusProcessor: Avoid final variables new 6cc7b18 [Refactoring] StatusProcessor: Remove never thrown exceptions new 80a34d3 [Refactoring] StatusProcessor: Extract FetchGroup computation new 1e8480b [Refactoring] StatusProcessor: Extract response computation new f07f878 [Refactoring] StatusProcessor: Inline MailboxManager new db0248d [Refactoring] StatusProcessor: Extract metadata retrieval new 105edc9 [Refactoring] StatusCommandParser: statusDataItems can be private new 9c0287f [Refactoring] StatusDataItems should be immutable new 798f24b [Refactoring] StatusCommandParser should not use final variable new 4bbc170 [Refactoring] StatusCommandParser: uncorrelate word splitting from item parsing new ac7e71f [Refactoring] StatusCommandParser: reorder methods by visibility new 70696f7 [Refactoring] StatusCommandParser: char validator can be a constant new c01dabc MAILBOX-391 Simplify some quota related code new 8531c0a MAILBOX-391 MailboxQuery constructor is actually private new 623bdb9 MAILBOX-391 DefaultMailboxBackup omitted namespace when querying user mailboxes new 3376061 Remove pseudo-support for shared mailboxes (mailboxes with null user) new 86044a3 MAILBOX-391 MailboxMapper::findMailboxWithPathLike should use MailboxQuery.UserBound new 42769f5 MAILBOX-391 MailboxQuery should implement Equals & HashCode new 09a02ce MAILBOX-391 MailboxMapper::findMailboxWithPathLike should be also queried for child mailboxes new 9a0ae79 [Refactoring] Allow a mailboxQuery to fluently match mailboxes new 83f4e82 [REFACTORING] Search comparators should rely on Java 8 new a858a96 [REFACTORING] JPA should not depend on search comparators new f9850ee [REFACTORING] StandardMailboxMetaDataComparator should rely on Java 8 new 60242ff [REFACTORING] MXRecordComparator should rely on Java 8 new 0794c5b [Refactoring] Use a default method for MailboxMessage::compareTo new 3d386b7 [Refactoring] Move test classes in James Core to JUnit 5 new 47ed141 [Refactoring] JAMES-2950 Move UsernameTest to JUnit 5 new 61cbd46 [Refactoring] Parameterized MailAddress creation tests new 49be939 [Refactoring] Remove useless test in MailAddressTest new 52bf917 [Refactoring] Simplify MailAddressTest by fully using the power of assertj The 32 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: core/pom.xml | 5 + .../org/apache/james/core/MailAddressTest.java | 252 ++++++++------------- .../java/org/apache/james/core/UsernameTest.java | 73 +++--- .../james/core/builder/MimeMessageBuilderTest.java | 15 +- .../james/core/builder/MimeMessageWrapperTest.java | 10 +- .../james/core/healthcheck/ResultStatusTest.java | 10 +- .../apache/james/core/quota/QuotaCountTest.java | 2 +- .../org/apache/james/core/quota/QuotaSizeTest.java | 2 +- .../mailbox/StandardMailboxMetaDataComparator.java | 66 ------ .../james/mailbox/model/MailboxMetaData.java | 9 +- .../apache/james/mailbox/model/MailboxPath.java | 3 +- .../james/mailbox/model/search/ExactName.java | 22 ++ .../model/search/MailboxNameExpression.java | 2 + .../james/mailbox/model/search/MailboxQuery.java | 53 ++++- .../james/mailbox/model/search/PrefixedRegex.java | 23 ++ .../mailbox/model/search/PrefixedWildcard.java | 22 ++ .../james/mailbox/model/search/Wildcard.java | 5 + .../james/mailbox/quota/QuotaRootResolver.java | 3 +- .../james/mailbox/model/search/ExactNameTest.java | 9 +- .../mailbox/model/search/MailboxQueryTest.java | 50 +--- .../mailbox/model/search/PrefixedRegexTest.java | 9 + .../mailbox/model/search/PrefixedWildcardTest.java | 8 + .../james/mailbox/backup/DefaultMailboxBackup.java | 2 + .../cassandra/mail/CassandraMailboxMapper.java | 13 +- .../cassandra/mail/CassandraMailboxMapperTest.java | 33 ++- .../james/event/json/dtos/MailboxPathTest.java | 32 --- .../james/mailbox/jpa/mail/JPAMailboxMapper.java | 32 ++- .../model/openjpa/AbstractJPAMailboxMessage.java | 9 - .../jpa/mail/TransactionalMailboxMapper.java | 5 +- .../mailbox/maildir/mail/MaildirMailboxMapper.java | 31 ++- .../inmemory/mail/InMemoryMailboxMapper.java | 12 +- ...=> MailboxExpressionBackwardCompatibility.java} | 25 +- .../james/mailbox/store/StoreMailboxManager.java | 49 ++-- .../james/mailbox/store/mail/MailboxMapper.java | 3 +- .../store/mail/model/DelegatingMailboxMessage.java | 5 - .../mailbox/store/mail/model/MailboxMessage.java | 9 +- .../store/quota/CurrentQuotaCalculator.java | 18 +- .../store/quota/DefaultUserQuotaRootResolver.java | 14 +- .../search/comparator/CombinedComparator.java | 10 +- .../search/comparator/InternalDateComparator.java | 36 --- ...SizeComparator.java => MessageComparators.java} | 18 +- .../search/comparator/MessageIdComparator.java | 35 --- .../store/search/comparator/ReverseComparator.java | 56 ----- .../store/search/comparator/UidComparator.java | 36 --- .../mailbox/store/SimpleMailboxMembership.java | 5 - .../mailbox/store/StoreMailboxManagerTest.java | 23 +- .../store/mail/model/ListMessageAssertTest.java | 5 - .../store/mail/model/MailboxMapperTest.java | 117 +++------- .../quota/DefaultUserQuotaRootResolverTest.java | 4 +- .../store/search/CombinedComparatorTest.java | 30 ++- .../main/java/org/apache/james/imap/api/Tag.java | 14 +- .../james/imap/api/message/StatusDataItems.java | 71 +++--- .../imap/api/message/request/ImapRequest.java | 3 +- .../imap/api/message/response/StatusResponse.java | 3 +- .../message/response/StatusResponseFactory.java | 13 +- .../james/imap/decode/ImapCommandParser.java | 3 +- .../james/imap/decode/ImapRequestLineReader.java | 5 +- .../decode/base/AbstractImapCommandParser.java | 5 +- .../james/imap/decode/main/DefaultImapDecoder.java | 9 +- .../parser/AbstractMessageRangeCommandParser.java | 5 +- .../parser/AbstractSelectionCommandParser.java | 5 +- .../decode/parser/AbstractUidCommandParser.java | 7 +- .../imap/decode/parser/AppendCommandParser.java | 3 +- .../decode/parser/AuthenticateCommandParser.java | 3 +- .../decode/parser/CapabilityCommandParser.java | 3 +- .../imap/decode/parser/CheckCommandParser.java | 3 +- .../imap/decode/parser/CloseCommandParser.java | 3 +- .../imap/decode/parser/CompressCommandParser.java | 3 +- .../imap/decode/parser/CopyCommandParser.java | 3 +- .../imap/decode/parser/CreateCommandParser.java | 3 +- .../imap/decode/parser/DeleteACLCommandParser.java | 3 +- .../imap/decode/parser/DeleteCommandParser.java | 3 +- .../imap/decode/parser/EnableCommandParser.java | 3 +- .../imap/decode/parser/ExamineCommandParser.java | 3 +- .../imap/decode/parser/ExpungeCommandParser.java | 3 +- .../imap/decode/parser/FetchCommandParser.java | 3 +- .../imap/decode/parser/GetACLCommandParser.java | 3 +- .../decode/parser/GetAnnotationCommandParser.java | 5 +- .../imap/decode/parser/GetQuotaCommandParser.java | 3 +- .../decode/parser/GetQuotaRootCommandParser.java | 3 +- .../imap/decode/parser/IdleCommandParser.java | 3 +- .../imap/decode/parser/ListCommandParser.java | 5 +- .../decode/parser/ListRightsCommandParser.java | 3 +- .../imap/decode/parser/LoginCommandParser.java | 3 +- .../imap/decode/parser/LogoutCommandParser.java | 3 +- .../imap/decode/parser/LsubCommandParser.java | 3 +- .../imap/decode/parser/MoveCommandParser.java | 3 +- .../imap/decode/parser/MyRightsCommandParser.java | 3 +- .../imap/decode/parser/NamespaceCommandParser.java | 3 +- .../imap/decode/parser/NoopCommandParser.java | 3 +- .../imap/decode/parser/RenameCommandParser.java | 3 +- .../imap/decode/parser/SearchCommandParser.java | 5 +- .../imap/decode/parser/SelectCommandParser.java | 3 +- .../imap/decode/parser/SetACLCommandParser.java | 3 +- .../decode/parser/SetAnnotationCommandParser.java | 3 +- .../imap/decode/parser/SetQuotaCommandParser.java | 3 +- .../imap/decode/parser/StartTLSCommandParser.java | 3 +- .../imap/decode/parser/StatusCommandParser.java | 66 ++++-- .../imap/decode/parser/StoreCommandParser.java | 3 +- .../imap/decode/parser/SubscribeCommandParser.java | 3 +- .../james/imap/decode/parser/UidCommandParser.java | 3 +- .../imap/decode/parser/UnselectCommandParser.java | 3 +- .../decode/parser/UnsubscribeCommandParser.java | 3 +- .../imap/decode/parser/XListCommandParser.java | 3 +- .../james/imap/encode/ESearchResponseEncoder.java | 5 +- .../james/imap/encode/ImapResponseComposer.java | 3 +- .../james/imap/encode/StatusResponseEncoder.java | 3 +- .../imap/encode/base/ImapResponseComposerImpl.java | 5 +- .../org/apache/james/imap/main/PathConverter.java | 8 +- .../imap/message/request/AbstractImapRequest.java | 7 +- .../request/AbstractMailboxSelectionRequest.java | 3 +- .../request/AbstractMessageRangeRequest.java | 3 +- .../james/imap/message/request/AppendRequest.java | 3 +- .../imap/message/request/AuthenticateRequest.java | 3 +- .../imap/message/request/CapabilityRequest.java | 3 +- .../james/imap/message/request/CheckRequest.java | 3 +- .../james/imap/message/request/CloseRequest.java | 3 +- .../imap/message/request/CompressRequest.java | 3 +- .../james/imap/message/request/CopyRequest.java | 3 +- .../james/imap/message/request/CreateRequest.java | 3 +- .../imap/message/request/DeleteACLRequest.java | 3 +- .../james/imap/message/request/DeleteRequest.java | 3 +- .../james/imap/message/request/EnableRequest.java | 3 +- .../james/imap/message/request/ExamineRequest.java | 3 +- .../james/imap/message/request/ExpungeRequest.java | 3 +- .../james/imap/message/request/FetchRequest.java | 3 +- .../james/imap/message/request/GetACLRequest.java | 3 +- .../imap/message/request/GetAnnotationRequest.java | 5 +- .../imap/message/request/GetQuotaRequest.java | 3 +- .../imap/message/request/GetQuotaRootRequest.java | 3 +- .../message/request/IRAuthenticateRequest.java | 3 +- .../james/imap/message/request/IdleRequest.java | 3 +- .../james/imap/message/request/ListRequest.java | 3 +- .../imap/message/request/ListRightsRequest.java | 3 +- .../james/imap/message/request/LoginRequest.java | 3 +- .../james/imap/message/request/LogoutRequest.java | 3 +- .../james/imap/message/request/LsubRequest.java | 3 +- .../james/imap/message/request/MoveRequest.java | 3 +- .../imap/message/request/MyRightsRequest.java | 3 +- .../imap/message/request/NamespaceRequest.java | 3 +- .../james/imap/message/request/NoopRequest.java | 3 +- .../james/imap/message/request/RenameRequest.java | 3 +- .../james/imap/message/request/SearchRequest.java | 3 +- .../james/imap/message/request/SelectRequest.java | 3 +- .../james/imap/message/request/SetACLRequest.java | 3 +- .../imap/message/request/SetAnnotationRequest.java | 3 +- .../imap/message/request/SetQuotaRequest.java | 3 +- .../imap/message/request/StartTLSRequest.java | 3 +- .../james/imap/message/request/StatusRequest.java | 3 +- .../james/imap/message/request/StoreRequest.java | 3 +- .../imap/message/request/SubscribeRequest.java | 3 +- .../imap/message/request/UnselectRequest.java | 3 +- .../imap/message/request/UnsubscribeRequest.java | 3 +- .../james/imap/message/request/XListRequest.java | 3 +- .../response/AbstractStatusResponseFactory.java | 15 +- .../imap/message/response/ESearchResponse.java | 7 +- .../message/response/ImmutableStatusResponse.java | 7 +- .../response/UnpooledStatusResponseFactory.java | 3 +- .../imap/processor/AbstractAuthProcessor.java | 7 +- .../imap/processor/AbstractMailboxProcessor.java | 17 +- .../processor/AbstractMessageRangeProcessor.java | 3 +- .../imap/processor/AbstractSelectionProcessor.java | 7 +- .../processor/AbstractSubscriptionProcessor.java | 5 +- .../james/imap/processor/AppendProcessor.java | 7 +- .../imap/processor/AuthenticateProcessor.java | 5 +- .../james/imap/processor/CapabilityProcessor.java | 3 +- .../james/imap/processor/CheckProcessor.java | 3 +- .../james/imap/processor/CloseProcessor.java | 3 +- .../james/imap/processor/CreateProcessor.java | 3 +- .../james/imap/processor/DeleteACLProcessor.java | 3 +- .../james/imap/processor/DeleteProcessor.java | 3 +- .../james/imap/processor/EnableProcessor.java | 3 +- .../james/imap/processor/ExpungeProcessor.java | 3 +- .../james/imap/processor/GetACLProcessor.java | 3 +- .../imap/processor/GetAnnotationProcessor.java | 7 +- .../james/imap/processor/GetQuotaProcessor.java | 11 +- .../imap/processor/GetQuotaRootProcessor.java | 3 +- .../apache/james/imap/processor/IdleProcessor.java | 3 +- .../apache/james/imap/processor/LSubProcessor.java | 3 +- .../apache/james/imap/processor/ListProcessor.java | 3 +- .../james/imap/processor/ListRightsProcessor.java | 3 +- .../james/imap/processor/LoginProcessor.java | 3 +- .../james/imap/processor/LogoutProcessor.java | 3 +- .../james/imap/processor/MyRightsProcessor.java | 3 +- .../james/imap/processor/NamespaceProcessor.java | 3 +- .../apache/james/imap/processor/NoopProcessor.java | 3 +- .../james/imap/processor/RenameProcessor.java | 3 +- .../james/imap/processor/SearchProcessor.java | 3 +- .../james/imap/processor/SetACLProcessor.java | 3 +- .../imap/processor/SetAnnotationProcessor.java | 3 +- .../james/imap/processor/SetQuotaProcessor.java | 3 +- .../james/imap/processor/StatusProcessor.java | 107 +++++---- .../james/imap/processor/StoreProcessor.java | 19 +- .../james/imap/processor/SubscribeProcessor.java | 3 +- .../james/imap/processor/UnselectProcessor.java | 3 +- .../james/imap/processor/UnsubscribeProcessor.java | 3 +- .../processor/base/UnknownRequestProcessor.java | 3 +- .../james/imap/processor/fetch/FetchProcessor.java | 3 +- .../java/org/apache/james/imap/ImapFixture.java | 7 +- .../java/org/apache/james/imap/api/TagTest.java | 9 +- .../AbstractStatusResponseFactoryTest.java | 3 +- .../james/imap/decode/parser/CopyParserTest.java | 5 +- .../decode/parser/CreateCommandParserTest.java | 2 +- .../parser/FetchCommandParserPartialFetchTest.java | 10 +- .../parser/GetAnnotationCommandParserTest.java | 3 +- .../imap/decode/parser/GetQuotaParserTest.java | 5 +- .../imap/decode/parser/GetQuotaRootParserTest.java | 9 +- .../james/imap/decode/parser/MoveParserTest.java | 5 +- .../parser/SearchCommandParserCharsetTest.java | 3 +- .../SearchCommandParserQuotedCharsetTest.java | 4 +- .../parser/SetAnnotationCommandParserTest.java | 2 +- .../decode/parser/SetQuotaCommandParserTest.java | 3 +- .../imap/decode/parser/StoreCommandParserTest.java | 8 +- .../apache/james/imap/main/PathConverterTest.java | 46 +--- .../james/imap/processor/CopyProcessorTest.java | 11 +- .../imap/processor/DeleteACLProcessorTest.java | 3 +- .../james/imap/processor/GetACLProcessorTest.java | 3 +- .../imap/processor/GetAnnotationProcessorTest.java | 31 +-- .../imap/processor/GetQuotaProcessorTest.java | 17 +- .../imap/processor/GetQuotaRootProcessorTest.java | 7 +- .../james/imap/processor/LSubProcessorTest.java | 2 +- .../imap/processor/ListRightsProcessorTest.java | 3 +- .../james/imap/processor/MoveProcessorTest.java | 11 +- .../imap/processor/NamespaceProcessorTest.java | 9 +- .../james/imap/processor/SearchProcessorTest.java | 3 +- .../james/imap/processor/SetACLProcessorTest.java | 7 +- .../imap/processor/SetAnnotationProcessorTest.java | 14 +- .../imap/processor/SetQuotaProcessorTest.java | 3 +- .../james/dnsservice/dnsjava/DNSJavaService.java | 22 +- .../jmap/draft/model/mailbox/MailboxNamespace.java | 1 + 230 files changed, 1110 insertions(+), 1298 deletions(-) delete mode 100644 mailbox/api/src/main/java/org/apache/james/mailbox/StandardMailboxMetaDataComparator.java copy mailbox/store/src/main/java/org/apache/james/mailbox/store/{Authenticator.java => MailboxExpressionBackwardCompatibility.java} (67%) delete mode 100644 mailbox/store/src/main/java/org/apache/james/mailbox/store/search/comparator/InternalDateComparator.java rename mailbox/store/src/main/java/org/apache/james/mailbox/store/search/comparator/{SizeComparator.java => MessageComparators.java} (71%) delete mode 100644 mailbox/store/src/main/java/org/apache/james/mailbox/store/search/comparator/MessageIdComparator.java delete mode 100644 mailbox/store/src/main/java/org/apache/james/mailbox/store/search/comparator/ReverseComparator.java delete mode 100644 mailbox/store/src/main/java/org/apache/james/mailbox/store/search/comparator/UidComparator.java copy server/mailrepository/mailrepository-api/src/main/java/org/apache/james/mailrepository/api/Protocol.java => protocols/imap/src/main/java/org/apache/james/imap/api/Tag.java (86%) copy mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/json/SerializableMessage.java => protocols/imap/src/test/java/org/apache/james/imap/ImapFixture.java (90%) copy third-party/linshare/src/test/java/org/apache/james/linshare/client/UserTest.java => protocols/imap/src/test/java/org/apache/james/imap/api/TagTest.java (92%) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org