Hupa - Demo mode ?

2011-09-23 Thread Felix Knecht
Hi all According to HUPA-25 [1] there should be a running demo of hupa at [2]. It isn't - I know, it's an open issue. Why I come to this? I found several classes in the productive (not test) part in the server module to enable running the demo. I wonder if there's really a need to 'pollute'

Re: Hupa - Demo mode ?

2011-09-27 Thread Manuel Carrasco Moñino
Hi Felix, Demo is a set of messages used for unit testting. Those messages are used for demoing, in demo mode we inject mock imap and smpt implementations, so there is no imap connection nor smtp (although it is possible to deliver smtp if it is configured). I think we could move those classes/res

Re: Hupa - Demo mode ?

2011-09-27 Thread Felix Knecht
Hi Manolo Comments inline On 09/27/2011 07:11 PM, Manuel Carrasco Moñino wrote: Hi Felix, Demo is a set of messages used for unit testting. Those messages are used for demoing, in demo mode we inject mock imap and smpt implementations, so there is no imap connection nor smtp (although it is pos

Re: Hupa - Demo mode ?

2011-09-27 Thread Felix Knecht
IIRC at least James-Server uses slf4j and not commons-logging. Maybe hupa should also use slf4j to be constant in using the same logging facade? On 09/28/2011 12:03 AM, Felix Knecht wrote: Hi Manolo Comments inline On 09/27/2011 07:11 PM, Manuel Carrasco Moñino wrote: Hi Felix, Demo is a set

Re: Hupa - Demo mode ?

2011-09-27 Thread Norman Maurer
+1 to move to slf4j Bye, Norman 2011/9/28 Felix Knecht : > IIRC at least James-Server uses slf4j and not commons-logging. Maybe hupa > should also use slf4j to be constant in using the same logging facade? > > On 09/28/2011 12:03 AM, Felix Knecht wrote: >> >> Hi Manolo >> >> Comments inline >> >

Re: Hupa - Demo mode ?

2011-09-28 Thread Manuel Carrasco Moñino
Hi Felix, Demo mode in Hupa does not use a dummy mail server, it uses guice and gin to inject mock implementations of imap and smtp client classes no dummy servers at all. There are no integration tests in Hupa needing a running server, all tests are unit tests (I love TDD and think that integrati

Re: Hupa - Demo mode ?

2011-09-28 Thread Manuel Carrasco Moñino
I agree, we should use the same logging framework. - Manolo On Wed, Sep 28, 2011 at 8:15 AM, Norman Maurer wrote: > +1 to move to slf4j > > Bye, > Norman > > > 2011/9/28 Felix Knecht : > > IIRC at least James-Server uses slf4j and not commons-logging. Maybe hupa > > should also use slf4j to be