Re: JVMTI OOM handling when arrays / objects are too large

I'm not sure if the heap dump is as interesting as the fact that you are going to take some action when you do OnOutOfMemoryError. It is rather surprising to have specified that a particular action is taken when a OOME occurs, and have it not happen when an OOME occurs. I guess that because it is

Re: JVMTI OOM handling when arrays / objects are too large

FWIW, I also think that having a call to new throw anything that isn't an OOME is opening up a much larger compatibility can of worms than anything else I intended with this patch. Jeremy On Mon, Jun 15, 2009 at 12:39 AM, Jeremy Manson wrote: > Hi Tomas (and David, presumably), > > Why is this a

Re: JVMTI OOM handling when arrays / objects are too large

Hi Tomas (and David, presumably), Why is this a programming error? I thought it was just a VM limitation. Surely the JVMS allows arrays of any nonnegative integral size, no? Jeremy On Mon, Jun 15, 2009 at 12:20 AM, Tomas Hurka wrote: > Hi Martin and David, > > On 14 Jun 2009, at 21:37, Martin

Re: JVMTI OOM handling when arrays / objects are too large

David Holmes - Sun Microsystems wrote: Martin, Jeremy, This change has been bugging me. I guess what I don't like is not the "fix" but the fact that we report OutOfMemoryError for this situation in the first place! We are not out-of-memory! We've been asked to allocate something that is impos

Re: JVMTI OOM handling when arrays / objects are too large

Hi Jeremy, On 15 Jun 2009, at 09:53, Jeremy Manson wrote: FWIW, I also think that having a call to new throw anything that isn't an OOME is opening up a much larger compatibility can of worms than anything else I intended with this patch. I understand. Bye, -- Tomas Hurka

Re: JVMTI OOM handling when arrays / objects are too large

Hi Jeremy, On 15 Jun 2009, at 09:39, Jeremy Manson wrote: Why is this a programming error? I thought it was just a VM limitation. Well, maybe the error is probably not the right word. The point is that this is not OOME. You are right that it is VM limitation. Surely the JVMS allows array

Re: JVMTI OOM handling when arrays / objects are too large

Hi Martin and David, On 14 Jun 2009, at 21:37, Martin Buchholz wrote: I've polished the changes in preparation for committing. I'll commit once I have reviewer approval. I have the same concern as David. I think that throwing OOME, in places where there is obviously a simple programming error