Re: Need reviewer - jdk7 jdwpgen, added netbeans project, fixed findbugs errors

2009-08-20 Thread Tim Bell
Hi Kelly >6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project > > > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-jdwpgen-6853636/webrev/ > > Pretty harmless code cleanup on the tool used to generate > some of the JDWP code for the debugger. This is a tool run at buil

Re: Need reviewer - jdk7 jdwpgen, added netbeans project, fixed findbugs errors

2009-08-20 Thread Andrew John Hughes
2009/8/21 Kelly O'Hair : > > Still need reviewer ... > >  6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project > >  http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-jdwpgen-6853636/webrev/ > > Pretty harmless code cleanup on the tool used to generate > some of the JDWP code for the d

Need reviewer - jdk7 jdwpgen, added netbeans project, fixed findbugs errors

2009-08-20 Thread Kelly O'Hair
Still need reviewer ... 6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-jdwpgen-6853636/webrev/ Pretty harmless code cleanup on the tool used to generate some of the JDWP code for the debugger. -kto

Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.

2009-08-20 Thread Mark Reinhold
This change was integrated prematurely. I've rolled it back in the jdk7/tl/jdk repository. If you've already pulled it into a local repository then you can remove it using the hg strip command, which is part of the mq extension. Your tip changeset should be: changeset: 1563:5cd12b68d09b u

hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be. (also reviewed by ksaks, ryano)

2009-08-20 Thread lance . andersen
Changeset: 4ec7d1890538 Author:lancea Date: 2009-08-20 19:21 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4ec7d1890538 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be. (also reviewed by ksaks, ryano) Reviewed-by:

hg: jdk7/tl/jdk: 3 new changesets

2009-08-20 Thread alan . bateman
Changeset: dfece53c600f Author:alanb Date: 2009-08-20 08:39 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dfece53c600f 6595866: File does work with symbolic links (win,vista) Reviewed-by: sherman ! src/windows/native/java/io/WinNTFileSystem_md.c + test/java/io/File/SymLinks