Daniel D. Daugherty wrote:
:
Shouldn't this:
173 b[expected] = '\0'; /* ensure null-terminated */
be this:
173 b[received] = '\0'; /* ensure null-terminated */
To cover the case of a short receive count...
They are the equal at this point because the read loop has read the
Kelly O'Hair wrote:
This:
expected = strlen(hello);
Should probably be:
expected = (int)strlen(hello);
Yes, it should.
And I would almost think that this:
char msg[100];
should be:
char msg[80+expected*2];
and snprintf() used rather than sprintf? But not a big deal.
Make sense, an
Changeset: 5342b0cdbf95
Author:xlu
Date: 2009-08-27 18:00 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5342b0cdbf95
6876282: BigDecimal's divide(BigDecimal bd, RoundingFormat r) produces
incorrect result
Reviewed-by: darcy
! src/share/classes/java/math/BigDecimal.java
! t
Changeset: 477c5bf1149c
Author:jjg
Date: 2009-08-27 18:25 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/477c5bf1149c
6876765: javah tests fail on Windows
Reviewed-by: darcy
! test/tools/javah/6257087/foo.sh
! test/tools/javah/ConstMacroTest.sh
! test/tools/javah/Missi
Changeset: f29068bfeaed
Author:jjg
Date: 2009-08-27 17:50 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f29068bfeaed
6876755: apt tests fail on Windows
Reviewed-by: darcy
! test/tools/apt/Basics/apt.sh
! test/tools/apt/Basics/print.sh
! test/tools/apt/Compile/compile.
Changeset: 2c20f17c429c
Author:jjg
Date: 2009-08-27 17:39 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2c20f17c429c
6876753: javap tests fail on Windows
Reviewed-by: darcy
! test/tools/javap/T4975569.java
! test/tools/javap/T6729471.java
! test/tools/javap/pathsep.sh
Alan Bateman wrote:
The webrev is here:
http://cr.openjdk.java.net/~alanb/6432567/webrev.00/
Shouldn't this:
173 b[expected] = '\0'; /* ensure null-terminated */
be this:
173 b[received] = '\0'; /* ensure null-terminated */
To cover the case of a short receive count...
Hi Alan:
> Tim - do you mind reviewing this one?
Sure.
> The issue as you know, arises
> when the debuggee is connected to something that isn't a debugger and
> the handshake fails. The transport code writes the error message into a
> buffer on the stack that isn't sized correctly and so can t
Changeset: 74760fd5197f
Author:jjg
Date: 2009-08-27 15:12 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/74760fd5197f
6843707: bad tests generate files in the test/ directory
6876699: generated files in repository
Reviewed-by: darcy
- test/tools/javac/meth/InvokeMH_BAD
This:
expected = strlen(hello);
Should probably be:
expected = (int)strlen(hello);
And I would almost think that this:
char msg[100];
should be:
char msg[80+expected*2];
and snprintf() used rather than sprintf? But not a big deal.
Looks good otherwise. Thanks for doing this.
-kto
Tim - do you mind reviewing this one? It's the BadHankshakeTest failure
on windows-x64 that we've discussed in the past but didn't manage to get
to the finish line. Another bug (and patch)[1] was submitted by Kees
Cook on exactly the same issue, but on Ubunutu with OpenJDK compiled
with an opti
Changeset: 25371bf31658
Author:darcy
Date: 2009-08-27 11:48 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/25371bf31658
6876628: @throw instead of @throws in two ParagraphView classes
Reviewed-by: peterz
! src/share/classes/javax/swing/text/ParagraphView.java
! src/share/cla
Changeset: ed31953ca025
Author:jjg
Date: 2009-08-27 11:08 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ed31953ca025
6875336: some tests should use /nodynamiccopyright/
Reviewed-by: darcy
! test/tools/javac/6521805/T6521805a.java
! test/tools/javac/6521805/T6521805a_1
Changeset: 8109aa93b212
Author:mcimadamore
Date: 2009-08-27 13:40 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8109aa93b212
6840638: Project Coin: Improved Type Inference for Generic Instance Creation
(aka 'diamond')
Summary: diamond operator implementation (simple a
14 matches
Mail list logo
