On Tue, Sep 1, 2009 at 01:29, Ulf Zibis wrote:
> Martin,
>
> I like how you have enhanced javadoc for Character class.
>
> Some coments:
> - You more like uppercased hex literals, so we are 2. :-)
I like consistency more than I like either uppercase or lowercase.
>
> - you have mixed value an
I have separated the "cosmetics":
https://bugs.openjdk.java.net/attachment.cgi?id=140&action=diff
https://bugs.openjdk.java.net/attachment.cgi?id=141&action=diff
-Ulf
Am 01.09.2009 10:29, Ulf Zibis schrieb:
Martin,
I like how you have enhanced javadoc for Character class.
Some comments:
- Yo
Changeset: 40a1327a5283
Author:jjg
Date: 2009-09-01 11:35 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/40a1327a5283
6877763: update langtools/test/Makefile for JPRT
Reviewed-by: ohair
! test/Makefile
Changeset: dda7e13f09fb
Author:mcimadamore
Date: 2009-09-01 14:53 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dda7e13f09fb
6650759: Inference of formal type parameter (unused in formal parameters) is
not performed
Summary: propagate inference constraints from 15.12.
Martin,
I like how you have enhanced javadoc for Character class.
Some coments:
- You more like uppercased hex literals, so we are 2. :-)
- you have mixed value and {...@code value}. I more like the
latter, it's compact and better readable
- you have mixed U+1234 and \u1234 style. Why?
- often
