Re: Review Request for 6876135: Add PlatformLoggingMXBean to eliminate the dependency on JMX from logging

2009-10-22 Thread Alan Bateman
Mandy Chung wrote: I moved it to java.util.logging and added a static field to be accessed by LoggingSupport. Webrev: http://cr.openjdk.java.net/~mchung/6876135/webrev.01/ The updated webrev looks good. -Alan.

Re: Review Request for 6876135: Add PlatformLoggingMXBean to eliminate the dependency on JMX from logging

2009-10-22 Thread Mandy Chung
Alan Bateman wrote: This looks good to me. A couple of comments: Thanks for the review. - I notice in ManagementFactoryHelper that you are using ObjectName.valueOf. I assume this will need to change due to the back-port of JSR 255. I have sync'ed with the latest TL changesets. - In j.u.lo

Re: JNI DEFINE_NEWSCALARARRAY uses DT_RETURN_MARK_DECL_FOR

2009-10-22 Thread Keith McGuigan
Thank you for these fixes, Mark, I've integrated them into http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot and they'll bubble up to the other repos (hotspot/hotspot and jdk7/hotspot) soon. Please refer to CR 6893483 to track these fixes. -- - Keith Mark Wielaard wrote: Hi, In jni.cpp t

hg: jdk7/tl/jdk: 6894169: Move HttpLogFormatter into a separate package

2009-10-22 Thread christopher . hegarty
Changeset: 93f8d9494e05 Author:chegar Date: 2009-10-22 15:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/93f8d9494e05 6894169: Move HttpLogFormatter into a separate package Reviewed-by: alanb ! make/sun/net/FILES_java.gmk - src/share/classes/sun/net/www/protocol/http/Http

Re: Review Request for 6876135: Add PlatformLoggingMXBean to eliminate the dependency on JMX from logging

2009-10-22 Thread Alan Bateman
Mandy Chung wrote: Fixed 6876135: Add PlatformLoggingMXBean to eliminate the dependency on JMX from logging Webrev at: http://cr.openjdk.java.net/~mchung/6876135/webrev.00/ A new java.lang.management.ManagementFactory.getPlatformMXBeans method was added to provide a generic way to obtain pla

hg: jdk7/hotspot-rt/hotspot: 6893483: DTrace probe return values for a couple JNI methods are wrong

2009-10-22 Thread keith . mcguigan
Changeset: 08780c8a9f04 Author:kamg Date: 2009-10-20 16:34 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/08780c8a9f04 6893483: DTrace probe return values for a couple JNI methods are wrong Summary: Fix the shadowing and incorrect macro usages Reviewed-by: coleenp