6898160: Need serviceability support for new vm argument type 'uint64_t'.
Webrev here
http://cr.openjdk.java.net/~phh/6898160/webrev.01/
A new vm argument type, 'uint64_t', was added as part of 6887571. The
jdk library
code in jdk/share/native/sun/management/Flag.c that fetches all the vm
Wouldn't it make more sense for the logic of converting a string into
a proper argument to live over in Flag instead of being buried in
attachListener? It seems more likely that no one will forget that way
and I think the result would be quite a bit shorter. It looks ok as
it too.
tom
Looks okay to me. Minor nit:
attachListener.cpp line 267: unsigned integer in the error message
should be unsigned 64-bit value or something like that.
Mandy
Paul Hohensee wrote:
6898160: Need serviceability support for new vm argument type 'uint64_t'.
Webrev here
Thanks for the quick review.
I changed it to flag value must be an unsigned 64-bit integer.
Paul
Mandy Chung wrote:
Looks okay to me. Minor nit:
attachListener.cpp line 267: unsigned integer in the error message
should be unsigned 64-bit value or something like that.
Mandy
Paul
Paul Hohensee wrote:
6898160: Need serviceability support for new vm argument type 'uint64_t'.
Webrev here
http://cr.openjdk.java.net/~phh/6898160/webrev.01/
src/share/vm/runtime/globals.cpp
No comments.
src/share/vm/services/attachListener.cpp
No comments other than agreeing with
Thanks, :)
Paul
Daniel D. Daugherty wrote:
Paul Hohensee wrote:
6898160: Need serviceability support for new vm argument type
'uint64_t'.
Webrev here
http://cr.openjdk.java.net/~phh/6898160/webrev.01/
src/share/vm/runtime/globals.cpp
No comments.
Changeset: 600bc3d048be
Author:andrew
Date: 2009-11-05 00:02 +
URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/600bc3d048be
6898251: Add ALT_DROPS_DIR feature to jaxp/jaxws
Summary: Allowthe directory for downloaded drops to beset using ALT_DROPS_DIR
Reviewed-by: ohair, jjg
Changeset: ba7ea42fc66e
Author:phh
Date: 2009-11-04 16:49 -0500
URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/ba7ea42fc66e
6898160: Need serviceability support for new vm argument type 'uint64_t'
Summary: Add serviceability support for uint64_t. Flags of unknown type