Re: Need reviewers, jdk7 testing changes

2009-12-07 Thread Martin Buchholz
On Mon, Dec 7, 2009 at 13:43, Tim Bell wrote: >>    java/util/Collection/MOAT.java > > It is a shame we have to exclude Martin's MOAT.java (Mother Of All Tests) > The comment shows the test failing on Solaris 10 x86, but you exclude > it on generic-all You cannot exclude the Mother Of All Tests.

Re: Need approval, JDI updates to openjdk6

2009-12-07 Thread Joe Darcy
Kelly O'Hair wrote: OpenJDK6 changes for JDI. I'm ready to push. I would like approvals from Joe, Jim, Alan, Dan, and Tim. Approved with comments. test/com/sun/jdi/StringConvertTest.sh 26 # @test @(#)StringConvertTest.sh 1.6 03/04/09 An expanded sccs keywork crept back in! Otherwis

hg: jdk7/tl/jdk: 6900043: Add method to return line.separator property

2009-12-07 Thread martinrb
Changeset: 0dcdb13ab6d0 Author:martin Date: 2009-12-07 16:44 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0dcdb13ab6d0 6900043: Add method to return line.separator property Summary: Add System.lineSeparator(), returning getProperty("line.separator") Reviewed-by: darcy ! sr

hg: jdk7/tl/jdk: 6905029: Broken links in Deflater and DeflaterOutputStream javadoc

2009-12-07 Thread martinrb
Changeset: e47e55b6ecf6 Author:martin Date: 2009-12-07 15:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e47e55b6ecf6 6905029: Broken links in Deflater and DeflaterOutputStream javadoc Summary: Fix syntax errors in @links Reviewed-by: alanb ! src/share/classes/java/util/z

Re: Need approval, JDI updates to openjdk6

2009-12-07 Thread Andrew John Hughes
2009/12/7 Kelly O'Hair : > > Andrew John Hughes wrote: >> >> 2009/12/7 Kelly O'Hair : >>> >>> OpenJDK6 changes for JDI. I'm ready to push. >>> >>> I would like approvals from Joe, Jim, Alan, Dan, and Tim. >>> >>> In the process of trying to get good test results running the openjdk6 >>> debugger (J

Re: Need approval, JDI updates to openjdk6

2009-12-07 Thread Tim Bell
Kelly O'Hair wrote: > Andrew John Hughes wrote: >> 2009/12/7 Kelly O'Hair : >>> OpenJDK6 changes for JDI. I'm ready to push. >>> >>> I would like approvals from Joe, Jim, Alan, Dan, and Tim. >>> >>> In the process of trying to get good test results running the openjdk6 >>> debugger (JDI) and jvmti

Re: Need approval, JDI updates to openjdk6

2009-12-07 Thread Kelly O'Hair
Andrew John Hughes wrote: 2009/12/7 Kelly O'Hair : OpenJDK6 changes for JDI. I'm ready to push. I would like approvals from Joe, Jim, Alan, Dan, and Tim. In the process of trying to get good test results running the openjdk6 debugger (JDI) and jvmti tests (com/sun/jdi and demo/jvmti), I kept

hg: jdk7/tl/langtools: 6907660: stupid typo in ZipFileIndex guarantees NPE

2009-12-07 Thread jonathan . gibbons
Changeset: ea89c5d4af08 Author:jjg Date: 2009-12-07 14:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ea89c5d4af08 6907660: stupid typo in ZipFileIndex guarantees NPE Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java

Re: Need reviewers, jdk7 testing changes

2009-12-07 Thread Tim Bell
Hi Kelly See below: > Need reviewer for JDK7 testing changes, e.g. testing via: >cd jdk/make && gmake all images && cd ../test && gmake jdk_all > > 6906210: Fix another minor typo in test/Makefile > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-changes4/webrev/ > > Dan had pointe

Re: Need approval, JDI updates to openjdk6

2009-12-07 Thread Andrew John Hughes
2009/12/7 Kelly O'Hair : > > OpenJDK6 changes for JDI. I'm ready to push. > > I would like approvals from Joe, Jim, Alan, Dan, and Tim. > > In the process of trying to get good test results running the openjdk6 > debugger (JDI) and jvmti tests (com/sun/jdi and demo/jvmti), I kept running > into fix

hg: jdk7/tl/jdk: 3 new changesets

2009-12-07 Thread alan . bateman
Changeset: c68f6b6b47fd Author:alanb Date: 2009-12-07 12:24 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c68f6b6b47fd 6903753: (se) Selector should implement Closeable Reviewed-by: chegar, forax ! src/share/classes/java/nio/channels/Selector.java Changeset: 587fa61c0f07 A

Re: Need approval, JDI updates to openjdk6

2009-12-07 Thread Daniel D. Daugherty
I'm also approving this without reviewing. Sorry, time is a little tight right now. Dan Kelly O'Hair wrote: OpenJDK6 changes for JDI. I'm ready to push. I would like approvals from Joe, Jim, Alan, Dan, and Tim. In the process of trying to get good test results running the openjdk6 debugger

Need reviewers, jdk7 testing changes

2009-12-07 Thread Kelly O'Hair
Need reviewer for JDK7 testing changes, e.g. testing via: cd jdk/make && gmake all images && cd ../test && gmake jdk_all 6906210: Fix another minor typo in test/Makefile http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-changes4/webrev/ Dan had pointed out my typo in the jdk/test/Makefi

Need approval, JDI updates to openjdk6

2009-12-07 Thread Kelly O'Hair
OpenJDK6 changes for JDI. I'm ready to push. I would like approvals from Joe, Jim, Alan, Dan, and Tim. In the process of trying to get good test results running the openjdk6 debugger (JDI) and jvmti tests (com/sun/jdi and demo/jvmti), I kept running into fixes made in jdk7 that were not in jdk6

hg: jdk7/tl/jdk: 6876158: Remove dependencies on Signer, Certificate, Identity, IdentityScope classes from java.security pkg

2009-12-07 Thread vincent . ryan
Changeset: 327adb1c2224 Author:vinnie Date: 2009-12-07 17:06 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/327adb1c2224 6876158: Remove dependencies on Signer, Certificate, Identity, IdentityScope classes from java.security pkg Reviewed-by: alanb, mullan ! src/share/classe