hg: jdk7/tl/jdk: 6908628: ObjectIdentifier s11n test fails

2009-12-08 Thread weijun . wang
Changeset: db5c77621c6b Author:weijun Date: 2009-12-09 11:15 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db5c77621c6b 6908628: ObjectIdentifier s11n test fails Reviewed-by: xuelei ! test/sun/security/util/Oid/S11N.sh

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Martin Buchholz
On Tue, Dec 8, 2009 at 16:42, Kelly O'Hair wrote: >> In theory, the process is supposed to prevent >> regression test failures from ever creeping in - that's the whole point. >> When they do (inevitably) creep in, >> they are supposed to be aggressively targeted. >> A gatekeeper demonstrates the

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Kelly O'Hair
Martin Buchholz wrote: On Mon, Dec 7, 2009 at 23:30, Martin Buchholz wrote: You cannot exclude the Mother Of All Tests. This is non-negotiable. More seriously... It's very difficult to manage creeping failures in regression tests. Tell me about it. :^( In theory, the process is suppos

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Martin Buchholz
On Mon, Dec 7, 2009 at 23:30, Martin Buchholz wrote: > You cannot exclude the Mother Of All Tests. > This is non-negotiable. More seriously... It's very difficult to manage creeping failures in regression tests. In theory, the process is supposed to prevent regression test failures from ever cr

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Joseph D. Darcy
Kelly O'Hair wrote: Need reviewer for JDK7 testing changes, e.g. testing via: cd jdk/make && gmake all images && cd ../test && gmake jdk_all 6906210: Fix another minor typo in test/Makefile http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-changes4/webrev/ Dan had pointed out my typo i

hg: jdk7/tl/jdk: 6903754: (bf) Improve floating-point buffer comparison

2009-12-08 Thread martinrb
Changeset: a0f6963b1618 Author:martin Date: 2009-12-08 12:41 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a0f6963b1618 6903754: (bf) Improve floating-point buffer comparison Summary: Describe the exact behavior of {Double,Float}Buffer.{equals,compareTo}; fix non-anti-symme

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Kelly O'Hair
Martin Buchholz wrote: On Mon, Dec 7, 2009 at 13:43, Tim Bell wrote: java/util/Collection/MOAT.java It is a shame we have to exclude Martin's MOAT.java (Mother Of All Tests) The comment shows the test failing on Solaris 10 x86, but you exclude it on generic-all You cannot exclude the Mot

Re: Need approval, JDI updates to openjdk6

2009-12-08 Thread Kelly O'Hair
Joseph D. Darcy wrote: Kelly O'Hair wrote: Joe Darcy wrote: Kelly O'Hair wrote: OpenJDK6 changes for JDI. I'm ready to push. I would like approvals from Joe, Jim, Alan, Dan, and Tim. Approved with comments. test/com/sun/jdi/StringConvertTest.sh 26 # @test @(#)StringConvertTest.sh

Re: Need approval, JDI updates to openjdk6

2009-12-08 Thread Joseph D. Darcy
Kelly O'Hair wrote: Joe Darcy wrote: Kelly O'Hair wrote: OpenJDK6 changes for JDI. I'm ready to push. I would like approvals from Joe, Jim, Alan, Dan, and Tim. Approved with comments. test/com/sun/jdi/StringConvertTest.sh 26 # @test @(#)StringConvertTest.sh 1.6 03/04/09 An expan

Re: Need approval, JDI updates to openjdk6

2009-12-08 Thread Kelly O'Hair
Joe Darcy wrote: Kelly O'Hair wrote: OpenJDK6 changes for JDI. I'm ready to push. I would like approvals from Joe, Jim, Alan, Dan, and Tim. Approved with comments. test/com/sun/jdi/StringConvertTest.sh 26 # @test @(#)StringConvertTest.sh 1.6 03/04/09 An expanded sccs keywork crep

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Alan Bateman
Kelly O'Hair wrote: : Dan had pointed out my typo in the jdk/test/Makefile ($->$$) but when I started running and re-running the tests I ran into more unstable tests. This webrev includes fixes to 3 tests and unfortuntately more additions to the ProblemList file. It would be good to create a bu

hg: jdk7/tl/jdk: 6905046: More Dual-pivot quicksort improvements

2009-12-08 Thread alan . bateman
Changeset: 146c8921267f Author:jjb Date: 2009-12-08 12:40 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/146c8921267f 6905046: More Dual-pivot quicksort improvements Summary: More improvements from the DPQ team Reviewed-by: alanb ! src/share/classes/java/util/DualPivotQuicks