Re: Request Review: 6902182: Starting with jdwp agent should not incur performance penalty

2010-01-08 Thread Daniel D. Daugherty
Thumbs up from me! Dan Deneau, Tom wrote: Cross posting to hotspot-compiler-...@openjdk.java.net and serviceability-dev@openjdk.java.net since this review request touches both compiler/runtime code and JVMTI code... New webrev is at http://cr.openjdk.java.net/~tdeneau/6902182/webrev.05 This

Re: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files

2010-01-08 Thread Kelly O'Hair
I've been told That Tom had suggested an alternative fix, I had not seen this email. But if adding symbols to the mapfiles fixes it, then than seems easier. Does adding in the ability to read alternative debuginfo files provide some additional functionality? -kto --

consolidating hotspot-svc into hotspot-rt

2010-01-08 Thread Daniel D. Daugherty
Greetings, Back around Christmas of *2008*, the OpenJDK7 Serviceability HotSpot Repository was merged with the OpenJDK7 Runtime HotSpot Repository. However, it has been pointed out that while this was discussed for about two months internally to Sun, we didn't post an e-mail on the OpenJDK7 alias

hg: jdk7/hotspot-rt/hotspot: 14 new changesets

2010-01-08 Thread coleen . phillimore
Changeset: 40e7c1d24e4a Author:twisti Date: 2010-01-04 00:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/40e7c1d24e4a 6909153: Fix broken options on Zero Summary: Smaller fixes to ensure that Zero still works with non-standard options. Reviewed-by: twisti Cont

Re: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files

2010-01-08 Thread Kelly O'Hair
Andrew Haley wrote: On 12/09/2009 03:36 PM, Andrew Haley wrote: This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 The symptom is that jmap doesn't work because target libraries are stripped. The fix is to allow the symtab reader to use the separate debuginfo files that are available fo

Re: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files

2010-01-08 Thread Kelly O'Hair
Andrew John Hughes wrote: 2010/1/8 Kelly O'Hair : Andrew John Hughes wrote: 2010/1/8 Kelly O'Hair : Andrew Haley wrote: On 12/09/2009 03:36 PM, Andrew Haley wrote: This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 The symptom is that jmap doesn't work because target libraries are

hg: jdk7/tl/langtools: 6915152: langtools build failures with import.jdk on Windows

2010-01-08 Thread jonathan . gibbons
Changeset: 96c56220dcc2 Author:jjg Date: 2010-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/96c56220dcc2 6915152: langtools build failures with import.jdk on Windows Reviewed-by: ohair ! make/build.xml

RE: Request Review: 6902182: Starting with jdwp agent should not incur performance penalty

2010-01-08 Thread Deneau, Tom
Cross posting to hotspot-compiler-...@openjdk.java.net and serviceability-dev@openjdk.java.net since this review request touches both compiler/runtime code and JVMTI code... New webrev is at http://cr.openjdk.java.net/~tdeneau/6902182/webrev.05 This webrev addresses the comments made by Dan Daugh

Re: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files

2010-01-08 Thread Andrew John Hughes
2010/1/8 Kelly O'Hair : > > > Andrew John Hughes wrote: >> >> 2010/1/8 Kelly O'Hair : >>> >>> Andrew Haley wrote: On 12/09/2009 03:36 PM, Andrew Haley wrote: > > This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 > The symptom is that jmap doesn't work because target l

Re: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files

2010-01-08 Thread Kelly O'Hair
Andrew John Hughes wrote: 2010/1/8 Kelly O'Hair : Andrew Haley wrote: On 12/09/2009 03:36 PM, Andrew Haley wrote: This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 The symptom is that jmap doesn't work because target libraries are stripped. The fix is to allow the symtab reader to

hg: jdk7/tl/langtools: 6915078: ALT_JDK_IMPORT_PATH typo in langtools/make/Makefile

2010-01-08 Thread jonathan . gibbons
Changeset: aa06467be3a2 Author:jjg Date: 2010-01-08 11:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/aa06467be3a2 6915078: ALT_JDK_IMPORT_PATH typo in langtools/make/Makefile Reviewed-by: tbell ! make/Makefile

hg: jdk7/tl/langtools: 6665791: com.sun.source.tree.MethodTree.toString() does not output default values

2010-01-08 Thread jonathan . gibbons
Changeset: 0e75f9f6d1d4 Author:jjg Date: 2010-01-08 11:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0e75f9f6d1d4 6665791: com.sun.source.tree.MethodTree.toString() does not output default values Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/tree/Pret

Re: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files

2010-01-08 Thread Andrew John Hughes
2010/1/8 Kelly O'Hair : > > > Andrew Haley wrote: >> >> On 12/09/2009 03:36 PM, Andrew Haley wrote: >>> >>> This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 >>> The symptom is that jmap doesn't work because target libraries are >>> stripped. >>> The fix is to allow the symtab reader to us

hg: jdk7/tl/langtools: 6878146: incorrect unused value should be deleted

2010-01-08 Thread jonathan . gibbons
Changeset: 2d15bf467aea Author:jjg Date: 2010-01-08 11:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2d15bf467aea 6878146: incorrect unused value should be deleted Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/util/LayoutCharacters.java

hg: jdk7/tl/langtools: 6878147: Keywords.log is declared and initialized but unused

2010-01-08 Thread jonathan . gibbons
Changeset: c315df443ff2 Author:jjg Date: 2010-01-08 11:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c315df443ff2 6878147: Keywords.log is declared and initialized but unused Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/parser/Keywords.java