hg: jdk7/tl/langtools: 6909470: langtools stub generator should prune unnecessary imports

2010-01-11 Thread jonathan . gibbons
Changeset: 51011e02c02f Author:jjg Date: 2010-01-11 16:18 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/51011e02c02f 6909470: langtools stub generator should prune unnecessary imports Reviewed-by: darcy ! make/tools/GenStubs/GenStubs.java

hg: jdk7/tl/jdk: 6828204: NavigableSet.subSet() documentation refers to nonexistent parameters

2010-01-11 Thread joe . darcy
Changeset: 9d38ab65acff Author:darcy Date: 2010-01-11 15:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d38ab65acff 6828204: NavigableSet.subSet() documentation refers to nonexistent parameters Reviewed-by: martin ! src/share/classes/java/util/NavigableMap.java ! src/sha

hg: jdk7/tl/langtools: 6915497: test test/tools/javac/nio/compileTest/CompileTest.java fails under Hudson

2010-01-11 Thread jonathan . gibbons
Changeset: 14a4c45ef734 Author:jjg Date: 2010-01-11 14:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/14a4c45ef734 6915497: test test/tools/javac/nio/compileTest/CompileTest.java fails under Hudson Reviewed-by: darcy ! test/tools/javac/nio/compileTest/CompileTest.j

RE: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Venkatachalam, Vasanth
Hi Dan, Your changes look good. As you may know, the JVM code will need to be modified to reflect the new naming conventions used in jvmticmlr.h. I believe the changes will be limited to the prims/jvmtiExport.cpp file. I assume you'll be making these changes separately, since I didn't see a new

hg: jdk7/tl/langtools: 6915476: java.util.regex.PatternSyntaxException in com.sun.tools.javac.nio.PathFileObject

2010-01-11 Thread jonathan . gibbons
Changeset: ca6bc36b2305 Author:jjg Date: 2010-01-11 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ca6bc36b2305 6915476: java.util.regex.PatternSyntaxException in com.sun.tools.javac.nio.PathFileObject Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/n

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Daniel D. Daugherty
Vasanth, thanks for the review! I'm not sure where your earlier reply went, but it hasn't shown up in my e-mail box yet... :-) Dan Venkatachalam, Vasanth wrote: Sorry  I just noticed that you have modified jvmtiExport.cpp.   The changes look good to me.   Vasanth

hg: jdk7/tl/langtools: 6764569: [PATCH] Fix unused imports in list resource bundles

2010-01-11 Thread jonathan . gibbons
Changeset: f983c1dca202 Author:jjg Date: 2010-01-11 14:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f983c1dca202 6764569: [PATCH] Fix unused imports in list resource bundles Reviewed-by: ksrini Contributed-by: jesse.gl...@sun.com ! make/tools/CompileProperties/Com

hg: jdk7/tl/langtools: 6326754: Compiler will fail to handle -Xmaxerrs with -ve numbers

2010-01-11 Thread jonathan . gibbons
Changeset: d02e99d31cc0 Author:jjg Date: 2010-01-11 14:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d02e99d31cc0 6326754: Compiler will fail to handle -Xmaxerrs with -ve numbers Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools

RE: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Venkatachalam, Vasanth
Sorry I just noticed that you have modified jvmtiExport.cpp. The changes look good to me. Vasanth From: Venkatachalam, Vasanth Sent: Monday, January 11, 2010 3:30 PM To: 'daniel.daughe...@sun.com'; Tom Rodriguez Cc: Deneau, Tom; serviceability-dev@openjdk.java.net Subject: RE: code review reque

hg: jdk7/tl/jdk: 6915313: Reorganize implementation to make it more feasible to port to JDK6

2010-01-11 Thread christopher . hegarty
Changeset: fc5578368a0c Author:chegar Date: 2010-01-11 16:04 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fc5578368a0c 6915313: Reorganize implementation to make it more feasible to port to JDK6 Summary: This makes the SCTP implementation easier to run with Suns JDK6. Revie

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Daniel D. Daugherty
Thanks for the review, Kelly! Dan Kelly O'Hair wrote: The makefile changes look fine, and thanks for fixing my spelling errors in the tests. ;^) The new demo looks good too. -kto Daniel D. Daugherty wrote: Thanks for the review! I did a merge with HSX-17 this AM and that went very smooth

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Kelly O'Hair
The makefile changes look fine, and thanks for fixing my spelling errors in the tests. ;^) The new demo looks good too. -kto Daniel D. Daugherty wrote: Thanks for the review! I did a merge with HSX-17 this AM and that went very smoothly so I'm testing those bits right now. I'm hoping to hea

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Daniel D. Daugherty
Thanks for the review!  I did a merge with HSX-17 this AM and that went very smoothly so I'm testing those bits right now. I'm hoping to hear from Vasanth today, but he doesn't appear to have an OpenJDK id so I can't list him as a reviewer; I have listed him as a contributor. I'm also hoping

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Tom Rodriguez
This looks good to me. Thanks for your thorough work on this. tom On Jan 11, 2010, at 11:28 AM, Daniel D. Daugherty wrote: > Second call for this code review request. > > Dan > > > Daniel D. Daugherty wrote: >> Greetings, >> >> The folks at AMD Labs have been kind enough to provide an >> ex

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Daniel D. Daugherty
Second call for this code review request. Dan Daniel D. Daugherty wrote: Greetings, The folks at AMD Labs have been kind enough to provide an extension to the JVM/TI CompileMethodLoad event in order to provide additional information about in-lining. This extension uses the existing (but previ