hg: jdk7/tl/jdk: 6944584: Improvements to subprocess handling on Unix

2010-06-11 Thread martinrb
Changeset: 422531c98ba5 Author:martin Date: 2010-06-11 18:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/422531c98ba5 6944584: Improvements to subprocess handling on Unix Summary: use thread pool for reaper thread; move most I/O operations out of reaper thread Reviewed-by

hg: jdk7/tl/jdk: 6959197: When building with JAVAC_MAX_WARNINGS=true, the build fails in sun/nio/cs due to the use of -Werror

2010-06-11 Thread ahughes
Changeset: c849dc20dc85 Author:andrew Date: 2010-06-12 01:32 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c849dc20dc85 6959197: When building with JAVAC_MAX_WARNINGS=true, the build fails in sun/nio/cs due to the use of -Werror Summary: Remove unneeded casts, add generic t

hg: jdk7/tl/langtools: 6958836: javadoc should support -Xmaxerrs and -Xmaxwarns

2010-06-11 Thread jonathan . gibbons
Changeset: d1ea43cb71c1 Author:jjg Date: 2010-06-11 17:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d1ea43cb71c1 6958836: javadoc should support -Xmaxerrs and -Xmaxwarns Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/c

Re: Code Review for WeakReference leak in the Logging API (6942989)

2010-06-11 Thread Martin Buchholz
On Fri, Jun 11, 2010 at 14:46, Daniel D. Daugherty wrote: > Jeremy, > > I'm definitely interested in learning about your approach to this issue. Here's the patch against openjdk6 by Jeremy. http://cr.openjdk.java.net/~martin/WeakLogger-jeremymanson.patch (It would take a bit of merging to port to

Re: Code Review for WeakReference leak in the Logging API (6942989)

2010-06-11 Thread Daniel D. Daugherty
Jeremy, I'm definitely interested in learning about your approach to this issue. Dan On 6/11/2010 12:55 PM, Jeremy Manson wrote: We also fixed this bug internally at Google (sending the patch out was a TODO, but we never got around to it). If you have any interest in comparing / contrasting

Re: Code Review for WeakReference leak in the Logging API (6942989)

2010-06-11 Thread Alan Bateman
Daniel D. Daugherty wrote: : Either of those schemes would be fine, but not for this fix and not without a good reason to do so. The theory is that there shouldn't be too many Logger objects in a normal system and once they have been added, then this fix doesn't come into play. I would be surpris

Re: Code Review for WeakReference leak in the Logging API (6942989)

2010-06-11 Thread Mandy Chung
Daniel D. Daugherty wrote: The theory is that there shouldn't be too many Logger objects in a normal system and once they have been added, then this fix doesn't come into play. I would be surprised if a real system had more than 100 Logger objects. FYI. AWT creates a number of loggers (see

Re: Code Review for WeakReference leak in the Logging API (6942989)

2010-06-11 Thread Alan Bateman
Eamonn McManus wrote: I think an alternative approach to the one here would be to use a global ReferenceQueue and a subclass of WeakReference that has a pointer back to the Logger or LogNode that contains this WeakReference. Then, in the cases where you currently check for stale entries, you c

hg: jdk7/hotspot-rt/langtools: 10 new changesets

2010-06-11 Thread john . coomes
Changeset: ebf09be0222c Author:jjg Date: 2010-05-13 11:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/ebf09be0222c 6952188: update timeout for langtools jtreg tests on JPRT Reviewed-by: ohair ! test/Makefile Changeset: e9ef849ae0ed Author:mcimadamore Da

hg: jdk7/hotspot-rt/jdk: 58 new changesets

2010-06-11 Thread john . coomes
Changeset: ee157d437aa8 Author:prr Date: 2010-05-27 08:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/ee157d437aa8 6954424: Support OpenType/CFF fonts in JDK 7 Reviewed-by: bae, igor ! src/share/classes/java/awt/Font.java ! src/share/classes/sun/font/SunFontManage

hg: jdk7/hotspot-rt: Added tag jdk7-b97 for changeset 5e197c942c6e

2010-06-11 Thread john . coomes
Changeset: 5bbc7438b333 Author:mikejwre Date: 2010-06-10 13:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/5bbc7438b333 Added tag jdk7-b97 for changeset 5e197c942c6e ! .hgtags

hg: jdk7/hotspot-rt/jaxws: Added tag jdk7-b97 for changeset dac23846092a

2010-06-11 Thread john . coomes
Changeset: 457109807109 Author:mikejwre Date: 2010-06-10 13:59 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/457109807109 Added tag jdk7-b97 for changeset dac23846092a ! .hgtags

hg: jdk7/hotspot-rt/jaxp: Added tag jdk7-b97 for changeset ca01ec32561f

2010-06-11 Thread john . coomes
Changeset: d4adf4f2d14c Author:mikejwre Date: 2010-06-10 13:59 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/d4adf4f2d14c Added tag jdk7-b97 for changeset ca01ec32561f ! .hgtags

hg: jdk7/hotspot-rt/corba: 5 new changesets

2010-06-11 Thread john . coomes
Changeset: 888a846a860a Author:alanb Date: 2010-06-01 15:16 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/888a846a860a 6955873: CORBA resources bundles and javax.activity missing from b94 Reviewed-by: ohair - make/com/sun/corba/minclude/ioser_io.jmk ! make/sun/cor

Re: Code Review for WeakReference leak in the Logging API (6942989)

2010-06-11 Thread Jeremy Manson
We also fixed this bug internally at Google (sending the patch out was a TODO, but we never got around to it). If you have any interest in comparing / contrasting approaches, let us know. Jeremy On Thu, Jun 10, 2010 at 10:13 AM, Daniel D. Daugherty wrote: > Greetings, > > I need a couple of cod

Re: Code Review for WeakReference leak in the Logging API (6942989)

2010-06-11 Thread Eamonn McManus
I think an alternative approach to the one here would be to use a global ReferenceQueue and a subclass of WeakReference that has a pointer back to the Logger or LogNode that contains this WeakReference. Then, in the cases where you currently check for stale entries, you could simply poll the Re

Re: Code Review for WeakReference leak in the Logging API (6942989)

2010-06-11 Thread Daniel D. Daugherty
On 6/11/2010 7:18 AM, Alan Bateman wrote: Daniel D. Daugherty wrote: : Here is the URL for the webrev: http://cr.openjdk.java.net/~dcubed/6942989-webrev/0/ I went through the changes too. Thanks! I agree with the performance concern with expunging stale entries each time a LogManager

hg: jdk7/tl/langtools: 6877961: langtools build should allow more options when running jtreg

2010-06-11 Thread jonathan . gibbons
Changeset: 224533455888 Author:jjg Date: 2010-06-11 07:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/224533455888 6877961: langtools build should allow more options when running jtreg Reviewed-by: mcimadamore ! make/build.xml

hg: jdk7/tl/jdk: 2 new changesets

2010-06-11 Thread alan . bateman
Changeset: 06699a990ac7 Author:alanb Date: 2010-06-11 14:31 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/06699a990ac7 6934585: TEST_BUG: java/nio/channels/AsynchronousSocketChannel/Basic.java Reviewed-by: chegar ! test/ProblemList.txt ! test/java/nio/channels/AsynchronousS

Re: Code Review for WeakReference leak in the Logging API (6942989)

2010-06-11 Thread Alan Bateman
Daniel D. Daugherty wrote: : Here is the URL for the webrev: http://cr.openjdk.java.net/~dcubed/6942989-webrev/0/ I went through the changes too. I agree with the performance concern with expunging stale entries each time a LogManager is created. Would it make sense to do this once every