Re: request for review (XS), 6458402: 3 jvmti tests fail with CMS and +ExplicitGCInvokesConcurrent

2010-12-03 Thread David Holmes
Igor Veresov said the following on 12/04/10 15:14: On 12/3/10 7:08 PM, David Holmes wrote: Keith McGuigan said the following on 12/03/10 23:19: On Dec 3, 2010, at 3:30 AM, Igor Veresov wrote: You're calling notify_gc_end() while holding the FullGCCount_lock. Is that ok? Would it be more prude

Re: request for review (XS), 6458402: 3 jvmti tests fail with CMS and +ExplicitGCInvokesConcurrent

2010-12-03 Thread Igor Veresov
On 12/3/10 7:08 PM, David Holmes wrote: Keith McGuigan said the following on 12/03/10 23:19: On Dec 3, 2010, at 3:30 AM, Igor Veresov wrote: You're calling notify_gc_end() while holding the FullGCCount_lock. Is that ok? Would it be more prudent to divert control to the user without holding it?

Re: request for review (XS), 6458402: 3 jvmti tests fail with CMS and +ExplicitGCInvokesConcurrent

2010-12-03 Thread David Holmes
Keith McGuigan said the following on 12/03/10 23:19: On Dec 3, 2010, at 3:30 AM, Igor Veresov wrote: You're calling notify_gc_end() while holding the FullGCCount_lock. Is that ok? Would it be more prudent to divert control to the user without holding it? The notify_gc_end() call does not div

Re: request for review (XS), 6458402: 3 jvmti tests fail with CMS and +ExplicitGCInvokesConcurrent

2010-12-03 Thread Igor Veresov
You're calling notify_gc_end() while holding the FullGCCount_lock. Is that ok? Would it be more prudent to divert control to the user without holding it? igor On 12/2/10 2:29 PM, Keith McGuigan wrote: This fix adds JVMTI callbacks for CMS full GCs: http://cr.openjdk.java.net/~kamg/6458402/w

Re: request for review (XS), 6458402: 3 jvmti tests fail with CMS and +ExplicitGCInvokesConcurrent

2010-12-03 Thread Y. Srinivas Ramakrishna
Keith, two points: (1) the gc_end() here is incorrectly placed for concurrent full gc calls. That's because the end may not yet have occurred. It occurs only in the else arm where we post the notify on the lock. That's the case when a concurrently called full gc has stood witness

hg: jdk7/tl/langtools: 6990209: JCK7-compiler lang/ICLS/icls006/icls00603/icls00603a.html#icls00603src test fails.

2010-12-03 Thread jim . holmlund
Changeset: 91b4f44c9742 Author:jjh Date: 2010-12-03 13:47 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/91b4f44c9742 6990209: JCK7-compiler lang/ICLS/icls006/icls00603/icls00603a.html#icls00603src test fails. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/t

hg: jdk7/hotspot-rt/hotspot: 6981484: Update development launcher

2010-12-03 Thread staffan . larsen
Changeset: cb2d0a362639 Author:sla Date: 2010-12-02 05:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/cb2d0a362639 6981484: Update development launcher Summary: Add new development launcher called hotspot(.exe) Reviewed-by: coleenp ! make/linux/makefiles/launc

hg: jdk7/tl/langtools: 2 new changesets

2010-12-03 Thread maurizio . cimadamore
Changeset: 9359f4222545 Author:mcimadamore Date: 2010-12-03 16:31 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9359f4222545 6956758: NPE in com.sun.tools.javac.code.Symbol - isSubClass Summary: Use of TransTypes.cast() instead of TransTypes.coerce() causes NPE in Low

Re: request for review (XS), 6458402: 3 jvmti tests fail with CMS and +ExplicitGCInvokesConcurrent

2010-12-03 Thread Keith McGuigan
Updated webrev: http://cr.openjdk.java.net/~kamg/6458402/webrev.01/ On Dec 3, 2010, at 3:30 AM, Igor Veresov wrote: You're calling notify_gc_end() while holding the FullGCCount_lock. Is that ok? Would it be more prudent to divert control to the user without holding it? igor On 12/2/10 2:

hg: jdk7/hotspot-rt/hotspot: 2 new changesets

2010-12-03 Thread stefan . karlsson
Changeset: c760f78e0a53 Author:stefank Date: 2010-12-01 15:04 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/c760f78e0a53 7003125: precompiled.hpp is included when precompiled headers are not used Summary: Added an ifndef DONT_USE_PRECOMPILED_HEADER to precompiled

Re: request for review (XS), 6458402: 3 jvmti tests fail with CMS and +ExplicitGCInvokesConcurrent

2010-12-03 Thread Keith McGuigan
On Dec 3, 2010, at 3:30 AM, Igor Veresov wrote: You're calling notify_gc_end() while holding the FullGCCount_lock. Is that ok? Would it be more prudent to divert control to the user without holding it? The notify_gc_end() call does not divert control to the user -- it contains only the c

Re: Review request: 7003789 PTRACE_GETREGS problems with SA on Linux.

2010-12-03 Thread Kevin Walls
>If PTRACE_GETREGS is undefined and PT_GETREGS is defined, PTRACE_GETREGS_REQ >will be defined >by undefined value. Yes, that was worrying me as well, as it's what I see on my fedora 13 x86_x64 system. And yes to your second message - we need to leave in the sparcv9 parts. I'm convinced PTRACE

hg: jdk7/tl/jdk: 6979376: to have ldap filters tolerate underscore character in object identifier

2010-12-03 Thread xuelei . fan
Changeset: 0e0bdcd9c101 Author:xuelei Date: 2010-12-02 23:44 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0e0bdcd9c101 6979376: to have ldap filters tolerate underscore character in object identifier Reviewed-by: weijun ! src/share/classes/com/sun/jndi/ldap/Filter.java ! t

Re: Review request: 7003789 PTRACE_GETREGS problems with SA on Linux.

2010-12-03 Thread Yasumasa Suenaga
Sorry... > BTW, this modification is for "agent/src/os/linux/ps_proc.c". > I guess that this source affects for Linux ONLY. > If my guess is correct, we can delete the statement about SPARC from this > source code. > > --- > #if defined(sparc) || defined(sparcv9) > #define ptrace_getregs(req