hg: jdk7/tl/jdk: 6975866: api/org_ietf/jgss/GSSContext/index.html#wrapUnwrapIOTest started to fail since jdk7 b102

2010-12-16 Thread weijun . wang
Changeset: 1f0f0737f04e Author:weijun Date: 2010-12-17 11:03 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f0f0737f04e 6975866: api/org_ietf/jgss/GSSContext/index.html#wrapUnwrapIOTest started to fail since jdk7 b102 Reviewed-by: valeriep ! src/share/classes/sun/security/

Re: request for review: 6436034: Instance filter doesn't filter event if it occurs in native method

2010-12-16 Thread Mandy Chung
On 12/16/10 14:29, Keith McGuigan wrote: I understand the benefit of allowing an older VM to run on JDK 7 so that we can easily verify a hotspot fix and identify hotspot regression. But I'm not sure if the jdwp agent should support that and wonder if it's useful in practice. The use case r

Re: request for review: 6436034: Instance filter doesn't filter event if it occurs in native method

2010-12-16 Thread Paul Hohensee
fwiw, the HSX model specifically doesn't support dropping old versions of Hotspot into newer JDKs. Paul On 12/16/10 6:01 PM, Alan Bateman wrote: Keith McGuigan wrote: : I like the flexibility of being able to swap in/out different JVMs -- be it earlier versions of Hotspot or something else t

Re: request for review: 6436034: Instance filter doesn't filter event if it occurs in native method

2010-12-16 Thread Alan Bateman
Keith McGuigan wrote: : I like the flexibility of being able to swap in/out different JVMs -- be it earlier versions of Hotspot or something else that maybe doesn't yet support JVMTI 1.2. Having the code written this way also makes it easier to port this code verbatim into other JDK codebases

Re: request for review: 6436034: Instance filter doesn't filter event if it occurs in native method

2010-12-16 Thread Keith McGuigan
On Dec 16, 2010, at 5:12 PM, Mandy Chung wrote: On 12/15/10 20:37, Keith McGuigan wrote: Checking the JVMTI version would help when you bump the minor number in the JVMTI version from 1.1.x to 1.2. If a new JVMTI function is added in JDK 7 in the future, it will bump the micro number but

Re: request for review: 6436034: Instance filter doesn't filter event if it occurs in native method

2010-12-16 Thread Mandy Chung
On 12/15/10 20:37, Keith McGuigan wrote: On Dec 15, 2010, at 4:44 AM, Alan Bateman wrote: Keith McGuigan wrote: : Yeah I missed that check too. I'm very much in favor of being able to use an older (or newer) JVM in the JDK7 image. Triage is one important reason but another is the non-sy

Re: request for review: 6436034: Instance filter doesn't filter event if it occurs in native method

2010-12-16 Thread Keith McGuigan
On Dec 16, 2010, at 4:11 PM, Alan Bateman wrote: Keith McGuigan wrote: : Ok, here's a new webrev: http://cr.openjdk.java.net/~kamg/6436034/webrev.01/ I added a regression test and modified the code in debugInit.cpp to explicitly allow running with JVMTI 1.1 if that's what the JVM support

hg: jdk7/tl/jaxws: 7006853: Integrate JAX-WS 2.2.2 RI into JDK 7

2010-12-16 Thread kelly . ohair
Changeset: aca101db2361 Author:ohair Date: 2010-12-16 13:14 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/aca101db2361 7006853: Integrate JAX-WS 2.2.2 RI into JDK 7 Reviewed-by: ramap ! jaxws.properties

hg: jdk7/tl/jaxp: 7007257: jaxp 1.4.5 jdk7 1st integration

2010-12-16 Thread kelly . ohair
Changeset: 63190d0ca619 Author:ohair Date: 2010-12-16 13:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/63190d0ca619 7007257: jaxp 1.4.5 jdk7 1st integration Reviewed-by: joehw ! jaxp.properties

Re: request for review: 6436034: Instance filter doesn't filter event if it occurs in native method

2010-12-16 Thread Alan Bateman
Keith McGuigan wrote: : Ok, here's a new webrev: http://cr.openjdk.java.net/~kamg/6436034/webrev.01/ I added a regression test and modified the code in debugInit.cpp to explicitly allow running with JVMTI 1.1 if that's what the JVM supports. The regression test is setup to pass when run wi

Re: Review request 7003487 clhsdbproc stacktrace fails on x64

2010-12-16 Thread Paul Hohensee
Looks good. Paul On 12/16/10 1:23 PM, Kevin Walls wrote: Hi again -- Just a minor nit I'd like to fix for the x64 linux tools. Thanks Kevin On 30/11/2010 16:52, Kevin Walls wrote: Hi, An oversight whereby although jstack and the Serviceability Agent's jstackproc.sh work on x64, the clhsd

Re: Review request 7003487 clhsdbproc stacktrace fails on x64

2010-12-16 Thread Kevin Walls
Hi again -- Just a minor nit I'd like to fix for the x64 linux tools. Thanks Kevin On 30/11/2010 16:52, Kevin Walls wrote: Hi, An oversight whereby although jstack and the Serviceability Agent's jstackproc.sh work on x64, the clhsdbproc tool (and I expect HSDB) can't get a stacktrace. Th

hg: jdk7/tl/jdk: 6980447: Rhino JavaScript engine code in jdk-7 has to updated with the latest code from Rhino 1.7R3.

2010-12-16 Thread sundararajan . a
Changeset: e67a399dd4ad Author:sundar Date: 2010-12-16 20:52 +0530 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e67a399dd4ad 6980447: Rhino JavaScript engine code in jdk-7 has to updated with the latest code from Rhino 1.7R3. Summary: Updating Rhino javascript engine with versio