Re: SECOND CALL: serviceability agent (SA) fix for VS2010 (6987812)

2010-12-22 Thread Daniel D. Daugherty
Poonam, Thanks for the review! And you're most welcome for the lib search logic. Dan On 12/22/2010 6:17 PM, Poonam Bajaj wrote: Hi Dan, I looked at the changes. It looks good. Thanks for fixing the search logic for dbg*.dll files in WindbgDebuggerLocal.java. Thanks, Poonam On 12/23/2010

hg: jdk7/tl/jdk: 6581254: pkcs11 provider fails to parse configuration file contains windows short path

2010-12-22 Thread valerie . peng
Changeset: d4c2d2d72cfc Author:valeriep Date: 2010-12-22 18:30 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d4c2d2d72cfc 6581254: pkcs11 provider fails to parse configuration file contains windows short path Summary: Modified configuration parsing code to support "~". Revi

Re: SECOND CALL: serviceability agent (SA) fix for VS2010 (6987812)

2010-12-22 Thread Poonam Bajaj
Hi Dan, I looked at the changes. It looks good. Thanks for fixing the search logic for dbg*.dll files in WindbgDebuggerLocal.java. Thanks, Poonam On 12/23/2010 4:45 AM, Daniel D. Daugherty wrote: Added original reviewer list back in since this is an open review... Thanks for the review! Da

hg: jdk7/hotspot-rt/hotspot: 29 new changesets

2010-12-22 Thread coleen . phillimore
Changeset: 5fa559508216 Author:iveresov Date: 2010-12-15 20:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/5fa559508216 7007229: Fix warnings with VS2010 in compressedStream.cpp Summary: An interference between a fix for 6993125 and disabled optimization in co

JVMTI GetStackTrace / GetThreadListStackTraces / GetAllStackTraces & GetFrameCount

2010-12-22 Thread Erich
Hello, I've a few suggestions for future jvmti revisions regarding the Get*StackTrace[s] functions. First, they are quite inconsistent. While you can provide a start depth when calling the GetStackTrace function, GetThreadListStackTraces / GetAllStackTraces are lacking this parameter. I don't

Re: SECOND CALL: serviceability agent (SA) fix for VS2010 (6987812)

2010-12-22 Thread Daniel D. Daugherty
Added original reviewer list back in since this is an open review... Thanks for the review! Dan On 12/22/2010 3:54 PM, Swamy Venkataramanappa wrote: Dan, I did a quick review of your code and it looks good. I did not read Microsoft spec. Thanks, -Swamy On 12/22/2010 4:46 PM, Daniel D. Daug

SECOND CALL: serviceability agent (SA) fix for VS2010 (6987812)

2010-12-22 Thread Daniel D. Daugherty
Second Call! I'm trying to get this fix in before the holiday break. This should take < 15 minutes unless you try reading the Microsoft spec :-) Dan On 12/22/2010 9:05 AM, Daniel D. Daugherty wrote: It occurs to me that some folks might want to look at the spec: http://www.microsoft.com

hg: jdk7/hotspot-rt/hotspot: 2 new changesets

2010-12-22 Thread zhengyu . gu
Changeset: 1e637defdda6 Author:zgu Date: 2010-12-22 11:24 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/1e637defdda6 6961186: Better VM handling of unexpected exceptions from application native code Summary: Trap uncaught C++ exception on Windows and Solaris and

Re: serviceability agent (SA) fix for VS2010 (6987812)

2010-12-22 Thread Daniel D. Daugherty
It occurs to me that some folks might want to look at the spec: http://www.microsoft.com/whdc/system/platform/firmware/PECOFF.mspx http://kishorekumar.net/pecoff_v8.1.htm The Microsoft link has a click through agreement so I also provided a link to a copy of the straight HTML that I found. Dan

hg: jdk7/tl/jdk: 6996365: Evaluate the priorities of cipher suites

2010-12-22 Thread xuelei . fan
Changeset: 0d826185a92e Author:xuelei Date: 2010-12-22 06:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d826185a92e 6996365: Evaluate the priorities of cipher suites Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/CipherSuite.java

hg: jdk7/tl/jdk: 6560348: PIT : java/awt/xembed/server/RunTestXEmbed.java fails

2010-12-22 Thread ptisnovs
Changeset: 9deace8396f9 Author:ptisnovs Date: 2010-12-22 14:37 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9deace8396f9 6560348: PIT : java/awt/xembed/server/RunTestXEmbed.java fails Summary: Testcase correction. Reviewed-by: anthony ! test/java/awt/xembed/server/TestXEmb

SA tools 32/64

2010-12-22 Thread Kevin Walls
Hi -- Using the SA tools, you would have thought the scripts named xxx.sh were for 32-bit debugees, and xxx64.sh were for 64-bit. Just noticed that on Linux/x64, while saenv64.sh just doesn't work, the regular (without "64" in their name) scripts are good for 64-bit x64/amd64 debugees. May

hg: jdk7/hotspot-rt/hotspot: 7008444: Remove unnecessary include of stdint.h in java_md.c

2010-12-22 Thread david . holmes
Changeset: e58d06a8037e Author:dholmes Date: 2010-12-21 23:39 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/e58d06a8037e 7008444: Remove unnecessary include of stdint.h in java_md.c Summary: Remove unnecessary include of stdint.h in java_md.c Reviewed-by: brutiss