Changeset: abfa0d8ea803
Author:ksrini
Date: 2011-12-07 10:47 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abfa0d8ea803
7086015: fix test/tools/javac/parser/netbeans/JavacParserTest.java
Reviewed-by: ksrini, jjg
Contributed-by: matherey.nu...@oracle.com
! test/tools/j
On 12/7/2011 2:04 PM, Mandy Chung wrote:
On 12/7/2011 1:30 PM, Frederic Parain wrote:
The execute method doesn't throw any exception other than
IAE. What happens if the specified command execution fails
in the target VM? If no exception is thrown, how does the
caller detect if the command suc
On 12/7/2011 1:30 PM, Frederic Parain wrote:
The execute method doesn't throw any exception other than
IAE. What happens if the specified command execution fails
in the target VM? If no exception is thrown, how does the
caller detect if the command succeeds or not and handle it
gracefully? It
Changeset: 4f0f9f9c4892
Author:smarks
Date: 2011-12-07 12:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f0f9f9c4892
7117249: fix warnings in java.util.jar, .logging, .prefs, .zip
Reviewed-by: alanb, dholmes, forax, sherman, smarks
Contributed-by: Prasannaa , Martijn Verb
On 12/7/11 2:32 AM, Mandy Chung wrote:
On 12/2/2011 5:57 AM, Frederic Parain wrote:
http://cr.openjdk.java.net/~fparain/7104647/webrev.jdk.00/
L112: Since you are in this file, can you fix the typo
"java.security.SecurityException" to "java.lang.SecurityException"?
Fixed.
The execute met
This is just the start of a review: fumble-fingers sent it well before
it's time.
Paul
On 12/7/11 4:15 PM, Paul Hohensee wrote:
For the hotspot part:
In attachListener.cpp, you might want to delete the first "return
JNI_OK;"
line, since the code under HAS_PENDING_EXCEPTION just falls throug
For the hotspot part:
In attachListener.cpp, you might want to delete the first "return JNI_OK;"
line, since the code under HAS_PENDING_EXCEPTION just falls through.
In jmm.h, minor formatting nit: be nice to indent "(JNIEnv" on lines 318,
319 and 325 the same as the existing declarations. Add
Changeset: 55d777c0860a
Author:dcubed
Date: 2011-12-07 07:27 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/55d777c0860a
7118648: disable compressed oops by default on MacOS X until 7118647 is fixed
Summary: UseCompressedOops is false by default on MacOS X; can sti
Fred,
Thanks for the clarification. You're totally right that the end of the
individual CMS pauses should not be seen as major GCs.
Tony
On 11/17/2011 9:27 AM, Frederic Parain wrote:
On 11/17/11 3:09 PM, Tony Printezis wrote:
Fred,
I haven't been following this thread closely, but I do h
