Re: Request for Review (XXL): 7104647: Adding a diagnostic command framework

2011-12-12 Thread David Holmes
Hi Fred, A couple of minor comments on the JDK side: HotSpotDiagnosticMXBean.java: Sorry if this is old ground but a query on the API design: is there a specific reason to use Lists rather than the arrays the VM will provide? HotSpotDiagnostic.java: 139 public List getDiagnosticCommand

hg: jdk8/tl/langtools: 7119829: Adjust default jprt testing configuration

2011-12-12 Thread kelly . ohair
Changeset: 4822dfe0922b Author:ohair Date: 2011-12-12 08:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4822dfe0922b 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties

hg: jdk8/tl/jaxws: 2 new changesets

2011-12-12 Thread kelly . ohair
Changeset: 6d622b1b4db0 Author:ohair Date: 2011-12-12 08:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6d622b1b4db0 7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac Reviewed-by: alanb ! build.xml Changeset: 6d2030eacdac Author:ohair Date: 20

hg: jdk8/tl/corba: 7119829: Adjust default jprt testing configuration

2011-12-12 Thread kelly . ohair
Changeset: 75529c21094f Author:ohair Date: 2011-12-12 08:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/75529c21094f 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties

hg: jdk8/tl/jaxp: 2 new changesets

2011-12-12 Thread kelly . ohair
Changeset: a482d45c93e9 Author:ohair Date: 2011-12-12 08:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a482d45c93e9 7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac Reviewed-by: alanb ! build.xml Changeset: a49db7c01db7 Author:ohair Date: 201

hg: jdk8/tl/jdk: 7119829: Adjust default jprt testing configuration

2011-12-12 Thread kelly . ohair
Changeset: 9c0a6185188f Author:ohair Date: 2011-12-12 08:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c0a6185188f 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties ! test/Makefile

hg: jdk8/tl: 7119829: Adjust default jprt testing configuration

2011-12-12 Thread kelly . ohair
Changeset: 9acd7374ff8a Author:ohair Date: 2011-12-12 08:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9acd7374ff8a 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties ! test/Makefile

Re: Request for Review (XXL): 7104647: Adding a diagnostic command framework

2011-12-12 Thread Daniel D. Daugherty
On 12/12/11 8:56 AM, Frederic Parain wrote: Minor updates: http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.04/ src/share/vm/services/attachListener.cpp The new include should be in alpha-order (between lines 36 & 37). I'm pretty sure that's the new style... Block comment

Re: Request for Review (XXL): 7104647: Adding a diagnostic command framework

2011-12-12 Thread Mandy Chung
On 12/12/2011 6:31 AM, Frederic Parain wrote: http://cr.openjdk.java.net/~fparain/7104647/webrev.jdk.03/ The jdk change looks okay to me. Mandy

hg: hsx/hotspot-rt/hotspot: 20 new changesets

2011-12-12 Thread vladimir . danushevsky
Changeset: e8fdaf4a66cb Author:kvn Date: 2011-11-10 20:17 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e8fdaf4a66cb 7110586: C2 generates incorrect results Summary: Exact limit of empty loop calculated incorrectly. Reviewed-by: iveresov, never ! src/share/vm/opt

Re: Request for Review (XXL): 7104647: Adding a diagnostic command framework

2011-12-12 Thread Paul Hohensee
Looks good. Thanks, Paul On 12/12/11 10:56 AM, Frederic Parain wrote: Minor updates: http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.04/ Fred On 12/12/11 03:29 PM, Frederic Parain wrote: Hi Paul, Thank you for the review. I've applied all your recommendations except the refactor

Re: Request for Review (XXL): 7104647: Adding a diagnostic command framework

2011-12-12 Thread Frederic Parain
Minor updates: http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.04/ Fred On 12/12/11 03:29 PM, Frederic Parain wrote: Hi Paul, Thank you for the review. I've applied all your recommendations except the refactoring in diagnosticCommandFramework.cpp (too few lines can be really factore

Re: Request for Review (XXL): 7104647: Adding a diagnostic command framework

2011-12-12 Thread Frederic Parain
Hi Robert, These issues should be solved with the new webrevs: http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.03/ http://cr.openjdk.java.net/~fparain/7104647/webrev.jdk.03/ Regards, Fred On 12/ 9/11 03:17 PM, Robert Ottenhag wrote: Adding to the review of jmm.h, that is modified

Re: Request for Review (XXL): 7104647: Adding a diagnostic command framework

2011-12-12 Thread Frederic Parain
Hi Paul, Thank you for the review. I've applied all your recommendations except the refactoring in diagnosticCommandFramework.cpp (too few lines can be really factored out without passing many arguments). New webrev is here: http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.03/ Regards

hg: jdk8/tl/jdk: 2 new changesets

2011-12-12 Thread chris . hegarty
Changeset: 3216717f96f5 Author:dl Date: 2011-12-12 10:45 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3216717f96f5 7118066: Warnings in java.util.concurrent package Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/cl

hg: jdk8/tl/jdk: 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH

2011-12-12 Thread neil . richards
Changeset: c508f38245f8 Author:ngmr Date: 2011-12-12 11:41 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c508f38245f8 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH Reviewed-by: alanb, chegar Contributed-by: Charles Lee ! src/sola