Thanks Fred.
I don't think maintaining the style of existing code needs to extend to
all aspects of that code but is more about general layout, spacing and
naming. So adding unnecessary casts to malloc, or declaring all
variables at the start of the method are not things that need to be
repea
Changeset: c647ebb3c4f7
Author:naoto
Date: 2011-12-13 15:41 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c647ebb3c4f7
4808233: "Locale" not thread-safe
Reviewed-by: okutsu
! src/share/classes/java/util/Locale.java
Changeset: 4e4fed1d02f9
Author:jjg
Date: 2011-12-13 14:33 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4e4fed1d02f9
7121164: renamed files not committed
Reviewed-by: ksrini
- src/share/classes/com/sun/tools/javac/main/JavacOption.java
+ src/share/classes/com/sun/tool
Changeset: 3809292620c9
Author:jjg
Date: 2011-12-13 11:21 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3809292620c9
7120736: refactor javac option handling
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/api/JavacTool.java
! src/share/classes/com/sun
Hi David,
Thanks for the review.
Changes have been applied to this new webrev:
http://cr.openjdk.java.net/~fparain/7104647/webrev.jdk.05/
My answers are in-lined below.
Fred
On 12/13/11 07:49 AM, David Holmes wrote:
Hi Fred,
A couple of minor comments on the JDK side:
HotSpotDiagnosticMXBe
Hi Serguei,
Thanks for the review.
I've applied the changes and the new webrev is here:
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.05/
Regards,
Fred
On 12/13/11 10:43 AM, serguei.spit...@oracle.com wrote:
Hi Frederik,
Your fix is already in a good shape!
src/share/vm/service
Hi Dan,
Thank you for the review.
The new webrev is here:
http://cr.openjdk.java.net/~fparain/7104647/webrev.hotspot.05/
And my answers are in-lined below.
On 12/12/11 09:08 PM, Daniel D. Daugherty wrote:
src/share/vm/services/attachListener.cpp
The new include should be in alpha-order (betwe
