RE: Synchronization question

2011-12-20 Thread Lee Ming
Hi Holmes, Thank you for your answer, I just like to clarify my question and your answer so far, public void put(long n){ try{ lock.lock(); obj.put(n); } finally { lock.unlock();} } } The obj.put(n) statement may involve with other methods within object obj, and those method may i

Re: Synchronization question

2011-12-20 Thread David Holmes
Not sure why you sent this to serviceability-dev as this has nothing to do with the JDK/JVM serviceability APIs On 21/12/2011 4:32 PM, Lee Ming wrote: > Currently We are developing a system that requires a lot of usages of > Java concurrency. There seem to be some > concurrent bugs in our system.

Synchronization question

2011-12-20 Thread Lee Ming
Hi everyone, Currently We are developing a system that requires a lot of usages of Java concurrency. There seem to be some concurrent bugs in our system. Thus I just wonder about the following usage of lock class Test{ private final PInfo obj = new PInfo(); private ReentrantLock lock =

Re: Request for review: 7064927: retransformClasses() does not pass in LocalVariableTable of a method

2011-12-20 Thread Paul Hohensee
Looks good, except that the LocalVariableTable attribute comments in write_code_attribute() and write_local_variable_table_attribute() don't match. The comment in the latter says "LineNumberTable" instead of "LocalVariableTable" and the descriptor is for the line number table rather than the loca

Re: Request for review: 7064927: retransformClasses() does not pass in LocalVariableTable of a method

2011-12-20 Thread Thomas Wuerthinger
Hi! I'd like to resend my request for review and kindly ask for a review for my patch that fixes bug number 7064927. The webrev is available at: http://cr.openjdk.java.net/~coleenp/7064927/ Thanks, thomas On 14.11.2011 12:18, Thomas Wuerthinger wrote: Hi! An open webrev of the patch that f

Re: RFR (XXS) : 7120974: ManagementPermission "control" needs clarification

2011-12-20 Thread Frederic Parain
CCC request has already been submitted and approved. I should have mention that in the RFR. Fred On 12/20/11 12:55 PM, David Holmes wrote: Does this need CCC approval? This is non-normative text providing information only so I think it is okay without CCC - but someone else should confirm that.

Re: RFR (XXS) : 7120974: ManagementPermission "control" needs clarification

2011-12-20 Thread David Holmes
Does this need CCC approval? This is non-normative text providing information only so I think it is okay without CCC - but someone else should confirm that. David On 20/12/2011 9:16 PM, Frederic Parain wrote: A simple change in the javadoc of java.lang.management.ManagementPermission to make

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2011-12-20 Thread paul . hohensee
Changeset: 6c995c08526c Author:phh Date: 2011-12-19 15:50 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6c995c08526c 7122880: Extend vendor-specific command interface to include manageable switches Summary: Add Flag::external_ext()/writable_ext(), both return fals

RFR (XXS) : 7120974: ManagementPermission "control" needs clarification

2011-12-20 Thread Frederic Parain
A simple change in the javadoc of java.lang.management.ManagementPermission to make more explicit the fact that the "control" permission can also allow disclosure of information about the application. Webrev is here: http://cr.openjdk.java.net/~fparain/7120974/webrev.00/ Thanks, Fred -- Frede