Changeset: 11698dedbe79
Author:weijun
Date: 2011-12-22 15:35 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11698dedbe79
7122169: TcpTimeout fail for various reasons
Reviewed-by: alanb
! test/sun/security/krb5/auto/TcpTimeout.java
Thanks for reviewing both!
I haven't thought of any good tracing additions to the
ClassFileLoadHook code path... but when I do...
Dan
On 12/21/11 9:40 PM, Poonam Bajaj wrote:
Hi Dan,
I have looked at both the JDK and the Hotspot changes, so you can add
me as reviewer for both.
I especially
Hi Dan,
On 12/22/2011 8:52 AM, Daniel D. Daugherty wrote:
On 12/21/11 8:05 PM, Poonam Bajaj wrote:
Hi Dan,
In the following block (in JPLISAgent.c):
/1278 if (!errorOccurred) {
1279 jvmtiError errorCode = JVMTI_ERROR_NONE;
1280 errorCod
Hi Dan,
I have looked at both the JDK and the Hotspot changes, so you can add me
as reviewer for both.
I especially like the class_load_kind addition to the following trace.
856 RC_TRACE_WITH_THREAD(0x0001, THREAD,
857 ("loading name=%s kind=%d (avail_mem=" UINT64_FORMAT "K)",
Changeset: c01e115b095e
Author:coleenp
Date: 2011-12-21 16:41 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c01e115b095e
7064927: retransformClasses() does not pass in LocalVariableTable of a method
Summary: Handle LVT attribute in the class file reconstitutor.
Re
Poonam,
I forgot to ask whether to put you down as a reviewer for both
the JDK fix and the HSX fix... so JDK only or both JDK and HSX?
Dan
On 12/21/11 8:22 PM, Daniel D. Daugherty wrote:
On 12/21/11 8:05 PM, Poonam Bajaj
On 12/21/11 8:05 PM, Poonam Bajaj wrote:
Hi Dan,
In the following block (in JPLISAgent.c):
1278 if (!errorOccurred) {
1279 jvmtiError errorCode =
JVMTI_ERROR_NONE;
1280
Hi Dan,
In the following block (in JPLISAgent.c):
1278 if (!errorOccurred) {
1279 jvmtiError errorCode = JVMTI_ERROR_NONE;
1280 errorCode =
(*jvmtienv)->RedefineClasses(jvmtienv, numDefs, classDe
Looks good.
Thanks,
Paul
On 12/21/11 3:35 PM, Thomas Wuerthinger wrote:
Thanks for the review. I've corrected the comments and created a new
webrev at: http://cr.openjdk.java.net/~thomaswue/7064927/webrev.00/
- thomas
On 20.12.2011 23:09, Paul Hohensee wrote:
Looks good, except that the L
Changeset: 11c26bfcf8c7
Author:phh
Date: 2011-12-21 15:48 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/11c26bfcf8c7
7091417: recvfrom's 6th input should be of type socklen_t
Summary: Revamp class os's socket method formal args to match socket.h, insert
casts in
On 12/21/11 4:07 PM, Karen Kinnear wrote:
Dan,
Thank you for the quick fix -
You're welcome. I'm trying to get this off my plate before
I leave for the holidays... so not exactly altruistic... :-)
I echo Coleen's sentiments of wondering how
you managed to find the problem(s).
I'll send
Dan,
Thank you for the quick fix - I echo Coleen's sentiments of wondering how
you managed to find the problem(s).
On Dec 21, 2011, at 5:41 PM, Daniel D. Daugherty wrote:
> Karen,
>
> Thanks for the quick review! Replies in-lined below...
>
>
> On 12/21/11 2:47 PM, Karen Kinnear wrote:
>> Dan
Karen,
Thanks for the quick review! Replies in-lined below...
On 12/21/11 2:47 PM, Karen Kinnear wrote:
Dan,
All versions of hotspot changes look good.
Thanks! Are you OK if I don't wait for someone from the new
Serviceability team on this review? Serguei has already left
for the holidays..
Changeset: a9dfdc523c2c
Author:valeriep
Date: 2011-12-21 14:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a9dfdc523c2c
6839886: Array overrun in pkcs11
Summary: Fix the wrong value when dealing w/ month and day.
Reviewed-by: mullan
! src/share/native/sun/security/pkcs11/
Dan,
All versions of hotspot changes look good.
For the JDK and test side:
1) minor: JPLISAgent.c - new lines 1210-1212 might just be an } else {
2) new lines 1311-1312
Why do you break if an error occurred?
If there is a reason to stop freeing memory, would that also apply if
you al
Sure, that's okay then.
Coleen
On 12/21/2011 4:25 PM, Daniel D. Daugherty wrote:
Coleen,
Thanks for the quick review!
I don't think it would be too hard to refactor that code, but
I would prefer not to for a couple of reasons:
- the JDK6u29 version will likely be pushed as an escalation fix
Coleen,
Thanks for the quick review!
I don't think it would be too hard to refactor that code, but
I would prefer not to for a couple of reasons:
- the JDK6u29 version will likely be pushed as an escalation fix
and refactoring is frowned upon unless absolutely necessary
- for ease of determin
Dan, I reviewed one of the hotspot versions and it looks good to me. I
have one request that the code in parseClassFile in the conditional
JvmtiExport::should_post_class_file_load_hook() { ... } be made into
it's own function because it's not the straight line case and is getting
to be a la
Thanks for the review. I've corrected the comments and created a new
webrev at: http://cr.openjdk.java.net/~thomaswue/7064927/webrev.00/
- thomas
On 20.12.2011 23:09, Paul Hohensee wrote:
Looks good, except that the LocalVariableTable attribute comments in
write_code_attribute() and write_loc
Greetings,
This is a code review request for "day one" memory leaks in
the java.lang.instrument.Instrumentation.redefineClasses()
and JVM/TI RetransformClasses() APIs.
Since one leak is in the JDK and the other leak is in the
VM, I'm sending out separate webrevs for each repo. I'm also
attacking
Changeset: b1814b3ea6d3
Author:michaelm
Date: 2011-12-21 10:06 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1814b3ea6d3
7078386: NetworkInterface.getNetworkInterfaces() may return corrupted results
on linux
Reviewed-by: michaelm, alanb, chegar
Contributed-by: brandon.pass
On 21/12/2011 5:48 PM, Lee Ming wrote:
> Hi Holmes,
>
> Thank you for your answer, I just like to clarify my question and your
> answer so far,
>
> public void put(long n){
> try{
> lock.lock();
> obj.put(n);
> }
> finally { lock.unlock();}
> }
> }
>
> The *obj.put(n) *statement may involve wit
Changeset: 1c4fffa22930
Author:okutsu
Date: 2011-12-21 17:09 +0900
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c4fffa22930
7122054: (tz) Windows-only: tzmappings needs update for KB2633952
Reviewed-by: peytoia
! src/windows/lib/tzmappings
23 matches
Mail list logo
