hg: hsx/hotspot-rt/jdk: 9 new changesets

2012-01-05 Thread john . coomes
Changeset: 172d70c50c65 Author:cgruszka Date: 2011-09-15 13:59 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/172d70c50c65 7066713: Separate demos from the bundles on Solaris and Linux Summary: add new license files to demos and samples, new directory for bundling Revi

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b20 for changeset 2b2818e3386f

2012-01-05 Thread john . coomes
Changeset: dc2ee8b87884 Author:katleman Date: 2012-01-05 08:42 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/dc2ee8b87884 Added tag jdk8-b20 for changeset 2b2818e3386f ! .hgtags

hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b20 for changeset f052abb8f374

2012-01-05 Thread john . coomes
Changeset: d41eeadf5c13 Author:katleman Date: 2012-01-05 08:42 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/d41eeadf5c13 Added tag jdk8-b20 for changeset f052abb8f374 ! .hgtags

hg: hsx/hotspot-rt/corba: Added tag jdk8-b20 for changeset 51d8b6cb18c0

2012-01-05 Thread john . coomes
Changeset: f157fc2a71a3 Author:katleman Date: 2012-01-05 08:42 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/f157fc2a71a3 Added tag jdk8-b20 for changeset 51d8b6cb18c0 ! .hgtags

hg: hsx/hotspot-rt: Added tag jdk8-b20 for changeset 5a5eaf6374bc

2012-01-05 Thread john . coomes
Changeset: cc771d92284f Author:katleman Date: 2012-01-05 08:42 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/cc771d92284f Added tag jdk8-b20 for changeset 5a5eaf6374bc ! .hgtags

Re: Request for Review: 7120511: Add diagnostic commands

2012-01-05 Thread David Holmes
Hi Fred, Curious about one thing. For the uptime, how does this: + void VMUptimeDCmd::execute(TRAPS) { + if (_date.value()) { + output()->date_stamp(true, "", ": "); + } + output()->time_stamp().update_to(tty->time_stamp().ticks()); + output()->stamp(); + output()->print_cr(" s");

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2012-01-05 Thread paul . hohensee
Changeset: 2e0ef19fc891 Author:phh Date: 2012-01-05 17:14 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2e0ef19fc891 7126480: Make JVM start time in milliseconds since the Java epoch available Summary: Expose existing Management::_begin_vm_creation_time via new ac

Re: Request for Review: 7120511: Add diagnostic commands

2012-01-05 Thread serguei.spit...@oracle.com
Looks good. Some minor comments. share/vm/services/diagnosticCommand.hpp Format of description() return is not consistent: - Some have dot at the end, some - not. - Some has an extra space. 72 return "Print the command line used to start this VM instance."; 86 return

Re: Request for Review: 7120511: Add diagnostic commands

2012-01-05 Thread Daniel D. Daugherty
On 1/5/12 8:19 AM, Frederic Parain wrote: This changeset aims to add a first set of diagnostic commands to the HotSpot JVM. It also includes minor modifications to the diagnostic command framework implementation to ease development of new diagnostic commands. The webrev is here: http://cr.openj

Re: Request for Review: 7120511: Add diagnostic commands

2012-01-05 Thread Paul Hohensee
Looks good. Tiny things: In globals.hpp, you might take this opportunity to get rid of the default value for the withComments argument to printFlags. In diagnosticCommand.hpp, there's a few places with blanks between parens where the blanks should go away, vis. static const char* name( ) { .

hg: hsx/hotspot-rt/hotspot: 7125594: C-heap growth issue in ThreadService::find_deadlocks_at_safepoint

2012-01-05 Thread frederic . parain
Changeset: 8a63c6323842 Author:fparain Date: 2012-01-05 07:26 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8a63c6323842 7125594: C-heap growth issue in ThreadService::find_deadlocks_at_safepoint Reviewed-by: sspitsyn, dcubed, mchung, dholmes ! src/share/vm/servi

Re: Request for Review: 7120511: Add diagnostic commands

2012-01-05 Thread Karen Kinnear
Frederic, Code looks good. A couple of minor comments/questions: 1) diagnosticCommand.cpp HeapDumpDCmd::execute - There is a comment in attachListener under dump_heap that would be helpful to have here as well: // Request a full GC before heap dump if live_objects ... 2) I wonder if it

Request for Review: 7120511: Add diagnostic commands

2012-01-05 Thread Frederic Parain
This changeset aims to add a first set of diagnostic commands to the HotSpot JVM. It also includes minor modifications to the diagnostic command framework implementation to ease development of new diagnostic commands. The webrev is here: http://cr.openjdk.java.net/~fparain/7120511/webrev.00/ H

hg: hsx/hotspot-rt/hotspot: 7127032: fix for 7122253 adds a JvmtiThreadState earlier than necessary

2012-01-05 Thread daniel . daugherty
Changeset: 5b58979183f9 Author:dcubed Date: 2012-01-05 06:24 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5b58979183f9 7127032: fix for 7122253 adds a JvmtiThreadState earlier than necessary Summary: Use JavaThread::jvmti_thread_state() instead of JvmtiThreadSta

RFR (XXS) : 7125594 C-heap growth issue in ThreadService::find_deadlocks_at_safepoint

2012-01-05 Thread Frederic Parain
This is a very simple fix for a memory leak. The ThreadService::find_deadlocks_at_safepoint method leaks on DeadlockCycle object every time it is called. A DeadlockCycle object, referenced by the 'cycle' local variable, is pre-allocated and used to store blocked threads. If a deadlock is found,