Changeset: 2050ff9dfc92
Author:darcy
Date: 2012-01-06 18:47 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2050ff9dfc92
7123649: Remove public modifier from Math.powerOfTwoF.
Reviewed-by: smarks, alanb
! src/share/classes/java/lang/Math.java
Changeset: 6720ae7b1448
Author:valeriep
Date: 2012-01-06 16:06 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6720ae7b1448
7033170: Cipher.getMaxAllowedKeyLength(String) throws NoSuchAlgorithmException
Summary: Changed to always use full transformation as provider properties.
Thumbs up.
Thanks,
Serguei
On 1/6/12 4:21 AM, Frederic Parain wrote:
Thanks for the review,
I've made consistent both the description strings
and the impact strings. I've also fixed the indentation
issue.
New webrev: http://cr.openjdk.java.net/~fparain/7120511/webrev.01/
Regards,
Fred
On 0
Changeset: cdc128128044
Author:valeriep
Date: 2012-01-05 18:18 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdc128128044
6414899: P11Digest should support cloning
Summary: Enhanced the PKCS11 Digest implementation to support cloning
Reviewed-by: vinnie
! make/sun/security
On 1/6/12 5:21 AM, Frederic Parain wrote:
New webrev: http://cr.openjdk.java.net/~fparain/7120511/webrev.01/
Thumbs up.
Dan
Changeset: 400cc379adb5
Author:alanb
Date: 2012-01-06 15:00 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/400cc379adb5
7127235: (fs) NPE in Files.walkFileTree if cached attributes are GC'ed
Reviewed-by: forax, chegar
! src/share/classes/java/nio/file/FileTreeWalker.java
Looks good.
Paul
On 1/6/12 7:17 AM, Frederic Parain wrote:
Thanks for the review,
On 01/ 5/12 07:32 PM, Paul Hohensee wrote:
In globals.hpp, you might take this opportunity to get rid of the
default value for the withComments argument to printFlags.
Done.
In diagnosticCommand.hpp, there's
Thanks for the review,
I've made consistent both the description strings
and the impact strings. I've also fixed the indentation
issue.
New webrev: http://cr.openjdk.java.net/~fparain/7120511/webrev.01/
Regards,
Fred
On 01/ 5/12 09:05 PM, serguei.spit...@oracle.com wrote:
Looks good.
Some mi
Thanks for the review, I've addressed the following points:
On 01/ 5/12 07:33 PM, Daniel D. Daugherty wrote:
src/share/vm/services/attachListener.cpp
The "out->cr()" on line 162 should follow line 160 (I think).
Makes sense, fixed.
src/share/vm/services/management.cpp
A comment above line 1
Thanks for the review,
On 01/ 5/12 07:32 PM, Paul Hohensee wrote:
In globals.hpp, you might take this opportunity to get rid of the
default value for the withComments argument to printFlags.
Done.
In diagnosticCommand.hpp, there's a few places with blanks
between parens where the blanks shou
Thanks for the review, my comments are inlined below.
On 01/ 5/12 05:19 PM, Karen Kinnear wrote:
Frederic,
Code looks good.
A couple of minor comments/questions:
1) diagnosticCommand.cpp HeapDumpDCmd::execute
- There is a comment in attachListener under dump_heap that would
be helpf
Hi David,
I've considered that the uptime value should be consistent
with other logging mechanisms in the VM tagging their output
with uptime timestamp (namely, the gc log), so I used the same
code to produce the uptime value. If the timestamp support
in the outputStream class is modified, the gc
12 matches
Mail list logo
