Re: Patch to fix build breakage with GCC 4.7

On 31/01/2012 12:36 PM, Deepak Bhole wrote: * David Holmes [2012-01-30 19:57]: While gcc compilation on sparc is rare I'm not sure that simply deleting the sparc-only option unconditionally is the right thing to do. I thought about that too. But I was unable to find info on OpenJDK + SPARC +

Re: Patch to fix build breakage with GCC 4.7

This change looks fine to me. It would be ok with me for this change to be pushed into the jdk8/build forest. Once there, I can do a JPRT run to verify it, but I really don't seen any issue here. -kto On Jan 30, 2012, at 4:57 PM, David Holmes wrote: > Hi Deepak, > > The primary change here is

Re: RFR: 7133124 Remove redundant packages from JAR command line

On Jan 30, 2012, at 9:41 AM, Robert Ottenhag wrote: > Inline, > >> -Original Message- >> From: Kelly O'Hair >> Sent: Monday, January 30, 2012 6:27 PM >> To: Robert Ottenhag >> Cc: Dmitry Samersoff; serviceability-dev@openjdk.java.net; John Coomes; >> build-...@openjdk.java.net >> Subject

Re: Patch to fix build breakage with GCC 4.7

Hi Deepak, The primary change here is a build change so I've cc'ed build-dev. The majority of the changes are to JVMTI demo files hence I've cc'd serviceability-dev. I think JDK8-dev doesn't need to be included now so I've bcc'd it. While gcc compilation on sparc is rare I'm not sure that si

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

On 31/01/2012 3:28 AM, Dmitry Samersoff wrote: On 2012-01-30 16:28, Staffan Larsen wrote: 2. If you decide to hardcode "/tmp" please, create a global constant for it. I don't agree that this would make the code easier to read or maintain. I should, however, include a comment saying that the fi

Re: RFR: 7133124 Remove redundant packages from JAR command line

On 01/30/2012 03:41 PM, Kelly O'Hair wrote: I also think that extremely low or no risk changes need not follow this rule, but the problem is getting people to agree with 'no risk changes' are. I've seen enough 'low risk' changes bring the house down that I'm on the paranoid side. :^( How does

Re: RFR: 7133124 Remove redundant packages from JAR command line

On Jan 30, 2012, at 10:02 AM, Jonathan Gibbons wrote: > On 01/30/2012 09:41 AM, Robert Ottenhag wrote: >>> > A push to a shared repo without verifying it builds on all supported >>> > platforms is risky behavior, and one that can >>> > consume needless resources finding out it doesn't build, a

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

On 1/30/12 11:40 AM, Staffan Larsen wrote: On 30 jan 2012, at 18:05, Daniel D. Daugherty wrote: The same fix will be needed in BsdVirtualMachine.java eventually. Please fix BsdVirtualMachine.java at the same time. Yeah, I'd love to, but it's still in the osx-port repo I keep forgetting that

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

On 30 jan 2012, at 18:05, Daniel D. Daugherty wrote: >> The same fix will be needed in BsdVirtualMachine.java eventually. > > Please fix BsdVirtualMachine.java at the same time. Yeah, I'd love to, but it's still in the osx-port repo and this fixes for jdk8 (and then back port to jdk7). I'll fi

Re: RFR: 7133124 Remove redundant packages from JAR command line

On 01/30/2012 09:41 AM, Robert Ottenhag wrote: > A push to a shared repo without verifying it builds on all supported > platforms is risky behavior, and one that can > consume needless resources finding out it doesn't build, and more > importantly waste your co-worker's time undoing it. > We

RE: RFR: 7133124 Remove redundant packages from JAR command line

Inline, > -Original Message- > From: Kelly O'Hair > Sent: Monday, January 30, 2012 6:27 PM > To: Robert Ottenhag > Cc: Dmitry Samersoff; serviceability-dev@openjdk.java.net; John Coomes; > build-...@openjdk.java.net > Subject: Re: RFR: 7133124 Remove redundant packages from JAR command lin

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

On 2012-01-30 16:28, Staffan Larsen wrote: >> 2. If you decide to hardcode "/tmp" please, create a global constant >> for it. > > I don't agree that this would make the code easier to read or maintain. > I should, however, include a comment saying that the file is always in > /tmp regardless of th

Re: RFR: 7133124 Remove redundant packages from JAR command line

Diverged and in transit to another planet. :^( A push to a shared repo without verifying it builds on all supported platforms is risky behavior, and one that can consume needless resources finding out it doesn't build, and more importantly waste your co-worker's time undoing it. We have the abil

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

On 1/30/12 3:05 AM, Staffan Larsen wrote: Please review the following fix. Webrev: http://cr.openjdk.java.net/~sla/7132199/webrev.00/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132199 The problem is that HotSpot will always

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: f457154eee8b Author:brutisso Date: 2012-01-30 12:36 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f457154eee8b 7140882: Don't return booleans from methods returning pointers Summary: Changed "return false" to "return NULL" Reviewed-by: dholmes, rottenha

hg: jdk8/tl/jdk: 7132378: Race in FutureTask if used with explicit set ( not Runnable )

Changeset: f9fb8c4b4550 Author:dl Date: 2012-01-30 11:44 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9fb8c4b4550 7132378: Race in FutureTask if used with explicit set ( not Runnable ) Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/FutureTask.java +

hg: hsx/hotspot-rt/hotspot: 7022100: Method annotations are incorrectly set when redefining classes

Changeset: 26a08cbbf042 Author:stefank Date: 2012-01-27 13:46 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/26a08cbbf042 7022100: Method annotations are incorrectly set when redefining classes Summary: Changed to the correct annotation arrays Reviewed-by: kamg, dh

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

On 30 jan 2012, at 12:23, Dmitry Samersoff wrote: > 1. Why we can't use System.getProperty("java.io.tmpdir") ? Since HotSpot and the tools run in separate processes it is important that the file is in a well-known global location. It cannot be in different locations for different processes. Sin

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

Hi Staffan, I'm somewhat confused by this problem. 6938627 is the CR that changed from /tmp to use the java.io.tmpdir property, but that CR did not modify the files that you have modified - so what broke these files? Looking at your fix, wouldn't it be simpler to just set the static tmpdir t

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

Staffan, 1. Why we can't use System.getProperty("java.io.tmpdir") ? 2. If you decide to hardcode "/tmp" please, create a global constant for it. -Dmitry On 2012-01-30 14:05, Staffan Larsen wrote: > Please review the following fix. > > Webrev: http://cr.openjdk.java.net/~sla/7132199/webrev.00/

Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

Please review the following fix. Webrev: http://cr.openjdk.java.net/~sla/7132199/webrev.00/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132199 The problem is that HotSpot will always create the .java_pid1234 socket/door file in /tmp (see CR 7009828). The JDK will currently look fir

Re: RFR: 7133124 Remove redundant packages from JAR command line

Dmitry, I think this discussion diverged somewhat from the original topic, but I do agree with you that we must also attack the problem on a process level. With the model you propose (and also the existing model) I would also like to stress the need for continuous and automatic builds trigger

Re: RFR: 7133124 Remove redundant packages from JAR command line

John, Actually the goal of my letter is not to promote new integration scheme. Just to remind that we need to put some efforts to internal process review and optimization. But, see answers below (inline): Integration method I mentioned often used in open source projects, because it doesn't r