Re: Patch to fix build breakage with GCC 4.7

2012-01-31 Thread Deepak Bhole
* David Holmes [2012-01-30 21:50]: > On 31/01/2012 12:36 PM, Deepak Bhole wrote: > >* David Holmes [2012-01-30 19:57]: > >>While gcc compilation on sparc is rare I'm not sure that simply > >>deleting the sparc-only option unconditionally is the right thing to > >>do. > >> > > > >I thought about t

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

2012-01-31 Thread Staffan Larsen
Here is an updated webrev with an additional comment. Let me know if the comment can be improved or clarified. http://cr.openjdk.java.net/~sla/7132199/webrev.01/ Thanks, /Staffan On 30 jan 2012, at 13:28, Staffan Larsen wrote: > On 30 jan 2012, at 12:23, Dmitry Samersoff wrote: > >> 1. Why we

Re: Patch to fix build breakage with GCC 4.7

2012-01-31 Thread Deepak Bhole
* David Holmes [2012-01-30 19:57]: > Hi Deepak, > > The primary change here is a build change so I've cc'ed build-dev. > > The majority of the changes are to JVMTI demo files hence I've cc'd > serviceability-dev. > > I think JDK8-dev doesn't need to be included now so I've bcc'd it. > > While

hg: jdk8/tl/jdk: 2 new changesets

2012-01-31 Thread staffan . larsen
Changeset: 431bc327f34a Author:sla Date: 2012-01-31 10:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/431bc327f34a 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms Summary: Make sure HotSpot and JDK looks for well-known files i

hg: hsx/hotspot-rt/hotspot: 7114376: Make system dictionary hashtable bucket array size configurable

2012-01-31 Thread karen . kinnear
Changeset: b2cd0ee8f778 Author:acorn Date: 2012-01-30 23:27 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b2cd0ee8f778 7114376: Make system dictionary hashtable bucket array size configurable Summary: 7u4 new experimental flag -XX:PredictedClassLoadedCount=# Revie

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

2012-01-31 Thread Daniel D. Daugherty
Summary: The .java_pid socket/door is always created in the os::get_temp_directory() which is "/tmp" on BSD, Linux and Solaris. On MacOS X, it can be either the "secure per-user temporary directory" or "/tmp". The .attach_pid file is created by the Java side createAttachFile()

Re: Patch to fix build breakage with GCC 4.7

2012-01-31 Thread Andrew Hughes
- Original Message - > On 31/01/2012 12:36 PM, Deepak Bhole wrote: > > * David Holmes [2012-01-30 19:57]: > >> While gcc compilation on sparc is rare I'm not sure that simply > >> deleting the sparc-only option unconditionally is the right thing > >> to > >> do. > >> > > > > I thought ab

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

2012-01-31 Thread Daniel D. Daugherty
Sorry, sent that last one as "reply to list" instead of "reply to all"... I think you need to hold up on this one. I don't think the assumption that .java_pid and .attach_pid files are always in /tmp is a good one. More in a little bit. Dan On 1/31/12 1:10 AM, Staffan Larsen wrote: Moving "/tm

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

2012-01-31 Thread Daniel D. Daugherty
I think you need to hold up on this one. I don't think the assumption that .java_pid and .attach_pid files are always in /tmp is a good one. More in a little bit. Dan On 1/31/12 1:10 AM, Staffan Larsen wrote: Moving "/tmp" to a static field, made it easier to write a comment explaining the r

Re: Can't attach core image through SA tools

2012-01-31 Thread Yasumasa Suenaga
Hi David, Thank you for your cooperation. I couldn't find this CR. I will vote it. Thanks, Yasumasa On 2012/01/31 19:58, David Holmes wrote: > Hi, > > A bug was opened for this just a few days ago - 7133122. > > I'll add your patch to the CR. > > David Holmes > > > On 31/01/2012

hg: jdk8/tl/jdk: 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h

2012-01-31 Thread neil . richards
Changeset: 13978750cb87 Author:ngmr Date: 2012-01-31 10:31 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13978750cb87 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h Reviewed-by: alanb Contributed-by: Jonathan Lu ! src/solaris/native/java/l

Re: Can't attach core image through SA tools

2012-01-31 Thread David Holmes
Hi, A bug was opened for this just a few days ago - 7133122. I'll add your patch to the CR. David Holmes On 31/01/2012 8:32 PM, Yasumasa Suenaga wrote: > Hi, > > I've tried attach a corefile with jstack. However, I couldn't. > > I guess that this problem is caused by incorrect ad

Can't attach core image through SA tools

2012-01-31 Thread Yasumasa Suenaga
Hi, I've tried attach a corefile with jstack. However, I couldn't. I guess that this problem is caused by incorrect address mapping of libsaproc.so . I've made a patch which is attached this email. And I've been able to get correct thread stack with jstack. So, I'd like to contribute this patc

hg: jdk8/tl/jdk: 7123229: (coll) EnumMap.containsValue(null) returns true

2012-01-31 Thread neil . richards
Changeset: 863a20b0bf08 Author:ngmr Date: 2012-01-10 00:07 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/863a20b0bf08 7123229: (coll) EnumMap.containsValue(null) returns true Summary: java.util.EnumMap.NULL equals() must only be true for itself Reviewed-by: alanb, mduigou Co

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

2012-01-31 Thread David Holmes
+1 Thanks, David On 31/01/2012 6:17 PM, Dmitry Samersoff wrote: Staffan, Excellent, thank you! Looks good to me. -Dmitry On 2012-01-31 12:10, Staffan Larsen wrote: Moving "/tmp" to a static field, made it easier to write a comment explaining the rationale as well. Updated webrev: http://c

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

2012-01-31 Thread Dmitry Samersoff
Staffan, Excellent, thank you! Looks good to me. -Dmitry On 2012-01-31 12:10, Staffan Larsen wrote: > Moving "/tmp" to a static field, made it easier to write a comment > explaining the rationale as well. > > Updated webrev: http://cr.openjdk.java.net/~sla/7132199/webrev.02/ > > Thanks, > /S

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

2012-01-31 Thread Dmitry Samersoff
David, On 2012-01-31 04:23, David Holmes wrote: > Dmitry: The point is that the VM will always put the file in /tmp. > That's wrong but the issue here is making the management Java code match > the hotspot code. Yes I get it. I'm asking about final String hotpsotTmpDir="/tmp"; instead of copy-

Re: Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

2012-01-31 Thread Staffan Larsen
Moving "/tmp" to a static field, made it easier to write a comment explaining the rationale as well. Updated webrev: http://cr.openjdk.java.net/~sla/7132199/webrev.02/ Thanks, /Staffan On 31 jan 2012, at 01:23, David Holmes wrote: > On 31/01/2012 3:28 AM, Dmitry Samersoff wrote: >> On 2012-01