Re: Review Request: 7009098: SA cannot open core file larger than 2GB

2012-02-08 Thread Poonam Bajaj
On 2/9/2012 12:21 PM, David Holmes wrote: Hi Poonam, On 9/02/2012 4:42 PM, Poonam Bajaj wrote: There is one more change with which SA should first load libraries from the path specified with SA_ALTROOT rather than loading from the host system. Where does this come from? It is not related to

Re: Review Request: 7009098: SA cannot open core file larger than 2GB

2012-02-08 Thread David Holmes
Hi Poonam, On 9/02/2012 4:42 PM, Poonam Bajaj wrote: There is one more change with which SA should first load libraries from the path specified with SA_ALTROOT rather than loading from the host system. Where does this come from? It is not related to this CR. Is there another CR indicating the

Re: Review Request: 7009098: SA cannot open core file larger than 2GB

2012-02-08 Thread Poonam Bajaj
Hi David, On 2/9/2012 11:36 AM, David Holmes wrote: On 9/02/2012 2:41 PM, Poonam Bajaj wrote: Could I have code reviews for the following fix: 7009098: SA cannot open core file larger than 2GB http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7009098 Webrev: http://cr.openjdk.java.net/~poonam

Re: Review Request: 7009098: SA cannot open core file larger than 2GB

2012-02-08 Thread David Holmes
On 9/02/2012 2:41 PM, Poonam Bajaj wrote: Could I have code reviews for the following fix: 7009098: SA cannot open core file larger than 2GB http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7009098 Webrev: http://cr.openjdk.java.net/~poonam/7009098/webrev.00/ Serviceability Agent on Linux is

Re: Review Request: 7009098: SA cannot open core file larger than 2GB

2012-02-08 Thread Poonam Bajaj
Yes, I will change the synopsis of the bug to make it clear that this only affects Linux 32bit. Thanks, Poonam On 2/9/2012 10:50 AM, Krystal Mok wrote: Hi Poonam, Could the synopsis include the fact that this only affects Linux/x86 32-bit? I got a bit confused when I first read the synopsis,

Re: Review Request: 7009098: SA cannot open core file larger than 2GB

2012-02-08 Thread Krystal Mok
Hi Poonam, Could the synopsis include the fact that this only affects Linux/x86 32-bit? I got a bit confused when I first read the synopsis, because I've been using SA to open core files around 4GB~5GB on Linux/x64 routinely, and it worked. Regards, Kris Mok On Thu, Feb 9, 2012 at 12:41 PM, Poon

Review Request: 7009098: SA cannot open core file larger than 2GB

2012-02-08 Thread Poonam Bajaj
Could I have code reviews for the following fix: 7009098: SA cannot open core file larger than 2GB http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7009098 Webrev: http://cr.openjdk.java.net/~poonam/7009098/webrev.00/ Serviceability Agent on Linux is not able to open core files larger than 2GB

hg: jdk8/tl/jdk: 3 new changesets

2012-02-08 Thread chris . hegarty
Changeset: c64c815974ff Author:chegar Date: 2012-02-08 11:16 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c64c815974ff 7105929: java/util/concurrent/FutureTask/BlockingTaskExecutor.java fails on solaris sparc Reviewed-by: dholmes ! test/java/util/concurrent/FutureTask/Blo