hg: jdk8/tl/jdk: 7144781: incorrect URLs in JSSE java doc

2012-02-10 Thread xuelei . fan
Changeset: da8b8ee281f9 Author:xuelei Date: 2012-02-10 22:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da8b8ee281f9 7144781: incorrect URLs in JSSE java doc Reviewed-by: wetmore, skannan ! src/share/classes/javax/net/ssl/ExtendedSSLSession.java ! src/share/classes/javax

hg: jdk8/tl/jdk: 7142509: Cipher.doFinal(ByteBuffer, ByteBuffer) fails to process when in.remaining() == 0

2012-02-10 Thread bradford . wetmore
Changeset: b16cbeb0d213 Author:wetmore Date: 2012-02-10 19:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b16cbeb0d213 7142509: Cipher.doFinal(ByteBuffer,ByteBuffer) fails to process when in.remaining() == 0 Reviewed-by: valeriep ! src/share/classes/javax/crypto/CipherSp

hg: jdk8/tl/jdk: 26 new changesets

2012-02-10 Thread lana . steuck
Changeset: 8da468cf037b Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8da468cf037b Added tag jdk8-b24 for changeset 34029a0c69bb ! .hgtags Changeset: ad9f1c8970da Author:prr Date: 2012-01-19 12:41 -0800 URL: http://hg.o

hg: jdk8/tl/hotspot: 74 new changesets

2012-02-10 Thread lana . steuck
Changeset: 5f3fcd591768 Author:amurillo Date: 2012-01-20 17:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5f3fcd591768 7131979: new hotspot build - hs23-b12 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 53a127075045 Author:kvn Date: 2012-01-20 09:4

hg: jdk8/tl/corba: 2 new changesets

2012-02-10 Thread lana . steuck
Changeset: e45d6b406d5f Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e45d6b406d5f Added tag jdk8-b24 for changeset b98f0e6dddf9 ! .hgtags Changeset: 79f709a099f4 Author:katleman Date: 2012-02-09 12:55 -0800 URL: http

hg: jdk8/tl/langtools: 4 new changesets

2012-02-10 Thread lana . steuck
Changeset: 5a784dab75f1 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5a784dab75f1 Added tag jdk8-b24 for changeset 6c9d21ca92c4 ! .hgtags Changeset: 520c30f85bb5 Author:lana Date: 2012-02-07 10:39 -0800 URL: http

hg: jdk8/tl/jaxws: 3 new changesets

2012-02-10 Thread lana . steuck
Changeset: b376d901e006 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b376d901e006 Added tag jdk8-b24 for changeset e0d90803439b ! .hgtags Changeset: 3518639eab6c Author:katleman Date: 2012-02-09 12:55 -0800 URL: http

hg: jdk8/tl/jaxp: 2 new changesets

2012-02-10 Thread lana . steuck
Changeset: bb694c151fc7 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/bb694c151fc7 Added tag jdk8-b24 for changeset 7836655e2495 ! .hgtags Changeset: dbb7283c197b Author:katleman Date: 2012-02-09 12:55 -0800 URL: http:

hg: jdk8/tl: 3 new changesets

2012-02-10 Thread lana . steuck
Changeset: 5350cd6e0cc0 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5350cd6e0cc0 Added tag jdk8-b24 for changeset 1a5f1d6b98d6 ! .hgtags Changeset: 221a378e06a3 Author:lana Date: 2012-02-07 10:36 -0800 URL: http://hg.open

Re: Fwd: Re: Review Request: 7009098: SA cannot open core files larger than 2GB on Linux 32-bit

2012-02-10 Thread yumin . qi
Send on open alias. On 2/9/2012 9:45 PM, Yumin Qi wrote: looks good. Thanks Yumin On 2012/2/9 21:05, Poonam Bajaj wrote: Not sure if everyone is subscribed to serviceability-...@openjdk.java.net..so forwarding it. ] I got one review from David Holmes and need one more review to push this

Re: RR(XS): 7118280 The gbyc00102 JCK7 test causes an assert in JVM 7.0 fastdebug mode

2012-02-10 Thread Paul Hohensee
Looks good, again with Dan's recommendations. Paul On 2/10/12 9:37 AM, Daniel D. Daugherty wrote: On 2/10/12 5:14 AM, Dmitry Samersoff wrote: Hi Everybody, Assert incorrectly triggered by _invokedynamic opcode. Fixed assert. webrev is: http://cr.openjdk.java.net/~dsamersoff/7118280/webrev.0

Re: Review Request: 7009098: SA cannot open core files larger than 2GB on Linux 32-bit

2012-02-10 Thread Daniel D. Daugherty
On 2/9/12 10:00 PM, Poonam Bajaj wrote: Hi, Could I have one more review for this change, please. 7009098: SA cannot open core files larger than 2GB on Linux 32-bit http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7009098 Webrev: http://cr.

Re: RR(XS): 7118280 The gbyc00102 JCK7 test causes an assert in JVM 7.0 fastdebug mode

2012-02-10 Thread Daniel D. Daugherty
On 2/10/12 5:14 AM, Dmitry Samersoff wrote: Hi Everybody, Assert incorrectly triggered by _invokedynamic opcode. Fixed assert. webrev is: http://cr.openjdk.java.net/~dsamersoff/7118280/webrev.01/ Please update the copyright year to 2012. Thumbs up! src/share/vm/prims/jvmtiClassFileReconstit

Re: Request for Review (XS): 7143760 Memory leak in GarbageCollectionNotifications

2012-02-10 Thread Frederic Parain
Here's a new webrev addressing the following issues: - the missing HandleMark - the clean up of the GCNotificationRequest instance - removal of the pending exception testing, now exception will be propagated as soon as a method returns with a pending exception http://cr.openjdk.java

Re: Review Request: 7009098: SA cannot open core files larger than 2GB on Linux 32-bit

2012-02-10 Thread Kevin Walls
It looks good Poonam! 8-) On 10/02/12 05:00, Poonam Bajaj wrote: Hi, Could I have one more review for this change, please. 7009098: SA cannot open core files larger than 2GB on Linux 32-bit http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7009098

RR(XS): 7118280 The gbyc00102 JCK7 test causes an assert in JVM 7.0 fastdebug mode

2012-02-10 Thread Dmitry Samersoff
Hi Everybody, Assert incorrectly triggered by _invokedynamic opcode. Fixed assert. webrev is: http://cr.openjdk.java.net/~dsamersoff/7118280/webrev.01/ -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ...

Re: Request for Review (XS): 7143760 Memory leak in GarbageCollectionNotifications

2012-02-10 Thread Mikael Gerdin
Hi Fred, I ran the repro on a build with your fix applied and it appears that the leak is fixed. Thanks for finding it so quick :) /Mikael On Friday 10 February 2012 10.27.30 Frederic Parain wrote: > Here's a small fix (one line) for CR 7143760 Memory leak in > GarbageCollectionNotifications >

Re: Request for Review (XS): 7143760 Memory leak in GarbageCollectionNotifications

2012-02-10 Thread Frederic Parain
I agree that the CHECK path is not memory clean. I'm fixing it, I'll be back with better fix. Thanks, Fred On 2/10/12 11:27 AM, David Holmes wrote: On 10/02/2012 7:59 PM, Dmitry Samersoff wrote: Frederic, GCNotificationRequest *request = getRequest(); request variable also leaks memory beca

Re: Request for Review (XS): 7143760 Memory leak in GarbageCollectionNotifications

2012-02-10 Thread David Holmes
On 10/02/2012 7:59 PM, Dmitry Samersoff wrote: Frederic, GCNotificationRequest *request = getRequest(); request variable also leaks memory because it will never be deleted on CHECK return path. Could you fix it too? Further: 211 JavaCalls::call_virtual(&result, 212

Re: Request for Review (XS): 7143760 Memory leak in GarbageCollectionNotifications

2012-02-10 Thread Dmitry Samersoff
Frederic, GCNotificationRequest *request = getRequest(); request variable also leaks memory because it will never be deleted on CHECK return path. Could you fix it too? -Dmitry On 2012-02-10 13:27, Frederic Parain wrote: > Here's a small fix (one line) for CR 7143760 Memory leak in > GarbageC

Request for Review (XS): 7143760 Memory leak in GarbageCollectionNotifications

2012-02-10 Thread Frederic Parain
Here's a small fix (one line) for CR 7143760 Memory leak in GarbageCollectionNotifications There's a missing HandleMark at the beginning of the GCNotifier::sendNotificatin() method. Without this HandleMark, all handles used when creating GC notifications are kept alive causing a double leak:

Re: Request for Review (S) : 7140868 TEST_BUG: jcmd tests need to use -XX:+UsePerfData

2012-02-10 Thread Frederic Parain
Hi David, Thanks for the review. I'd prefer to keep the $JCMD variable with only the path to the jcmd binary, without any arguments. Having the -J-XX:UsePerfData repeated on every jcmd invocation is not necessarily a bad thing, it will remind the reader that jcmd depends on the perfdata. Fred