Changeset: b8a4e1d372a0
Author:kamg
Date: 2012-02-14 20:02 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b8a4e1d372a0
7145589: First JSDT provider creation fails
Summary: 0 is a successful return from an ioctl() call
Reviewed-by: dcubed, phh, dsamersoff
! src/sha
On 15/02/2012 7:20 AM, keith mcguigan wrote:
Well, ok, I guess it's not the smallest code change -- I think I've
matched this before -- but I guarantee you won't see one smaller than this!
It's a one-liner (a one-character-er) to accept 0 as a successful return
from an ioctl() call, for registe
Hi Nils,
I only glanced at this and though the change in thread.cpp a little strange:
3401 // Set flag that basic initialization has completed. Used by
exceptions and various
3402 // debug stuff, that does not work until all basic classes have
been initialized.
3403 set_init_completed()
Changeset: 28d91e43ab6d
Author:coleenp
Date: 2012-02-14 16:50 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/28d91e43ab6d
7145587: Stack overflows in Java code cause 64-bit JVMs to exit due to SIGSEGV
(sparc version)
Summary: Increase StackShadowPages to accomodat
Changeset: 84b61130cbed
Author:mcimadamore
Date: 2012-02-14 15:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84b61130cbed
7142086: performance problem in Check.checkOverrideClashes(...)
Summary: Code in Check.checkOverrideClashes() causes too many calls to
MethodSy
Changeset: a9831b955a0a
Author:kamg
Date: 2012-02-13 14:03 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a9831b955a0a
7069991: Setup make/jprt.properties files for jdk8
Summary: Change default release value to jdk8 (but overrideable)
Reviewed-by: phh, jcoomes, dho
Looks good.
The date in the copyright comment will be fixed by RE anyway.
Thanks,
Serguei
On 2/14/12 1:20 PM, keith mcguigan wrote:
Well, ok, I guess it's not the smallest code change -- I think I've
matched this before -- but I guarantee you won't see one smaller than
this!
It's a one-li
Looks good.
Paul
On 2/14/12 4:20 PM, keith mcguigan wrote:
Well, ok, I guess it's not the smallest code change -- I think I've
matched this before -- but I guarantee you won't see one smaller than
this!
It's a one-liner (a one-character-er) to accept 0 as a successful
return from an ioctl
Keith,
Looks good for me.
Thank you for catching it!
On 2012-02-15 01:20, keith mcguigan wrote:
>
> Well, ok, I guess it's not the smallest code change -- I think I've
> matched this before -- but I guarantee you won't see one smaller than this!
>
> It's a one-liner (a one-character-er) to acc
Well, ok, I guess it's not the smallest code change -- I think I've matched this
before -- but I guarantee you won't see one smaller than this!
It's a one-liner (a one-character-er) to accept 0 as a successful return from an
ioctl() call, for registering dtrace providers.
http://cr.openjdk.
Frederic, Nils,
Just fix the copyright then.
responses inline ...
On Feb 14, 2012, at 1:27 PM, Frederic Parain wrote:
>
>
> On 14/02/2012 18:55, Karen Kinnear wrote:
>> Thank you Nils :-)
>>
>> I had a question on the DCmdArgument - I think I am
>> not reading
>> this correctly:
>>
>> Coupl
On 14/02/2012 18:55, Karen Kinnear wrote:
Thank you Nils :-)
I had a question on the DCmdArgument - I think I am
not reading
this correctly:
Couple of questions please:
I haven't seen the specification at this level of detail, but I thought
that if
you entered a digit value with no units tha
Thank you Nils :-)
I had a question on the DCmdArgument - I think I am not
reading
this correctly:
Couple of questions please:
1) What is this doing?
if (idx == len) {
143
// only accept missing unit if the value is 0
144
if (_value._time != 0) {
145
THROW_MSG(vmS
Forgot an important point - the testing
First I ran all the testing we have for the tracing framework that makes use of
these commands.
I have also debugged through with frivolous command lines to make sure we don't
do anything bad, like crash.
Also I've manually tried to use all the combination
Thanks all for suggestions on improvements.
I have an updated webrev here:
http://cr.openjdk.java.net/~nloodin/7145243/webrev.01/
Regards
Nils Loodin
PS: Note - Frederic Parain has graciously taken upon himself to sponsor this.
Many thanks!
DS
On Feb 13, 2012, at 22:58 , Nils Loodin wrote:
>
Changeset: 1891640ca63f
Author:fparain
Date: 2012-02-14 06:54 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1891640ca63f
7143760: Memory leak in GarbageCollectionNotifications
Reviewed-by: dholmes, dcubed, kamg
! src/share/vm/services/gcNotifier.cpp
! src/share/v
Looks good to me.
--
- Keith
Frederic Parain wrote:
Here's the new webrev:
http://cr.openjdk.java.net/~fparain/7143760/webrev.02/
The changes are:
- fix typo in comments
- roll-back wrong THREAD->CHECK modifications
- add a wrapper catching exceptions around the method
sending notificat
On 2/13/12 3:11 AM, Frederic Parain wrote:
Here's the new webrev:
http://cr.openjdk.java.net/~fparain/7143760/webrev.02/
Please update the copyright years to 2012.
src/share/vm/services/gcNotifier.hpp
No comment.
src/share/vm/services/gcNotifier.cpp
nit line 185: space missing in 'if(
Changeset: f62077973f9b
Author:vinnie
Date: 2012-02-14 11:47 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f62077973f9b
7142888: sun/security/tools/jarsigner/ec.sh fail on sparc
Reviewed-by: xuelei
! test/sun/security/tools/jarsigner/ec.sh
This is a request for review for 7144833:
sun/tools/jcmd/jcmd-Defaults.sh failing intermittently
Bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144833
The problem occurs when one or several lines printed by the jcmd tool
match several rules in the awk script checking the output. The
This is a request for review for 7144833:
sun/tools/jcmd/jcmd-Defaults.sh failing intermittently
Bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144833
The problem occurs when one or several lines printed by the jcmd tool
match several rules in the awk script checking the output. The
Hi Nils,
I can be the sponsor for this one.
Here's my comments:
diagnosticFramework.cpp:77-79
why do you need:
77 if (_buffer[_cursor] == _delim) {
78 _cursor++;
79 }
When there's this loop just a few lines above:
64 while (_cursor < _len - 1 && _buffer[_cursor] == _delim)
22 matches
Mail list logo
