Changeset: 45804d661008
Author:xuelei
Date: 2012-02-15 23:45 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45804d661008
7145837: a little performance improvement on the usage of SecureRandom
Reviewed-by: chegar, wetmore
! src/share/classes/sun/security/ssl/CipherSuite.java
Changeset: f1cb6f9cfe21
Author:fparain
Date: 2012-02-15 12:17 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f1cb6f9cfe21
7145243: Need additional specializations for argument parsing framework
Reviewed-by: acorn, fparain
Contributed-by: nils.loo...@oracle.com
! s
On 2/15/12 1:34 PM, Staffan Larsen wrote:
That's what I guessed. So essentially all the code the is in the #else part of
#ifdef _ALLBSD_SOURCE under src/os/bsd can be removed and the #ifdef
_ALLBSD_SOURCE can be skipped. Like so:
#ifdef _ALLBSD_SOURCE
xxx;
#else
yyy;
#endif
can be cha
That's what I guessed. So essentially all the code the is in the #else part of
#ifdef _ALLBSD_SOURCE under src/os/bsd can be removed and the #ifdef
_ALLBSD_SOURCE can be skipped. Like so:
#ifdef _ALLBSD_SOURCE
xxx;
#else
yyy;
#endif
can be changed to:
xxx;
I'll volunteer to do that clea
The src/os/bsd code was derived from the src/os/linux code.
#ifdef _ALLBSD_SOURCE was used to flag (most) changes relative
to Linux for the BSD port. The #ifdef'ing is not perfect because
the Linux code also evolved as the BSD port was being done and
also because sometimes folks forgot to #ifdef t
Thanks!
Paul
On 2/15/12 2:25 PM, Staffan Larsen wrote:
On 15 feb 2012, at 20:03, Paul Hohensee wrote:
On 2/15/12 1:58 PM, Staffan Larsen wrote:
On 15 feb 2012, at 19:49, Paul Hohensee wrote:
Also,
You can move the #include of mach.h into globalDefinitions_gcc.hpp,
in the #ifdef __APPLE__
Reading this again, I wonder: What is the purpose of _ALLBSD_SOURCE in a file
under 'src/os/bsd'? Are there platforms that are 'bad', but do not define
_ALLBSD_SOURCE?
/Staffan
On 15 feb 2012, at 16:16, Daniel D. Daugherty wrote:
> The _ALLBSD_SOURCE symbol is defined by the HotSpot Makefile
On 15 feb 2012, at 20:03, Paul Hohensee wrote:
> On 2/15/12 1:58 PM, Staffan Larsen wrote:
>> On 15 feb 2012, at 19:49, Paul Hohensee wrote:
>>
>>> Also,
>>>
>>> You can move the #include of mach.h into globalDefinitions_gcc.hpp,
>>> in the #ifdef __APPLE__ section. That way, it won't cause a
Right. If you move the #include of mach.h from os_bsd.inline.hpp into
globalDefinitions_gcc.hpp and #undef EFL_AC and EFL_ID in
globalDefinitions_gcc.hpp, then the problem goes away.
Paul
On 2/15/12 1:56 PM, Staffan Larsen wrote:
On 15 feb 2012, at 19:33, Paul Hohensee wrote:
Imo we should a
On 2/15/12 1:58 PM, Staffan Larsen wrote:
On 15 feb 2012, at 19:49, Paul Hohensee wrote:
Also,
You can move the #include of mach.h into globalDefinitions_gcc.hpp,
in the #ifdef __APPLE__ section. That way, it won't cause a compile-
time error on non-osx platforms that don't have it.
I dislik
Unfortunately I can't verify if other bsd builds fail as we have none at our
disposal.
/Staffan
On 15 feb 2012, at 14:57, Mikael Gerdin wrote:
> Hi Staffan,
>
> It looks like you're adding Mac-specific stuff like thread_t and calls to
> ::mach_thread_self() inside _ALLBSD_SOURCE #ifdefs, are
On 15 feb 2012, at 12:52, David Holmes wrote:
> Hi Staffan,
>
> Not directly related to the change but what does _ALLBSD_SOURCE signify?
What Dan said (I wasn't sure myself).
> In os_bsd.cpp:
>
> In os::thread_cpu_time the type of mach_thread has changed from mach_port_t
> to thread_t, but
On 15 feb 2012, at 19:49, Paul Hohensee wrote:
> Also,
>
> You can move the #include of mach.h into globalDefinitions_gcc.hpp,
> in the #ifdef __APPLE__ section. That way, it won't cause a compile-
> time error on non-osx platforms that don't have it.
I dislike adding more stuff to globalDefin
On 15 feb 2012, at 19:33, Paul Hohensee wrote:
> Imo we should at least try to make non-osx bsd builds work, since
> the original code did work for non-osx builds. This change doesn't
> do that.
>
> In globalDefinitions_gcc.hpp, if you keep the lines
>
> #undef ELF_AC
> #undef EFL_ID
>
> then
Also,
You can move the #include of mach.h into globalDefinitions_gcc.hpp,
in the #ifdef __APPLE__ section. That way, it won't cause a compile-
time error on non-osx platforms that don't have it.
The declaration of _thread_id, thread_id() and set_thread_id() in
os_bsd.hpp
can be put under a #i
Changeset: 20d39a0e6fdc
Author:fparain
Date: 2012-02-15 10:46 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/20d39a0e6fdc
7145925: Removing remote access to diagnostic commands in the
HotSpotDiagnosticMBean
Reviewed-by: acorn, mchung, phh
! make/java/management/mapfile-vers
Imo we should at least try to make non-osx bsd builds work, since
the original code did work for non-osx builds. This change doesn't
do that.
In globalDefinitions_gcc.hpp, if you keep the lines
#undef ELF_AC
#undef EFL_ID
then you don't have to change vm_version_x86.hpp.
Paul
On 2/15/12 10:1
Changeset: b962e9c3eba2
Author:alanb
Date: 2012-02-15 17:32 +
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b962e9c3eba2
7145910: Remove dependency on apt and com.sun.mirror API (breaks boot cycle
builds)
Reviewed-by: ohair
! jaxws.properties
Changeset: 59884f656b7d
Author:fparain
Date: 2012-02-15 09:29 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59884f656b7d
7144833: sun/tools/jcmd/jcmd-Defaults.sh failing intermittently
Reviewed-by: alanb
! test/ProblemList.txt
! test/sun/tools/jcmd/jcmd_Output1.awk
Changeset: 2b150750d53d
Author:sspitsyn
Date: 2012-02-14 17:04 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2b150750d53d
7130993: nsk/jdi/ReferenceType/instances/instances004 fails with JFR:
assert(ServiceUtil::visible_oop(obj))
Summary: Skip reporting invisible
The _ALLBSD_SOURCE symbol is defined by the HotSpot Makefile infrastructure.
It is used to identify code specific to the BSD family of OSes.
The __APPLE__ symbol is defined by the Apple compiler(s) and it is used to
identify code specific to MacOS X.
Typically you'll see something like:
#ifdef _
Hi Staffan,
It looks like you're adding Mac-specific stuff like thread_t and calls
to ::mach_thread_self() inside _ALLBSD_SOURCE #ifdefs, are you sure this
won't break BSD builds?
Does the OSX compiler define _ALLBSD_SOURCE or is that for
(free|net|open)bsd?
It's too bad we don't do regular bu
Looks good. Thank you.
And I will deal with the early event work when we add more events in terms of
exactly how early we need to initialize the tracing subsystem.
thanks,
Karen
On Feb 15, 2012, at 6:38 AM, Nils Loodin wrote:
> Thank you all for suggesting even more improvements!
>
> Updated t
Changeset: 0720542d6c1e
Author:mullan
Date: 2012-02-15 07:45 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0720542d6c1e
7024604: OID.1 causes IAE in X500Principal constructor
Reviewed-by: vinnie
! src/share/classes/javax/security/auth/x500/X500Principal.java
! src/share/cla
Hi Staffan,
Not directly related to the change but what does _ALLBSD_SOURCE signify?
In os_bsd.cpp:
In os::thread_cpu_time the type of mach_thread has changed from
mach_port_t to thread_t, but mach_thread is still passed into
thread_info(). I expect they are both simple integral types, but I
Thank you all for suggesting even more improvements!
Updated the webrev and put it here:
http://cr.openjdk.java.net/~nloodin/7145243/webrev.02/
Regards,
Nils Loodin
On Feb 14, 2012, at 18:29 , Nils Loodin wrote:
> Thanks all for suggestions on improvements.
> I have an updated webrev here:
> h
Forgot to reply all..
/Nisse
Begin forwarded message:
> From: Nils Loodin
> Subject: Re: Diagnostic command fixes
> Date: February 15, 2012 12:27:19 GMT+01:00
> To: David Holmes
>
>
> On Feb 15, 2012, at 4:03 , David Holmes wrote:
>
>> Hi Nils,
>>
>> I only glanced at this and though the c
On 2/15/2012 2:34 AM, David Holmes wrote:
On 15/02/2012 7:20 AM, keith mcguigan wrote:
Well, ok, I guess it's not the smallest code change -- I think I've
matched this before -- but I guarantee you won't see one smaller than
this!
It's a one-liner (a one-character-er) to accept 0 as a succes
Please review the following change:
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132070
Webrev: http://cr.openjdk.java.net/~sla/7132070/webrev.00/
This changes the value returned by OSThread::thread_id() and
os::current_thread_id() on macosx to return the mach thread_t instead of
p
Thanks Alan,
I've fixed the indentation in the BEGIN block.
Fred
On 02/15/12 10:04 AM, Alan Bateman wrote:
On 14/02/2012 11:01, Frederic Parain wrote:
This is a request for review for 7144833:
sun/tools/jcmd/jcmd-Defaults.sh failing intermittently
Bug:
http://bugs.sun.com/bugdatabase/view_bu
Changeset: 13aef38438d8
Author:fparain
Date: 2012-02-14 07:28 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13aef38438d8
7140868: TEST_BUG: jcmd tests need to use -XX:+UsePerfData
Reviewed-by: fparain, dholmes
! test/sun/tools/jcmd/jcmd-Defaults.sh
! test/sun/tools/jcmd/jcm
On 14/02/2012 11:01, Frederic Parain wrote:
This is a request for review for 7144833:
sun/tools/jcmd/jcmd-Defaults.sh failing intermittently
Bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144833
The problem occurs when one or several lines printed by the jcmd tool
match several rule
32 matches
Mail list logo
