Re: RFR(S): 7079093 & 7073626: cygwin problems in tests

Staffan, Looks good for me! -Dmitry On 2012-02-24 20:12, Staffan Larsen wrote: > Please review the following changes: > > webrev: http://cr.openjdk.java.net/~sla/7073626/webrev.00/ > > This is a combo review for the following two bugs (although I will push > as two changes): > > http://bugs.

hg: jdk8/tl/jdk: 7079093: TEST_BUG: java/lang/instrument/ManifestTest.sh fails with cygwin

Changeset: 4893a89b4916 Author:sla Date: 2012-02-24 20:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4893a89b4916 7079093: TEST_BUG: java/lang/instrument/ManifestTest.sh fails with cygwin Summary: Work around problems in some cygwin installations Reviewed-by: alanb, sspit

hg: jdk8/tl/jdk: 7073626: RmiBootstrapTest.sh and RmiSslBootstrapTest.sh fail under Cygwin

Changeset: 585f2c72d042 Author:sla Date: 2012-02-24 20:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/585f2c72d042 7073626: RmiBootstrapTest.sh and RmiSslBootstrapTest.sh fail under Cygwin Summary: Detect and handle cygwin correctly Reviewed-by: alanb, sspitsyn ! test/Pro

hg: jdk8/tl/langtools: 7137836: tidy up Names.java

Changeset: e6b5c3aff85c Author:jjg Date: 2012-02-24 10:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e6b5c3aff85c 7137836: tidy up Names.java Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/util/Names.java

Re: RFR(S): 7079093 & 7073626: cygwin problems in tests

Looks good. A copyright comment year must be 2012. Thanks, Serguei On 2/24/12 8:12 AM, Staffan Larsen wrote: Please review the following changes: webrev: http://cr.openjdk.java.net/~sla/7073626/webrev.00/ This is a combo review for the

RE: RFR: 6988220: java.lang.ObjectName use of String.intern() causes major performance issues at scale

Hi, Dan. > Just FYI: I haven't seen Éamonn's posting come in. Just replies to his > posting. This may mean that other comments are stuck in the ether > somewhere... > > I suspect that the OpenJDK list server is again having issues... I just checked the core-libs-dev admin interface to see if an

Re: RFR(S): 7079093 & 7073626: cygwin problems in tests

On 24 feb 2012, at 17:35, Alan Bateman wrote: > Looks good to me. I see you've commented out ManifestTest.sh in the > ProblemList and I assume it can be removed completely. Yes, will fix. Thanks, /Staffan

Re: RFR(S): 7079093 & 7073626: cygwin problems in tests

On 24/02/2012 16:12, Staffan Larsen wrote: Please review the following changes: webrev: http://cr.openjdk.java.net/~sla/7073626/webrev.00/ This is a combo review for the following two bugs (although I will push as two changes): http://

RFR(S): 7079093 & 7073626: cygwin problems in tests

Please review the following changes: webrev: http://cr.openjdk.java.net/~sla/7073626/webrev.00/ This is a combo review for the following two bugs (although I will push as two changes): http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079093 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=

Re: RFR: 6988220: java.lang.ObjectName use of String.intern() causes major performance issues at scale

Hi Dan, I got a bounce from serviceability-dev because I wasn't subscribed to it, but the message went out to core-libs-dev because I was subscribed to that. That probably explains what you saw. Regards, Éamonn On 24 February 2012 09:33, Daniel D. Daugherty wrote: > > Just FYI: I haven't seen

Re: RFR: 6988220: java.lang.ObjectName use of String.intern() causes major performance issues at scale

Just FYI: I haven't seen Éamonn's posting come in. Just replies to his posting. This may mean that other comments are stuck in the ether somewhere... I suspect that the OpenJDK list server is again having issues... Dan On 2/24/12 8:21 AM, Olivier Lagneau wrote: I think I have not been clear e

Re: RFR: 6988220: java.lang.ObjectName use of String.intern() causes major performance issues at scale

I think I have not been clear enough here. I Agree with Eammon's argument, and anyway ok with this change. Olivier. Olivier Lagneau said on date 2/24/2012 12:38 PM: Hi Éamonn, Eamonn McManus said on date 2/23/2012 8:44 PM: I am not sure it is worth the complexity of extra checks. Do you ha

Re: SA frontends

Hi Poonam, On 23 Feb 2012, at 07:18, Poonam Bajaj wrote: > > SA-Plugin for VisualVM uses HotspotAgent - SA interface provided by class > sun.jvm.hotspot.HotSpotAgent. SA-Plugin uses the attach/detach functionality > provided by this class and it uses other SA classes (e.g. > sun.jvm.hotspot.ru

Re: RFR: 6988220: java.lang.ObjectName use of String.intern() causes major performance issues at scale

Hi Éamonn, Eamonn McManus said on date 2/23/2012 8:44 PM: I am not sure it is worth the complexity of extra checks. Do you have data showing that ObjectName.equals usually returns false?In a successful HashMap lookup, for example, it will usually return true since the equals method is used to

hg: jdk8/tl/jdk: 7144488: Infinite recursion for some equals tests in Collections

Changeset: 0a350fb8b174 Author:coffeys Date: 2012-02-24 09:17 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a350fb8b174 7144488: Infinite recursion for some equals tests in Collections Reviewed-by: alanb, dholmes, mduigou ! src/share/classes/java/util/Collections.java + te

Re: RFR: 6988220: java.lang.ObjectName use of String.intern() causes major performance issues at scale

On 2/23/12 7:46 PM, David Schlosnagle wrote: Was the main bottleneck the contention on the interned string pool that prevented concurrent addition of ObjectNames? Are there other places within the JDK where use of intern() should be analyzed for similar scalability bottlenecks? I'm also curious

hg: jdk8/tl/jdk: 7133138: Improve io performance around timezone lookups

Changeset: a589a8dbde79 Author:coffeys Date: 2012-02-24 09:10 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a589a8dbde79 7133138: Improve io performance around timezone lookups Reviewed-by: okutsu ! make/tools/src/build/tools/javazic/Mappings.java ! src/share/classes/sun/ut

RE: RFR: 6988220: java.lang.ObjectName use of String.intern() causes major performance issues at scale

Hi, Though "compareTo" tends to be less efficient than "equals", it offers better type safety. When we (mistakenly!) compare objects of different type, "equals" silently accepts parameter of wrong type, but returns false. Comparison with "compareTo" is rejected by compiler. Consider, String

Re: RFR: 6988220: java.lang.ObjectName use of String.intern() causes major performance issues at scale

Making String.intern() more scalable doesn't seem to be a solution for short (or medium?) time frame. Even if the computation cost of ObjectName.equals() is increased by this fix, there's no performance measurement in favor or against this change. I've looked for benchmarks stressing the ObjectNam

Re: RFR: 6988220: java.lang.ObjectName use of String.intern() causes major performance issues at scale

Making String.intern() more scalable doesn't seem to be a solution for short (or medium?) time frame. Even if the computation cost of ObjectName.equals() is increased by this fix, there's no performance measurement in favor or against this change. I've looked for benchmarks stressing the ObjectNam

Re: RFR: 6988220: java.lang.ObjectName use of String.intern() causes major performance issues at scale

I'm in favor of not adding complexity to ObjectName.equals(). The goal of this CR is to remove a bottleneck created by the use of String.intern() in ObjectName's constructors. This CR doesn't aim to optimize the ObjectName.equals() method. An application can define an optimized method to compare