Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-16 Thread serguei.spit...@oracle.com
Dan, I've reviewed this: http://cr.openjdk.java.net/~dcubed/fds_revamp/7102323-webrev/1-hotspot-full/ Wow, you fixed two existing bugs in the make file: *make/solaris/makefiles/dtrace.make * -[ -f $(XLIBJVM_DB_G_DEBUGINFO) ] || { ln -s $(LIBJVM_DB_DEBUGINFO) $(XLIBJVM_DB_G_DEB

hg: hsx/hotspot-rt/hotspot: 7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6

2012-03-16 Thread coleen . phillimore
Changeset: 970cbbba54b0 Author:jmelvin Date: 2012-03-16 15:13 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/970cbbba54b0 7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6 Summary: On Mac OS X, align system property "os.arch" w

code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-16 Thread Daniel D. Daugherty
Greetings, I need code reviews for some Makefile and packaging changes. Wait, come back! They're not that scary... These are Full Debug Symbols changes... so maybe they are that scary... These changes have gone through two rounds of internal review. The following bugs are being used to revamp

hg: jdk8/tl/jdk: 7152007: Fix warnings in sun/rmi/rmic

2012-03-16 Thread kurchi . subhra . hazra
Changeset: 337d4570b8d6 Author:khazra Date: 2012-03-16 11:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/337d4570b8d6 7152007: Fix warnings in sun/rmi/rmic Summary: Minor code changes to remove warnings in sun/rmi/rmic Reviewed-by: chegar, smarks ! src/share/classes/sun/r

Re: RFR (and sponsor): 7148488: Whitebox tests for the Diagnostic Framework Parser

2012-03-16 Thread Mikael Gerdin
Hi, just a small nitpick in parserTests.cpp: 41: const char* lookup_diagnosticArgumentEnum(const char* field_name, oop object) and 52: void fill_in_parser(DCmdParser* parser, oop argument) should probably be static (in the C sense). Otherwise it looks good. /Mikael On 2012-03-15 13:45, Nils

hg: hsx/hotspot-rt/jaxws: 7 new changesets

2012-03-16 Thread john . coomes
Changeset: 5600254058a1 Author:michaelm Date: 2012-03-06 20:26 + URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/5600254058a1 7113349: Initial changeset for Macosx port to jdk Reviewed-by: jjh, alanb, dholmes, anthony, ohrstrom, ksrini, jrose, weijun, smarks Contribute

hg: hsx/hotspot-rt/corba: 4 new changesets

2012-03-16 Thread john . coomes
Changeset: f7718662741d Author:michaelm Date: 2012-03-06 20:25 + URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/f7718662741d 7113349: Initial changeset for Macosx port to jdk Reviewed-by: jjh, alanb, dholmes, anthony, ohrstrom, ksrini, jrose, weijun, smarks Contribute

hg: hsx/hotspot-rt: 4 new changesets

2012-03-16 Thread john . coomes
Changeset: 84ece503953e Author:michaelm Date: 2012-03-06 20:25 + URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/84ece503953e 7113349: Initial changeset for Macosx port to jdk Reviewed-by: jjh, alanb, dholmes, anthony, ohrstrom, ksrini, jrose, weijun, smarks Contributed-by:

hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b30 for changeset 3be30c25a825

2012-03-16 Thread john . coomes
Changeset: 94aabe098916 Author:katleman Date: 2012-03-15 15:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/94aabe098916 Added tag jdk8-b30 for changeset 3be30c25a825 ! .hgtags

Re: RFR 7152798: TEST_BUG: sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java does not compile

2012-03-16 Thread serguei.spit...@oracle.com
Staffan, Looks good. Thanks, Serguei On 3/16/12 1:14 AM, Staffan Larsen wrote: Thanks Alan. Anyone else? /Staffan On 15 mar 2012, at 11:41, Alan Bateman wrote: On 15/03/2012 09:30, Staffan Larsen wrote: Please review the following change to allow a test to be compiled that was previousl

Re: RFR 7152798: TEST_BUG: sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java does not compile

2012-03-16 Thread Rickard Bäckman
Staffan, changes look good. /R On Mar 16, 2012, at 9:14 AM, Staffan Larsen wrote: > Thanks Alan. > > Anyone else? > > /Staffan > > On 15 mar 2012, at 11:41, Alan Bateman wrote: > >> On 15/03/2012 09:30, Staffan Larsen wrote: >>> Please review the following change to allow a test to be compi

Re: RFR: 7154113: jcmd, jps and jstat tests failing when there are unknown Java processes on the system

2012-03-16 Thread Rickard Bäckman
Staffan, nice fixes, looks good to me. /R On Mar 16, 2012, at 9:10 AM, Staffan Larsen wrote: > Please review the following test fixes. > > Webrev: http://cr.openjdk.java.net/~sla/7154114/webrev.01/ > > The bugs are not available on the public server yet, but below is the text of > the bugs.

Re: RFR 7152798: TEST_BUG: sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java does not compile

2012-03-16 Thread Staffan Larsen
Thanks Alan. Anyone else? /Staffan On 15 mar 2012, at 11:41, Alan Bateman wrote: > On 15/03/2012 09:30, Staffan Larsen wrote: >> Please review the following change to allow a test to be compiled that was >> previously not being run. >> >> Webrev: http://cr.openjdk.java.net/~sla/7152798/webrev

RFR: 7154113: jcmd, jps and jstat tests failing when there are unknown Java processes on the system

2012-03-16 Thread Staffan Larsen
Please review the following test fixes. Webrev: http://cr.openjdk.java.net/~sla/7154114/webrev.01/ The bugs are not available on the public server yet, but below is the text of the bugs. I intend to submit both fixes as one push. Fixes have been verified in JPRT. Thanks, /Staffan - 7

hg: jdk8/tl/jdk: 7145419: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events.

2012-03-16 Thread rickard . backman
Changeset: fa957635aa40 Author:rbackman Date: 2012-03-14 08:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fa957635aa40 7145419: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. Summary: Add more packages to filter avoids failing on ev