Request for review: 7154670: The instanceKlass _implementors[] and _nof_implementors are not needed for non-interface klass

2012-03-20 Thread Jiangli Zhou
Hi, Please review following webrev that changes the instanceKlass::_implementors[] to an embedded instanceKlass field: http://cr.openjdk.java.net/~jiangli/7154670/webrev.00/ The embedded implementor field is only created for interfaces. Since the VM/compiler does not seem to use the implem

hg: hsx/hotspot-rt/hotspot: 7144328: Improper commandlines for -XX:+-UnlockCommercialFeatures require proper warning/error messages

2012-03-20 Thread coleen . phillimore
Changeset: 80fe40862b02 Author:jmelvin Date: 2012-03-20 16:46 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/80fe40862b02 7144328: Improper commandlines for -XX:+-UnlockCommercialFeatures require proper warning/error messages Summary: Provide custom error messages

hg: jdk8/tl/jdk: 7146728: Inconsistent length for the generated secret using DH key agreement impl from SunJCE and PKCS11

2012-03-20 Thread valerie . peng
Changeset: 4c4d2337dfad Author:valeriep Date: 2012-03-20 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c4d2337dfad 7146728: Inconsistent length for the generated secret using DH key agreement impl from SunJCE and PKCS11 Summary: Always return the secret in the same l

Re: RFR: 7152800: All tests using the attach API fail with "well-known file is not secure" on Mac OS X

2012-03-20 Thread Dean Long
OK. dl On 3/20/2012 3:27 AM, Staffan Larsen wrote: I couldn't make it work on OSX. But this means that we should probably chown the file explicitly on linux as well to make sure it gets the right permissions in the case where the directory has the setgid bit set. Thanks, /Staffan On 19 mar

hg: jdk8/tl/jdk: 7154114: jstat tests failing on non-english locales; ...

2012-03-20 Thread staffan . larsen
Changeset: 2dc35f14bf17 Author:sla Date: 2012-03-20 12:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2dc35f14bf17 7154114: jstat tests failing on non-english locales 7154113: jcmd, jps and jstat tests failing when there are unknown Java processes on the system Reviewed-b

Re: RFR: 7154113: jcmd, jps and jstat tests failing when there are unknown Java processes on the system

2012-03-20 Thread Staffan Larsen
On 20 mar 2012, at 11:57, Dmitry Samersoff wrote: > Staffan, > > 1. > > test/sun/tools/jstatd/jstatdServerName.sh:89 > > echo output not changed. I'll fix this. > 2. AWK patterns has extra space >/^[0-9]+ $/ > is it intentional? Is this space always here? Yes, the space is always there

hg: jdk8/tl/jdk: 7152176: More krb5 tests

2012-03-20 Thread weijun . wang
Changeset: 0d1c576980a0 Author:weijun Date: 2012-03-20 19:12 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d1c576980a0 7152176: More krb5 tests Reviewed-by: xuelei + test/sun/security/krb5/auto/Basic.java ! test/sun/security/krb5/auto/Context.java + test/sun/security/krb5/

Re: RFR: 7154113: jcmd, jps and jstat tests failing when there are unknown Java processes on the system

2012-03-20 Thread Keith McGuigan
Sure. Looks good! -- - Keith On 3/20/2012 6:37 AM, Staffan Larsen wrote: I'd love to get another review of this by a Reviewer. Someone, please? Thanks, /Staffan On 16 mar 2012, at 09:25, Rickard Bäckman wrote: Staffan, nice fixes, looks good to me. /R On Mar 16, 2012, at 9:10 AM, Staff

Re: RFR: 7154113: jcmd, jps and jstat tests failing when there are unknown Java processes on the system

2012-03-20 Thread Dmitry Samersoff
Staffan, 1. test/sun/tools/jstatd/jstatdServerName.sh:89 echo output not changed. 2. AWK patterns has extra space /^[0-9]+ $/ is it intentional? Is this space always here? Otherwise looks good. -Dmitry On 2012-03-20 14:37, Staffan Larsen wrote: > I'd love to get another review of th

Re: RFR: 7154113: jcmd, jps and jstat tests failing when there are unknown Java processes on the system

2012-03-20 Thread Staffan Larsen
I'd love to get another review of this by a Reviewer. Someone, please? Thanks, /Staffan On 16 mar 2012, at 09:25, Rickard Bäckman wrote: > Staffan, > > nice fixes, looks good to me. > > /R > > On Mar 16, 2012, at 9:10 AM, Staffan Larsen wrote: > >> Please review the following test fixes. >>

Re: RFR: 7152800: All tests using the attach API fail with "well-known file is not secure" on Mac OS X

2012-03-20 Thread Staffan Larsen
I couldn't make it work on OSX. But this means that we should probably chown the file explicitly on linux as well to make sure it gets the right permissions in the case where the directory has the setgid bit set. Thanks, /Staffan On 19 mar 2012, at 20:38, Dean Long wrote: > On linux, you can c