hg: jdk8/tl/jdk: 7155300: Include pthread.h on all POSIX platforms except Solaris to improve portability

2012-03-21 Thread littlee
Changeset: 1d418ec212ea Author:zhangshj Date: 2012-03-22 12:30 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d418ec212ea 7155300: Include pthread.h on all POSIX platforms except Solaris to improve portability Reviewed-by: alanb, dholmes ! src/solaris/bin/java_md.c ! src/s

Re: Patch to fix build breakage with GCC 4.7

2012-03-21 Thread David Holmes
On 22/03/2012 12:30 PM, Daniel D. Daugherty wrote: That would be this: Changeset: fb3a2cafc230 Author: andrew Date: 2012-03-08 14:04 + URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb3a2cafc230 Thanks Dan! I see it came in through the build repo which is why I couldn't find it. Now I

Re: Patch to fix build breakage with GCC 4.7

2012-03-21 Thread Daniel D. Daugherty
That would be this: Changeset: fb3a2cafc230 Author:andrew Date: 2012-03-08 14:04 + URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb3a2cafc230 7150392: Linux build breaks with GCC 4.7 due to unrecognized option Summary: Remove -mimpure-text option. Reviewed-by: ohair, dholm

Re: Patch to fix build breakage with GCC 4.7

2012-03-21 Thread David Holmes
Did this get pushed somewhere? David On 3/03/2012 1:11 AM, Deepak Bhole wrote: * Andrew Hughes [2012-03-02 10:09]: - Original Message - * Andrew Hughes [2012-03-01 15:40]: - Original Message - * Kelly O'Hair [2012-02-29 20:39]: The sample.makefile.txt files may not even

hg: jdk8/tl/jdk: 7145454: JVM wide monitor lock in Currency.getInstance(String)

2012-03-21 Thread naoto . sato
Changeset: 4a5817f9e249 Author:naoto Date: 2012-03-21 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a5817f9e249 7145454: JVM wide monitor lock in Currency.getInstance(String) Reviewed-by: okutsu ! src/share/classes/java/util/Currency.java

Re: RFR (and sponsor): 7148488: Whitebox tests for the Diagnostic Framework Parser

2012-03-21 Thread Nils Loodin
Updated webrev as per Dmitrys' comments as well! http://cr.openjdk.java.net/~nloodin/7148488/webrev.03/ To anser questions: > 1. It seems to me if array doesn't fit to buf we have spare coma at the > end. Is it intentional? No, but it doesn't matter. Test will fail and buffer will have to be a

Re: RFR (and sponsor): 7148488: Whitebox tests for the Diagnostic Framework Parser

2012-03-21 Thread Nils Loodin
Updated it to take into account the discussion with Bengt. Also had a small ad-hoc discussion with Stefan K and Mikael Gerdin today about the path issue in create_obj_files.sh, and they seemed content to leave it as it is for now. Last (hopefully) update here: http://cr.openjdk.java.net/~nloodi

Re: RFR (and sponsor): 7148488: Whitebox tests for the Diagnostic Framework Parser

2012-03-21 Thread Dmitry Samersoff
Nils, 66 void GenDCmdArgument::to_string(StringArrayArgument* f, char* buf, size_t len) { 1. It seems to me if array doesn't fit to buf we have spare coma at the end. Is it intentional? 2. We don't check whether we have enough room for comma in a buf. So we can overflow it. So I would recommend

Re: RFR (and sponsor): 7148488: Whitebox tests for the Diagnostic Framework Parser

2012-03-21 Thread Nils Loodin
Good idea. Refereshed this based on your comments and those of Staffan Larsen. New webrev is at http://cr.openjdk.java.net/~nloodin/7148488/webrev.01/ Need one more reviewer-status reviewer then! Regards, Nils Loodin On Mar 16, 2012, at 16:31 , Mikael Gerdin wrote: > Hi, > > just a small nitp