cr7154822 : Request for code review

Hi! Please review my fix for the following bug : [ Bug ID: 7154822 forward port fix for Bug 13645891 to JDK8 jcmd (1024 byte file size limit issue) ] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154822 The issue is there is an arbitrary limit in the size of a script file you pass to t

hg: hsx/hotspot-rt/hotspot: 7156960: Incorrect copyright headers in parts of the Serviceability agent

Changeset: 4bec1b1f7b33 Author:minqi Date: 2012-03-28 14:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4bec1b1f7b33 7156960: Incorrect copyright headers in parts of the Serviceability agent Summary: Errant files added as part of 7088955 fix. The Copyright infor

RE: RFR(XS): 7154809 JDI: update JDI/JDB debugee commandline option parsing (allow nested comma delimited options) + sponsor request

Dan, Dmitry, everybody, Thank you so far for your input. Dan, you are absolutely right in your reflection about " " combined with 'split("\\s+")' regexp - this will split the strings to " and " which does not work. We should also try to cover this. This turned out a lot trickier than I origina

Re: RFR(XS): 7087969: GarbageCollectorMXBean notification contains ticks vs millis

On 3/27/12 7:12 AM, Frederic Parain wrote: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7087969 The fix is very simple, converting ticks into milliseconds before using them to create the notification. This fix makes the notification consistent with the other API returning GcInfo instan

hg: hsx/hotspot-rt/hotspot: 13 new changesets

Changeset: ee138854b3a6 Author:kvn Date: 2012-03-12 10:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ee138854b3a6 7147744: CTW: assert(false) failed: infinite EA connection graph build Summary: rewrote Connection graph construction code in EA to reduce time spe

hg: jdk8/tl/jdk: 7156831: The jcmd man page is not included in generated bundles

Changeset: 62228dc7a4ac Author:fparain Date: 2012-03-28 02:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62228dc7a4ac 7156831: The jcmd man page is not included in generated bundles Reviewed-by: dholmes, sla, dsamersoff ! make/common/Release.gmk

Re: Request for review: 7156831: The jcmd man page is not included in generated bundles

Looks okay to me. David On 27/03/2012 1:40 AM, Frederic Parain wrote: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7156831 (The bug is not yet visible but it will become visible soon). The bug is very simple: the man page of the jcmd utility is not included in bundles because it is

Re: CRR(S): 7156960: Incorrect copyright headers in parts of the Serviceability agent

Looks good! /Staffan On 28 mar 2012, at 02:03, Yumin Qi wrote: > Hi, all > > Can I have your codereview of bug 7156960: > > We miss some Copyright information in SA code, here is the webrev: > http://cr.openjdk.java.net/~minqi/7156960/ > > > Thanks > Yumin