Hi Dan,
Thanks you! Not sure how I realized that I needed to set +e for the grep
command but it did not occur to me to do the same thing for the jcmd
invocation.
Here is the new webrev:
http://cr.openjdk.java.net/~dbuck/7154822/webrev.02/
Please let me know what you think.
I tested new ver
Changeset: b1af41b86f9f
Author:littlee
Date: 2012-03-12 13:30 +0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b1af41b86f9f
7151427: Fix the potential memory leak in error handling code in
X11SurfaceData.c
Summary: Free the memory in the error handling code.
Reviewed-by
Changeset: ea80b2388dce
Author:cl
Date: 2012-03-29 13:02 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/ea80b2388dce
Added tag jdk8-b32 for changeset 017a7dbfaa92
! .hgtags
Changeset: 9bcab2b8b8ea
Author:cl
Date: 2012-03-29 13:02 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/9bcab2b8b8ea
Added tag jdk8-b32 for changeset 60960fbc75df
! .hgtags
Changeset: 1e2ac1ea3f6c
Author:cl
Date: 2012-03-29 13:02 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/1e2ac1ea3f6c
Added tag jdk8-b32 for changeset 5d820cb6b1af
! .hgtags
Changeset: 42f275168fa5
Author:cl
Date: 2012-03-29 13:02 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/42f275168fa5
Added tag jdk8-b32 for changeset 88176171e940
! .hgtags
On 3/29/12 9:04 PM, David Buck wrote:
Hi!
I would like to submit a new version of the fix for review:
http://cr.openjdk.java.net/~dbuck/7154822/webrev.01/
src/share/classes/sun/tools/jcmd/JCmd.java
No comments.
test/sun/tools/jcmd/dcmd-big-script.txt
No comments.
test/sun/tools/jcmd
Hi!
I would like to submit a new version of the fix for review:
http://cr.openjdk.java.net/~dbuck/7154822/webrev.01/
Changes:
JCmd.java :
1. fixed copyright statement (s/2012/2011, 2012/)
2. changed regular expression used to split up script into lines from
"\\r?\\n" to "\\n"
dcmd-big-s
On 3/28/12 3:13 PM, Markus Grönlund wrote:
Dan, Dmitry, everybody,
Thank you so far for your input.
Dan, you are absolutely right in your reflection about " " combined with
'split("\\s+")' regexp - this will split the strings to" and" which does not work. We
should also try to cover this.
On 29 mar 2012, at 17:11, David Buck wrote:
> Hi!
>
> >> > If the limit is the same for all platforms, then the fix
> >> > could be improved to check that each line is smaller than the
> >> > limit before to send it to the target JVM, and properly
> >> > report an error if it isn't. Right now, e
Hi!
>> > If the limit is the same for all platforms, then the fix
>> > could be improved to check that each line is smaller than the
>> > limit before to send it to the target JVM, and properly
>> > report an error if it isn't. Right now, each platform
>> > throws an IOException with a platform d
Hi Dan,
Thanks for the review!
> src/share/classes/sun/tools/jcmd/JCmd.java
> line 145: would split("$") work here? My memory is rusty but I
> think that catches all forms of line termination.
Good point, "$" should be more portable and easier to read. Will change.
> test/sun/tools/jcmd/jcmd-b
Resending... with David B on the reply...
On 3/29/12 5:49 AM, David Buck wrote:
Hi Frederic,
Thank you for the review!
> I have a question about the 1024 bytes limit.
> Have you tested this limit on the different platforms?
I tested on Solaris, Linux and Windows. They were all 1024.
> Becau
Resending... with David B on the reply...
On 3/28/12 10:28 PM, David Buck wrote:
Hi!
Please review my fix for the following bug :
[ Bug ID: 7154822 forward port fix for Bug 13645891 to JDK8 jcmd (1024
byte file size limit issue) ]
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154822
Th
On 3/29/12 5:49 AM, David Buck wrote:
Hi Frederic,
Thank you for the review!
> I have a question about the 1024 bytes limit.
> Have you tested this limit on the different platforms?
I tested on Solaris, Linux and Windows. They were all 1024.
> Because jcmd uses the attachAPI to send commands
On 3/28/12 10:28 PM, David Buck wrote:
Hi!
Please review my fix for the following bug :
[ Bug ID: 7154822 forward port fix for Bug 13645891 to JDK8 jcmd (1024
byte file size limit issue) ]
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154822
The issue is there is an arbitrary limit in
On 3/29/12 2:34 AM, Frederic Parain wrote:
Replying to both lists this time.
On 03/28/12 05:15 PM, Daniel D. Daugherty wrote:
>> Tested manually and with JPRT by running the jdk_management suite.
>> No new test has been added because the fix is in the HotSpot
repository,
>> and the GarbageColl
Changeset: 9a5bef0481c8
Author:fparain
Date: 2012-03-29 02:12 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9a5bef0481c8
7087969: GarbageCollectorMXBean notification contains ticks vs millis
Reviewed-by: acorn, dcubed, rbackman
! src/share/vm/services/gcNotifier.
Hi Frederic,
Thank you for the review!
> I have a question about the 1024 bytes limit.
> Have you tested this limit on the different platforms?
I tested on Solaris, Linux and Windows. They were all 1024.
> Because jcmd uses the attachAPI to send commands to
> the target JVM and each platform u
Hi David,
I have a question about the 1024 bytes limit.
Have you tested this limit on the different platforms?
Because jcmd uses the attachAPI to send commands to
the target JVM and each platform uses a different mechanism
to implement the attachAPI (Solaris->door, Linux->socket,
Windows->Pipe).
Changeset: b2687ac9cffb
Author:peytoia
Date: 2012-03-29 18:02 +0900
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2687ac9cffb
7070436: Support Unicode 6.1.0 in JDK 8
Reviewed-by: okutsu
! make/tools/GenerateCharacter/CharacterData00.java.template
! make/tools/UnicodeData/PropLis
Replying to both lists this time.
On 03/28/12 05:15 PM, Daniel D. Daugherty wrote:
>> Tested manually and with JPRT by running the jdk_management suite.
>> No new test has been added because the fix is in the HotSpot repository,
>> and the GarbageCollectorMXBean notification unit tests are in the
22 matches
Mail list logo
